Add a missing "null" check when rebuilding old/new diff content
ClosedPublic
Actions

Authored by epriestley on Apr 25 2020, 4:21 PM.

Details

Reviewers: None
Commits: rP18a06b78acf5: (stable) Add a missing "null" check when rebuilding old/new diff content
rP40d2346f2965: Add a missing "null" check when rebuilding old/new diff content

Summary

Until PHP 7.4, $x = null; echo $x['y']; does not emit a warning. Sneaky!

Test Plan

Traced null values from reparseHunksForSpecialAttributes(), saw them no longer incorporated into corpus bodies.
This has some amount of test coverage.

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2020, 4:22 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

differential/

parser/

5 lines