Paths

Table of Contentst

Differential D21169

Add a missing "null" check when rebuilding old/new diff content
ClosedPublic
Actions

Authored by epriestley on Apr 25 2020, 4:21 PM.

Tags

None

Referenced Files

	F15282902: D21169.diff
	Tue, Mar 4, 3:26 AM

	Unknown Object (File)
	Sat, Feb 22, 5:59 PM

	Unknown Object (File)
	Sun, Feb 9, 9:06 AM

	Unknown Object (File)
	Sun, Feb 9, 9:06 AM

	Unknown Object (File)
	Feb 2 2025, 5:09 PM

	Unknown Object (File)
	Jan 30 2025, 2:02 AM

	Unknown Object (File)
	Jan 29 2025, 8:55 AM

	Unknown Object (File)
	Jan 25 2025, 7:20 AM

Subscribers

None

Details

Reviewers: None
Commits: rP18a06b78acf5: (stable) Add a missing "null" check when rebuilding old/new diff content
rP40d2346f2965: Add a missing "null" check when rebuilding old/new diff content

Summary

See https://discourse.phabricator-community.org/t/exceptions-when-viewing-diffs/3787. This list may include null values.

Until PHP 7.4, $x = null; echo $x['y']; does not emit a warning. Sneaky!

Test Plan

Traced null values from reparseHunksForSpecialAttributes(), saw them no longer incorporated into corpus bodies.
This has some amount of test coverage.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 25 2020, 4:21 PM

Harbormaster completed remote builds in B24223: Diff 50404.Apr 25 2020, 4:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 25 2020, 4:22 PM

epriestley requested review of this revision.

Closed by commit rP40d2346f2965: Add a missing "null" check when rebuilding old/new diff content (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP40d2346f2965: Add a missing "null" check when rebuilding old/new diff content.

epriestley added a commit: rP18a06b78acf5: (stable) Add a missing "null" check when rebuilding old/new diff content.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

parser/

DifferentialHunkParser.php

5 lines

Diff 50405

src/applications/differential/parser/DifferentialHunkParser.php

Loading...