Page MenuHomePhabricator

When proxying HTTP repository responses from repository nodes, discard content description headers
ClosedPublic

Authored by epriestley on Apr 25 2020, 2:40 PM.
Tags
None
Referenced Files
F18791603: D21167.id.diff
Thu, Oct 16, 4:08 PM
F18772202: D21167.diff
Thu, Oct 9, 1:04 AM
F18753155: D21167.id50398.diff
Sat, Oct 4, 5:38 PM
F18674204: D21167.diff
Thu, Sep 25, 1:37 PM
F18636122: D21167.diff
Sep 17 2025, 3:33 AM
F18519437: D21167.diff
Sep 5 2025, 4:57 PM
F18166210: D21167.id50398.diff
Aug 15 2025, 9:53 AM
F18092515: D21167.id50399.diff
Aug 7 2025, 11:02 AM
Subscribers
None

Details

Summary

Ref T13517. See that task for details about the underlying issue here.

Currently, we may decode a compressed response, then retransmit it with leftover "Content-Encoding" and "Content-Length" headers. Instead, strip these headers.

Test Plan
  • In a clustered repository setup, cloned a Git repository over HTTP.
  • Before: Error while processing content unencoding: invalid stored block lengths
  • After: Clean clone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable