Page MenuHomePhabricator

When proxying HTTP repository responses from repository nodes, discard content description headers
ClosedPublic

Authored by epriestley on Apr 25 2020, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 6:08 AM
Unknown Object (File)
Sun, Feb 9, 9:06 AM
Unknown Object (File)
Sun, Feb 9, 9:06 AM
Unknown Object (File)
Sun, Feb 9, 9:06 AM
Unknown Object (File)
Sun, Feb 9, 9:06 AM
Unknown Object (File)
Thu, Jan 30, 4:22 PM
Unknown Object (File)
Sun, Jan 26, 5:38 AM
Unknown Object (File)
Sat, Jan 25, 7:20 AM
Subscribers
None

Details

Summary

Ref T13517. See that task for details about the underlying issue here.

Currently, we may decode a compressed response, then retransmit it with leftover "Content-Encoding" and "Content-Length" headers. Instead, strip these headers.

Test Plan
  • In a clustered repository setup, cloned a Git repository over HTTP.
  • Before: Error while processing content unencoding: invalid stored block lengths
  • After: Clean clone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable