Page MenuHomePhabricator

When proxying HTTP repository responses from repository nodes, discard content description headers
ClosedPublic

Authored by epriestley on Apr 25 2020, 2:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 5, 4:52 PM
Unknown Object (File)
Sat, May 31, 9:12 AM
Unknown Object (File)
Fri, May 30, 9:35 AM
Unknown Object (File)
May 29 2025, 6:25 AM
Unknown Object (File)
May 6 2025, 6:24 PM
Unknown Object (File)
May 6 2025, 9:19 AM
Unknown Object (File)
May 6 2025, 7:29 AM
Unknown Object (File)
Apr 27 2025, 9:12 AM
Subscribers
None

Details

Summary

Ref T13517. See that task for details about the underlying issue here.

Currently, we may decode a compressed response, then retransmit it with leftover "Content-Encoding" and "Content-Length" headers. Instead, strip these headers.

Test Plan
  • In a clustered repository setup, cloned a Git repository over HTTP.
  • Before: Error while processing content unencoding: invalid stored block lengths
  • After: Clean clone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable