Page MenuHomePhabricator

When proxying HTTP repository responses from repository nodes, discard content description headers
ClosedPublic

Authored by epriestley on Apr 25 2020, 2:40 PM.
Tags
None
Referenced Files
F15453461: D21167.diff
Sat, Mar 29, 12:00 PM
F15444551: D21167.id50399.diff
Thu, Mar 27, 10:02 AM
F15439955: D21167.id.diff
Wed, Mar 26, 10:29 AM
F15435130: D21167.diff
Tue, Mar 25, 6:57 AM
F15382164: D21167.diff
Fri, Mar 14, 11:02 AM
F15283733: D21167.diff
Tue, Mar 4, 8:23 AM
Unknown Object (File)
Feb 24 2025, 2:42 AM
Unknown Object (File)
Feb 22 2025, 2:33 AM
Subscribers
None

Details

Summary

Ref T13517. See that task for details about the underlying issue here.

Currently, we may decode a compressed response, then retransmit it with leftover "Content-Encoding" and "Content-Length" headers. Instead, strip these headers.

Test Plan
  • In a clustered repository setup, cloned a Git repository over HTTP.
  • Before: Error while processing content unencoding: invalid stored block lengths
  • After: Clean clone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable