" to the upstream editor whitelist
ClosedPublic
Actions

Authored by epriestley on May 1 2020, 7:53 PM.

Tags

None

Referenced Files

	F15574519: D21206.id.diff
	Tue, May 6, 1:56 AM

	F15573597: D21206.id.diff
	Mon, May 5, 9:19 PM

	F15543011: D21206.id.diff
	Fri, Apr 25, 8:10 PM

	F15518932: D21206.id.diff
	Sat, Apr 19, 6:11 PM

	F15500131: D21206.id.diff
	Sun, Apr 13, 4:15 PM

	F15491210: D21206.diff
	Sat, Apr 12, 12:15 AM

	F15459926: D21206.diff
	Mar 31 2025, 6:21 PM

	F15430399: D21206.id.diff
	Mar 24 2025, 7:30 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist

Summary

This supports the IntelliJ IDEA editor.

Test Plan

Looked at the editor settings panel, saw "idea://".
Set my editor pattern to "idea://a?b".
(Did not actually install IntelliJ IDEA.)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 1 2020, 7:53 PM

Harbormaster completed remote builds in B24315: Diff 50500.May 1 2020, 7:54 PM

epriestley requested review of this revision.May 1 2020, 7:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 7:56 PM

Closed by commit rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSecurityConfigOptions.php

3 lines

settings/

panel/

PhabricatorExternalEditorSettingsPanel.php

1 line

Diff 50501

View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php