" to the upstream editor whitelist
ClosedPublic
Actions

Authored by epriestley on May 1 2020, 7:53 PM.

Tags

None

Referenced Files

	F18702573: D21206.id.diff
	Sun, Sep 28, 12:38 AM

	F18678987: D21206.id50501.diff
	Fri, Sep 26, 12:21 AM

	F18671956: D21206.diff
	Thu, Sep 25, 6:04 AM

	F18647186: D21206.diff
	Fri, Sep 19, 12:32 PM

	F18624791: D21206.id.diff
	Sep 15 2025, 9:04 PM

	F18616231: D21206.diff
	Sep 14 2025, 4:40 PM

	F17889433: D21206.id.diff
	Jul 29 2025, 2:42 AM

	F17887868: D21206.id50500.diff
	Jul 29 2025, 1:52 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist

Summary

This supports the IntelliJ IDEA editor.

Test Plan

Looked at the editor settings panel, saw "idea://".
Set my editor pattern to "idea://a?b".
(Did not actually install IntelliJ IDEA.)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 1 2020, 7:53 PM

Harbormaster completed remote builds in B24315: Diff 50500.May 1 2020, 7:54 PM

epriestley requested review of this revision.May 1 2020, 7:54 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 7:56 PM

Closed by commit rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSecurityConfigOptions.php

3 lines

settings/

panel/

PhabricatorExternalEditorSettingsPanel.php

1 line

Diff 50501

View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php