Page MenuHomePhabricator

Route hard-coded "/favicon.ico" requests to a favicon resource
ClosedPublic

Authored by epriestley on May 1 2020, 12:16 PM.
Tags
None
Referenced Files
F15412495: D21195.id.diff
Wed, Mar 19, 1:18 PM
F15408140: D21195.diff
Tue, Mar 18, 9:25 PM
F15394886: D21195.id50479.diff
Sun, Mar 16, 1:59 AM
F15386737: D21195.id50479.diff
Sat, Mar 15, 1:13 AM
F15381868: D21195.id50479.diff
Fri, Mar 14, 9:42 AM
F15333053: D21195.diff
Fri, Mar 7, 11:29 PM
F15316074: D21195.id50479.diff
Thu, Mar 6, 6:21 PM
F15316073: D21195.id50478.diff
Thu, Mar 6, 6:21 PM
Subscribers
None

Details

Summary

See PHI1719. User agents making hard-coded requests to "/favicon.ico" currently 404. This is a mild source of log noise, and we can reasonably route this request.

Limitations:

  • This only routes the "PlatformSite". Other sites (custom Phame blogs, third-party sites, Phurl redirectors) won't route here for now.
  • This returns a "Location:" redirect to the correct resource rather than icon data directly. This produces the right icon with the right caching behavior, and returning icon data directly is difficult in the general case. However, it won't perform/cache as well as a direct response would.
Test Plan
  • Visted /favicon.ico.
  • Before: 404.
  • After: redirect to favicon.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 12:23 PM
This revision was automatically updated to reflect the committed changes.