HomePhabricator
Diffusion Phabricator 304467feb2ae

Stabilize fatals when a build has a build plan the viewer can't see because of…
304467feb2ae
Actions

Description

Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions

Summary:
Ref T13526. Currently, if a build plan is restricted, viewers may fatal when trying to view related builds.

The old behavior allowed them to see the build even if they can not see the build plan. This is sort of incoherent, but try to stabilize things before fixing this.

Test Plan:
This is a muddy change.

  • Created a build with a build plan that Alice can't see.
  • As Alice, viewed the build page (restricted before, restricted after); the buildable page (fatal before, works after).
  • Also viewed a revision page (works before and after, but user-reported fatal).

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13526

Differential Revision: https://secure.phabricator.com/D21194

Details

Provenance
epriestleyAuthored on Apr 30 2020, 2:41 PM
epriestleyPushed on Apr 30 2020, 2:57 PM
Differential Revision
D21194: Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions
Parents
rP186a12ef7f2a: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Branches
Unknown
Tags
Unknown
Tasks
T13526: Error raised when "HarbormasterBuildPlanBehavior->getPlanOption()" is reachable with no plan
Build Status
Buildable 24291
Build 33461: Run Core Tests

Changes (2)

PathSize
src/
applications/
differential/
storage/
harbormaster/
storage/
build/

rP304467feb2ae

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility