Page MenuHomePhabricator
Differential D21196

When a Paste has a useful alternative rendering in Files, provide a hint
ClosedPublic
Actions

Authored by epriestley on May 1 2020, 1:53 PM.
Tags
None
Referenced Files
F15453731: D21196.id50480.diff
Sat, Mar 29, 1:57 PM
F15452318: D21196.id.diff
Sat, Mar 29, 3:46 AM
F15451267: D21196.diff
Fri, Mar 28, 9:07 PM
F15432935: D21196.diff
Mon, Mar 24, 8:22 PM
F15407515: D21196.id.diff
Tue, Mar 18, 5:59 PM
F15379739: D21196.id50489.diff
Mar 13 2025, 11:07 PM
F15333041: D21196.diff
Mar 7 2025, 11:20 PM
F15289668: D21196.id50480.diff
Mar 4 2025, 10:10 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13528: When a Paste can be rendered by DocumentEngine, provide a hint that the rendering is available
Commits
rP3c1f393c812f: When a Paste has a useful alternative rendering in Files, provide a hint
Summary

Ref T13528. When a file in Paste (like a Jupyter notebook) has a good/useful document engine, provide a link to Files.

Test Plan

Screen Shot 2020-05-01 at 6.49.46 AM.png (226×1 px, 31 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.May 1 2020, 1:53 PM
Harbormaster completed remote builds in B24295: Diff 50480.May 1 2020, 1:54 PM
epriestley requested review of this revision.May 1 2020, 1:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 1 2020, 4:09 PM
Closed by commit rP3c1f393c812f: When a Paste has a useful alternative rendering in Files, provide a hint (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP3c1f393c812f: When a Paste has a useful alternative rendering in Files, provide a hint.

Revision Contents
Changeset List

PathSize
src/
applications/
console/
core/
2 lines
files/
document/
4 lines
4 lines
render/
6 lines
paste/
controller/
63 lines

Diff 50489

View Options

src/applications/console/core/DarkConsoleCore.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

Loading...
View Options

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...
Phabricator · Built by Phacility