Page MenuHomePhabricator

Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions
ClosedPublic

Authored by epriestley on Thu, Apr 30, 2:47 PM.

Details

Summary

Ref T13526. Currently, if a build plan is restricted, viewers may fatal when trying to view related builds.

The old behavior allowed them to see the build even if they can not see the build plan. This is sort of incoherent, but try to stabilize things before fixing this.

Test Plan

This is a muddy change.

  • Created a build with a build plan that Alice can't see.
  • As Alice, viewed the build page (restricted before, restricted after); the buildable page (fatal before, works after).
  • Also viewed a revision page (works before and after, but user-reported fatal).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Apr 30, 2:47 PM
Owners added a subscriber: Restricted Owners Package.Thu, Apr 30, 2:47 PM
epriestley requested review of this revision.Thu, Apr 30, 2:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Thu, Apr 30, 2:57 PM
This revision was automatically updated to reflect the committed changes.