Differential D21181

Fix an issue with "Auditors:" where an edge edit was used as a PHID list
ClosedPublic
Actions

Authored by epriestley on Apr 28 2020, 12:46 PM.

Tags

None

Referenced Files

	F17909308: D21181.id50441.diff
	Tue, Jul 29, 2:18 PM

	F17897543: D21181.id.diff
	Tue, Jul 29, 7:38 AM

	F17886717: D21181.diff
	Tue, Jul 29, 1:10 AM

	F17884048: D21181.id50440.diff
	Mon, Jul 28, 11:44 PM

	F17712896: D21181.id50440.diff
	Thu, Jul 17, 11:39 AM

	F17705812: D21181.diff
	Wed, Jul 16, 9:35 AM

	Unknown Object (File)
	Apr 30 2025, 9:47 AM

	Unknown Object (File)
	Apr 7 2025, 11:18 AM

Subscribers

None

Details

Reviewers: None
Commits: rP055d8b272826: (stable) Fix an issue with "Auditors:" where an edge edit was used as a PHID…
rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list

Summary

See https://discourse.phabricator-community.org/t/runtimeexception-during-import-of-commit/3801. When importing commits with "Auditors:", a raw transaction new value (with an edge edit map using a "+" key) may be passed as an unmentionable PHID list.

Instead, pass an actual PHID list.

Test Plan

Pushed a commit with "Auditors: duck".
Ran daemons.
- Before patch: umentionable PHID exception.
- After patch: clean commit import.
Verified "duck" was added as an auditor.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 28 2020, 12:46 PM

Harbormaster completed remote builds in B24259: Diff 50440.Apr 28 2020, 12:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 12:47 PM

epriestley requested review of this revision.

Closed by commit rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa7b2327c34ac: Fix an issue with "Auditors:" where an edge edit was used as a PHID list.

epriestley added a commit: rP055d8b272826: (stable) Fix an issue with "Auditors:" where an edge edit was used as a PHID….Apr 28 2020, 12:50 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

editor/

PhabricatorAuditEditor.php

25 lines

Diff 50441

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...