Page MenuHomePhabricator

Fix an issue with "Auditors:" where an edge edit was used as a PHID list
ClosedPublic

Authored by epriestley on Apr 28 2020, 12:46 PM.
Tags
None
Referenced Files
F17909308: D21181.id50441.diff
Tue, Jul 29, 2:18 PM
F17897543: D21181.id.diff
Tue, Jul 29, 7:38 AM
F17886717: D21181.diff
Tue, Jul 29, 1:10 AM
F17884048: D21181.id50440.diff
Mon, Jul 28, 11:44 PM
F17712896: D21181.id50440.diff
Thu, Jul 17, 11:39 AM
F17705812: D21181.diff
Wed, Jul 16, 9:35 AM
Unknown Object (File)
Apr 30 2025, 9:47 AM
Unknown Object (File)
Apr 7 2025, 11:18 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/runtimeexception-during-import-of-commit/3801. When importing commits with "Auditors:", a raw transaction new value (with an edge edit map using a "+" key) may be passed as an unmentionable PHID list.

Instead, pass an actual PHID list.

Test Plan
  • Pushed a commit with "Auditors: duck".
  • Ran daemons.
    • Before patch: umentionable PHID exception.
    • After patch: clean commit import.
  • Verified "duck" was added as an auditor.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable