Differential D21175

Fix a Diffusion issue where commits that do not show changesets would incorrectly try to render changesets
ClosedPublic
Actions

Authored by epriestley on Apr 27 2020, 5:34 PM.

Tags

None

Referenced Files

	F15571013: D21175.id50423.diff
	Mon, May 5, 3:23 AM

	F15560461: D21175.id.diff
	Tue, Apr 29, 2:47 PM

	F15560288: D21175.id50423.diff
	Tue, Apr 29, 1:52 PM

	F15556845: D21175.diff
	Mon, Apr 28, 6:41 PM

	F15530427: D21175.id50424.diff
	Wed, Apr 23, 3:45 AM

	F15473475: D21175.diff
	Apr 5 2025, 10:16 PM

	F15464577: D21175.id50424.diff
	Apr 2 2025, 10:56 AM

	F15460806: D21175.id50424.diff
	Apr 1 2025, 2:26 AM

Subscribers

None

Details

Reviewers: None
Commits: rPedfdf2c13066: (stable) Fix a Diffusion issue where commits that do not show changesets would…
rP604811bfc554: Fix a Diffusion issue where commits that do not show changesets would…

Summary

See https://discourse.phabricator-community.org/t/loading-certain-svn-commits-cause-unhandled-exception/3795/.

Commits with no changesets (for example, deleted commits) don't generate a "$changesets".

Test Plan

Viewed a commit with no changesets. Before change: exception. After change: saw unusual commit state.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 27 2020, 5:34 PM

Harbormaster completed remote builds in B24242: Diff 50423.Apr 27 2020, 5:36 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2020, 5:36 PM

epriestley requested review of this revision.

Closed by commit rP604811bfc554: Fix a Diffusion issue where commits that do not show changesets would… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP604811bfc554: Fix a Diffusion issue where commits that do not show changesets would….

epriestley added a commit: rPedfdf2c13066: (stable) Fix a Diffusion issue where commits that do not show changesets would….

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionCommitController.php

5 lines

Diff 50424

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...