Page MenuHomePhabricator

FilesProject
ActivePublic

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Files is the storage application for Phabricator. Users can upload files directly and the application is also used by other applications for file storage.

Recent Activity

Apr 27 2020

epriestley added a revision to T13522: Compute an internal content hash of large files using hash-of-hashes: D21174: For changesets that affect binaries, use the new binary file content hash as an effect hash.
Apr 27 2020, 3:29 PM · Differential, Files
epriestley triaged T13522: Compute an internal content hash of large files using hash-of-hashes as Wishlist priority.
Apr 27 2020, 2:48 PM · Differential, Files

Jan 13 2020

epriestley merged T13470: Unable to upload (crashes) large files (eg. 20mb) via file application upload section: https://secure.phabricator.com/file/upload/ into T13256: Update storage engines in Files to a modern multi-service configuration.
Jan 13 2020, 7:26 PM · Files

Sep 8 2019

epriestley triaged T13407: If an S3 request returns with HTTP 404, error handling behavior is poor as Wishlist priority.
Sep 8 2019, 8:22 PM · Files

Jul 31 2019

epriestley updated the task description for T13352: Very large objects may not be distributable via CDN (CloudFront has 20GB object limit).
Jul 31 2019, 12:14 AM · Files, Infrastructure

Jul 30 2019

epriestley triaged T13352: Very large objects may not be distributable via CDN (CloudFront has 20GB object limit) as Low priority.
Jul 30 2019, 11:42 PM · Files, Infrastructure

Jun 24 2019

epriestley closed T13326: "bin/files integrity" misparses file selection arguments as Resolved by committing rPda0dfc057d64: Make "bin/files" parsing of working set arguments more consistent.
Jun 24 2019, 11:02 PM · Files
epriestley added a revision to T13326: "bin/files integrity" misparses file selection arguments: D20614: Make "bin/files" parsing of working set arguments more consistent.
Jun 24 2019, 10:13 PM · Files

Jun 22 2019

epriestley added a comment to T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.

See one followup in T13326. The "import from disk" part seems to have worked properly in production.

Jun 22 2019, 4:51 PM · Phacility, Files
epriestley created T13326: "bin/files integrity" misparses file selection arguments.
Jun 22 2019, 4:50 PM · Files

Jun 17 2019

epriestley closed T13313: "Download Raw Diff" may fail in a misleading way after failing to engage the chunk engine if the raw diff is larger than 4MB as Resolved by committing rP14b076578f8e: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes.
Jun 17 2019, 8:31 PM · Differential, Files
epriestley added a revision to T13313: "Download Raw Diff" may fail in a misleading way after failing to engage the chunk engine if the raw diff is larger than 4MB: D20579: In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes.
Jun 17 2019, 4:51 PM · Differential, Files
epriestley created T13313: "Download Raw Diff" may fail in a misleading way after failing to engage the chunk engine if the raw diff is larger than 4MB.
Jun 17 2019, 2:40 PM · Differential, Files

Jun 5 2019

epriestley added a revision to T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster: D20571: Add "bin/file migrate" options to support import of a local-disk backup for Phacility instances.
Jun 5 2019, 9:36 PM · Phacility, Files
epriestley claimed T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.
Jun 5 2019, 5:59 PM · Phacility, Files
epriestley created T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.
Jun 5 2019, 5:59 PM · Phacility, Files

May 24 2019

thuffir added a comment to T4752: Daemons may not have permission to remove files from local disk storage engine.

setfacl -Rdm u:phab-phd:rw /var/local/phabricator/filestore
setfacl -Rm u:phab-phd:rw /var/local/phabricator/filestore

May 24 2019, 9:21 AM · Files

Feb 25 2019

epriestley added a parent task for T4752: Daemons may not have permission to remove files from local disk storage engine: T13256: Update storage engines in Files to a modern multi-service configuration.
Feb 25 2019, 12:55 PM · Files
epriestley added a subtask for T13256: Update storage engines in Files to a modern multi-service configuration: T4752: Daemons may not have permission to remove files from local disk storage engine.
Feb 25 2019, 12:55 PM · Files

Feb 23 2019

epriestley closed T9169: Downloading Attachment Extremely Slow as Wontfix.

We no longer offer support for this kind of problem (that technically has reproduction steps, but is sufficiently involved to reproduce that no one has time to follow them, e.g. build a new server from scratch with assorted specific software versions).

Feb 23 2019, 3:37 PM · Bug Report (Needs Information), Files
epriestley triaged T13256: Update storage engines in Files to a modern multi-service configuration as Low priority.
Feb 23 2019, 3:26 PM · Files

Jul 23 2018

kaendfinger2 closed D19533: Fix file encoding migration.
Jul 23 2018, 10:41 PM · Restricted Project, Files
epriestley accepted D19533: Fix file encoding migration.

Thanks! I was able to follow your steps to reproduce this and verify the fix.

Jul 23 2018, 10:13 PM · Restricted Project, Files

Jul 22 2018

kaendfinger2 added a comment to D19533: Fix file encoding migration.

Note that the lints and unit tests do pass on my end. I used the "Create Diff" action to do this instead of arc diff (which was silly of me)

Jul 22 2018, 5:18 PM · Restricted Project, Files
kaendfinger2 requested review of D19533: Fix file encoding migration.
Jul 22 2018, 4:50 AM · Restricted Project, Files

Jun 28 2018

20after4 added a comment to T13103: Document favicon customization and validate the "ui.favicons" configuration option.

Can't wait for "connect 2" to come out on playstation six.

Jun 28 2018, 11:53 AM · Files, Aphront, Infrastructure

Jun 1 2018

epriestley closed T13148: css: ginormous images go over preview panel in Files as Resolved by committing rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering….
Jun 1 2018, 9:53 PM · Files
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19457: Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI.
Jun 1 2018, 8:14 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13148: css: ginormous images go over preview panel in Files: D19457: Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI.
Jun 1 2018, 8:14 PM · Files
epriestley claimed T13148: css: ginormous images go over preview panel in Files.
Jun 1 2018, 8:09 PM · Files

May 4 2018

epriestley closed T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4" as Resolved by committing rP5784e3d3c0cf: Omit "type" attribute from "<source />" tags in "<video>" to trick Chrome into….
May 4 2018, 4:28 PM · Files
epriestley added a revision to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4": D19424: Omit "type" attribute from "<source />" tags in "<video>" to trick Chrome into playing them.
May 4 2018, 4:25 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

I like that reasoning a lot better than mine, and simply omitting type appears to produce the correct behavior in every browser, at least for this file. I'll try that instead, and we can revisit this after we write a video transcoder in PHP and can offer files in multiple formats.

May 4 2018, 3:14 PM · Files
asherkin added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

My knowledge is centred around broadcast video / IPTV (UDP multicast) rather than HTML5 video, but that seems fairly reasonable. I don't think anything should try and download the file twice unless it is a complete clownshoes implementation that probably has multiple other serious bugs wasting bandwidth. I think the worst case with no type that might be hit here is that the browser could decide to download the entire file on load to figure out the format and duration, rather than starting with byte-range requests, but this is easy to test and unlikely (I'd expect any sane one to always request chunks).

May 4 2018, 3:11 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

I can imagine that two <source /> tags might, in some bizarre world, cause browsers to download the file twice when you click "Play", if they're super confused about how to process videos, don't notice that the URLs are the same, and don't hit any caching. But that's a pretty minor bad effect, and I didn't immediately see any kind of bad behavior locally.

May 4 2018, 2:50 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

Thanks! I wouldn't mind parsing that but I'm hesitant to ask installs to install it -- but it's helpful in understanding that I'm not completely crazy here and that there's at least some basis for "video/mp4" being a quasi-legitimate way to label the video file.

May 4 2018, 2:47 PM · Files
asherkin added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

mediainfo is the tool for this, but is really overkill for programmatic use.

May 4 2018, 1:29 PM · Files

May 3 2018

epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

One easy approach we could take is just:

May 3 2018, 3:45 PM · Files
epriestley triaged T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4" as Normal priority.
May 3 2018, 3:31 PM · Files

May 1 2018

epriestley closed T13132: `arc download` broken for non-CDN Phabricator as Resolved by committing rP332f4ab66d18: Restore support for using "arc download" to fetch files with no "security..
May 1 2018, 5:08 PM · Conduit, Files
epriestley added projects to T13132: `arc download` broken for non-CDN Phabricator : Files, Conduit.
May 1 2018, 4:06 PM · Conduit, Files

Apr 28 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19414: Add a view option to disable blame in Diffusion and fix some view transition bugs.
Apr 28 2018, 1:55 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

From PHI604, for completeness, on the newer behavior of "Hide Blame":

Apr 28 2018, 1:52 PM · Plans, Files, Differential, Diffusion

Apr 27 2018

epriestley added a comment to T13103: Document favicon customization and validate the "ui.favicons" configuration option.

validation for the configuration option

Apr 27 2018, 7:00 PM · Files, Aphront, Infrastructure

Apr 25 2018

epriestley added a revision to T13103: Document favicon customization and validate the "ui.favicons" configuration option: D19406: Recover more gracefully when favicon configuration points at a corrupt/damaged file.
Apr 25 2018, 1:45 PM · Files, Aphront, Infrastructure

Apr 17 2018

epriestley added a subtask for T13105: Plans: Rich presentation and diff rendering pipelines for various file types: T13126: Plans: Diffusion cleanup for document engine.
Apr 17 2018, 10:02 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19378: Restore coverage reporting to Diffusion browse UI.
Apr 17 2018, 1:46 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: D19377: Remove obsoleted "diffusion-browse-file" behavior for coverage.
Apr 17 2018, 12:54 PM · Plans, Files, Differential, Diffusion

Apr 16 2018

epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

See T13125 for a more detailed breakout of coverage plans.

Apr 16 2018, 12:50 PM · Plans, Files, Differential, Diffusion

Apr 15 2018

epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

This particular page here is fataling:

Apr 15 2018, 5:06 PM · Plans, Files, Differential, Diffusion