Page MenuHomePhabricator

Provide default image alt text in more contexts and support custom alt text
ClosedPublic

Authored by epriestley on Mar 5 2021, 12:48 AM.
Tags
None
Referenced Files
F18180543: D21596.id51416.diff
Sat, Aug 16, 6:19 AM
F18167771: D21596.id51415.diff
Fri, Aug 15, 12:45 PM
F18099779: D21596.id.diff
Sat, Aug 9, 8:44 AM
F18097502: D21596.diff
Fri, Aug 8, 1:50 PM
F18051295: D21596.id51415.diff
Sun, Aug 3, 10:40 PM
F17950757: D21596.id51416.diff
Fri, Aug 1, 12:40 AM
Unknown Object (File)
Jun 3 2025, 10:37 PM
Unknown Object (File)
Jun 2 2025, 7:08 AM
Subscribers
None

Details

Summary

Ref T13629.

  • Allow files to have custom alt text.
  • If a file doesn't have alt text, try to generate a plausible default alt text with the information we have.
Test Plan
  • Viewed image files in DocumentEngine diffs, files, {Fxxx} embeds, and lightboxes.
  • Saw default alt text in all cases, or custom alt text if provided.
  • Set, modified, and removed file alt text. Viewed timeline and feed.
  • Pulled alt text with "conduit.search".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2021, 12:49 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.