Page MenuHomePhabricator

Provide default image alt text in more contexts and support custom alt text

Authored by epriestley on Mar 5 2021, 12:48 AM.
Referenced Files
Unknown Object (File)
Thu, Nov 30, 6:08 AM
Unknown Object (File)
Sun, Nov 26, 12:20 AM
Unknown Object (File)
Sun, Nov 19, 5:58 AM
Unknown Object (File)
Sep 2 2023, 7:38 PM
Unknown Object (File)
Aug 24 2023, 9:48 PM
Unknown Object (File)
Aug 1 2023, 1:54 AM
Unknown Object (File)
Jul 25 2023, 5:31 PM
Unknown Object (File)
Jul 16 2023, 7:33 PM



Ref T13629.

  • Allow files to have custom alt text.
  • If a file doesn't have alt text, try to generate a plausible default alt text with the information we have.
Test Plan
  • Viewed image files in DocumentEngine diffs, files, {Fxxx} embeds, and lightboxes.
  • Saw default alt text in all cases, or custom alt text if provided.
  • Set, modified, and removed file alt text. Viewed timeline and feed.
  • Pulled alt text with "".

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2021, 12:49 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.