See Discourse
When migrating to aes-256-cbc, integrity hashes were not updated, so data was not properly
Details
Details
- Reviewers
epriestley amckinley - Group Reviewers
Blessed Reviewers - Commits
- rP6bdd74584ef3: Fix file encoding migration
- Required Signatures
L28 Phacility Individual Contributor License Agreement
I ran this test script to ensure it worked.
I created some files with lipsum, ensured that after encoding them with aes-256-cbc, they were not able to be cat'd.
After applying this patch and rerunning the script, it worked successfully.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Note that the lints and unit tests do pass on my end. I used the "Create Diff" action to do this instead of arc diff (which was silly of me)
Comment Actions
Thanks! I was able to follow your steps to reproduce this and verify the fix.
The integrity hash code was added after the original encryption code and this particular pathway must have escaped testing.