Page MenuHomePhabricator

Fix file encoding migration
ClosedPublic

Authored by kaendfinger2 on Jul 22 2018, 4:50 AM.

Details

Summary

See Discourse

When migrating to aes-256-cbc, integrity hashes were not updated, so data was not properly

Test Plan

I ran this test script to ensure it worked.
I created some files with lipsum, ensured that after encoding them with aes-256-cbc, they were not able to be cat'd.
After applying this patch and rerunning the script, it worked successfully.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kaendfinger2 created this revision.Jul 22 2018, 4:50 AM
kaendfinger2 requested review of this revision.Jul 22 2018, 4:50 AM

Note that the lints and unit tests do pass on my end. I used the "Create Diff" action to do this instead of arc diff (which was silly of me)

epriestley accepted this revision.Jul 23 2018, 10:13 PM

Thanks! I was able to follow your steps to reproduce this and verify the fix.

The integrity hash code was added after the original encryption code and this particular pathway must have escaped testing.

This revision is now accepted and ready to land.Jul 23 2018, 10:13 PM
This revision was automatically updated to reflect the committed changes.