Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
F15312157: D20614.diff
Thu, Mar 6, 2:41 PM
Unknown Object (File)
Mar 2 2025, 1:43 PM
Unknown Object (File)
Feb 25 2025, 11:20 AM
Unknown Object (File)
Feb 9 2025, 12:40 PM
Unknown Object (File)
Feb 9 2025, 7:55 AM
Unknown Object (File)
Feb 9 2025, 7:55 AM
Unknown Object (File)
Feb 9 2025, 7:55 AM
Unknown Object (File)
Feb 4 2025, 3:59 PM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable