Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 4:19 PM
Unknown Object (File)
Tue, Dec 17, 9:08 PM
Unknown Object (File)
Mon, Dec 16, 3:52 PM
Unknown Object (File)
Wed, Dec 11, 10:12 AM
Unknown Object (File)
Sat, Dec 7, 4:52 AM
Unknown Object (File)
Mon, Dec 2, 10:45 AM
Unknown Object (File)
Mon, Dec 2, 6:46 AM
Unknown Object (File)
Fri, Nov 29, 3:24 AM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable