Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 11:25 AM
Unknown Object (File)
Sat, Nov 16, 11:08 PM
Unknown Object (File)
Mon, Oct 28, 5:04 AM
Unknown Object (File)
Oct 18 2024, 2:25 PM
Unknown Object (File)
Oct 18 2024, 8:12 AM
Unknown Object (File)
Oct 10 2024, 11:02 PM
Unknown Object (File)
Oct 9 2024, 12:26 PM
Unknown Object (File)
Aug 18 2024, 11:18 AM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable