Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 9, 5:02 AM
Unknown Object (File)
Thu, May 8, 4:01 AM
Unknown Object (File)
Wed, May 7, 12:35 PM
Unknown Object (File)
Mon, Apr 28, 10:01 AM
Unknown Object (File)
Sat, Apr 19, 10:14 AM
Unknown Object (File)
Tue, Apr 15, 11:45 PM
Unknown Object (File)
Apr 11 2025, 1:38 AM
Unknown Object (File)
Apr 10 2025, 4:20 PM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable