Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 11:04 AM
Unknown Object (File)
Sat, Jan 18, 11:09 AM
Unknown Object (File)
Thu, Jan 16, 7:13 AM
Unknown Object (File)
Tue, Jan 14, 10:13 PM
Unknown Object (File)
Dec 20 2024, 4:19 PM
Unknown Object (File)
Dec 17 2024, 9:08 PM
Unknown Object (File)
Dec 16 2024, 3:52 PM
Unknown Object (File)
Dec 11 2024, 10:12 AM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable