Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 10, 2:05 AM
Unknown Object (File)
Thu, Nov 30, 6:08 AM
Unknown Object (File)
Sat, Nov 25, 10:09 PM
Unknown Object (File)
Sun, Nov 19, 6:17 AM
Unknown Object (File)
Oct 31 2023, 2:06 AM
Unknown Object (File)
Oct 20 2023, 9:22 AM
Unknown Object (File)
Oct 20 2023, 9:22 AM
Unknown Object (File)
Oct 20 2023, 9:22 AM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable