Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
F19509747: D20614.diff
Sun, Jan 11, 12:38 AM
F19303858: D20614.id49176.diff
Wed, Dec 24, 6:03 AM
F19052170: D20614.id.diff
Nov 28 2025, 3:27 AM
F19047160: D20614.diff
Nov 27 2025, 12:37 PM
F18949152: D20614.diff
Nov 12 2025, 12:30 AM
F18851263: D20614.id49179.diff
Oct 30 2025, 11:22 PM
F18833434: D20614.id.diff
Oct 26 2025, 3:24 AM
F18832620: D20614.diff
Oct 25 2025, 10:20 PM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable