Page MenuHomePhabricator

Make "bin/files" parsing of working set arguments more consistent
ClosedPublic

Authored by epriestley on Jun 24 2019, 10:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 12 2026, 2:08 AM
Unknown Object (File)
Apr 16 2026, 11:44 PM
Unknown Object (File)
Apr 16 2026, 11:05 AM
Unknown Object (File)
Apr 10 2026, 7:16 PM
Unknown Object (File)
Mar 28 2026, 12:06 PM
Unknown Object (File)
Mar 28 2026, 5:07 AM
Unknown Object (File)
Mar 27 2026, 11:35 PM
Unknown Object (File)
Mar 18 2026, 6:35 AM
Subscribers
None

Details

Summary

Fixes T13326. In D20571, I slightly generalized construction of an iterator over a set of files, but missed some code in other "bin/files ..." commands which was also affected.

Today, basically all of these workflows define their own "--all" and "names" flags. Pull these definitions up and implement them more consistently.

Test Plan

Ran multiple different bin/files commands with different combinations of arguments, saw consistent handling of iterator construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable