Paths

Table of Contentst

Diffusion Phabricator a894c9993512

Add "max-width: 100%;" to stop large images from overflowing the new rendering…
a894c9993512
Actions

Description

Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI

Summary:
Fixes T13148. Ref T13105. The new document rendering engine for images let them overflow the UI bounds.

Add max-width: 100%; to keep them contained.

Test Plan:

Viewed a very wide image in Safari, Firefox and Chrome. Saw sensible rendering.
Also viewed a normal image, saw normal behavior.

Reviewers: amckinley, avivey

Reviewed By: avivey

Maniphest Tasks: T13148, T13105

Differential Revision: https://secure.phabricator.com/D19457

Details

Provenance

epriestley	Authored on Jun 1 2018, 8:12 PM
epriestley	Pushed on Jun 1 2018, 9:53 PM

Reviewer

avivey

Differential Revision

D19457: Add "max-width: 100%;" to stop large images from overflowing the new rendering engine UI

Parents

rP31ee49b14d93: Fix Javascript busy loop when trying to delete tokens from an empty tokenizer

Branches

Unknown

Tags

Unknown

Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types
T13148: css: ginormous images go over preview panel in Files

Build Status

Buildable 20357
Build 27646: Run Core Tests

Event Timeline

epriestley committed rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering… (authored by epriestley).Jun 1 2018, 9:53 PM

epriestley added a task: T13148: css: ginormous images go over preview panel in Files.

epriestley added a task: T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Harbormaster completed building B20357: rPa894c9993512: Add "max-width: 100%;" to stop large images from overflowing the new rendering….Jun 1 2018, 9:54 PM

Changes (2)

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

phui/

phui-property-list-view.css

rPa894c9993512

View Options

resources/celerity/map.php