Page MenuHomePhabricator
Create Task
Maniphest T7001

ParameterQueryException in Chatlogs
Closed, WontfixPublic
Actions

Description

I was reading about composer in T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function
and clicked the link in the last comment:
https://secure.phabricator.com/chatlog/channel/%23phabricator/?at=17878

Resulting in:

Unhandled Exception ("AphrontParameterQueryException")
Expected a numeric scalar or null for %Ld conversion. Query: id IN (%Ld)

It seems that the links where changed from channel names to using just id's.
Although this probably won't cause any problems i think a hard query exception when changing some url params is never good...

Related Objects

Event Timeline

fabe created this task.Jan 21 2015, 9:02 AM
fabe raised the priority of this task from to Needs Triage.
fabe updated the task description. (Show Details)
fabe added a project: Chatlog.
fabe added a subscriber: fabe.
chad added a subscriber: chad.Jan 21 2015, 3:06 PM

We're likely removing Chatlog T6875, but I guess we'll still want these links to work?

fabe added a comment.Jan 21 2015, 4:47 PM

I guess if needed the links would then be just handled by the conpherence controller.
If not just showing a "deprecated" message would be nice.

Both is better than a sql exception ;)

chad added a comment.Jan 21 2015, 7:53 PM

I mean, Chatlog (as an IRC log product) is likely to just be outright removed, so old links would just be 404. Conpherence would be the home for things like #phabricator moving forward, but it'd be self contained, not wired to IRC.

fabe closed this task as Wontfix.Jan 21 2015, 8:31 PM
fabe claimed this task.

Ah ok. I see.
Guess it's not worth fixing this then.

chad added a subscriber: epriestley.Jan 21 2015, 8:32 PM

Haha, I was going to leave it up to @epriestley, I don't know if those plans are firm or soon.

epriestley added a comment.Jan 22 2015, 7:52 PM

This is an easy fix (something like adding an (int) cast) but I think it's probably not worth fixing unless Chatlog ends up having a longer / healthier life than we anticipate.

Phabricator · Built by Phacility