Page MenuHomePhabricator
Feed All Stories

Jul 18 2019

epriestley claimed T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Rough intentions here:

Jul 18 2019, 2:49 PM · Auth
am9obgo awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Jul 18 2019, 2:36 PM · Conpherence (v4)
d.maznekov edited the content of Organizations Using Phabricator.
Jul 18 2019, 6:35 AM

Jul 17 2019

aeiser added a comment to T13342: Support export of "date" and "remarkup" custom fields.

Trying to preserve markup format in the output is likely a road to mental ruin (Hyperlinking, referencing, bolding, formatting in who knows what export formats). PhabricatorStringExportField should be sufficient.

Jul 17 2019, 11:26 PM · Custom Fields, Data Exporters
epriestley added a revision to T13342: Support export of "date" and "remarkup" custom fields: Unknown Object (Differential Revision).
Jul 17 2019, 10:57 PM · Custom Fields, Data Exporters
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Potentially don't allow the "Send a login link to your email address" action at all if the corresponding Phab account is already only linked to external accounts for authentication and the installation does not use passwords? But I might lack technical understanding here.

Jul 17 2019, 10:47 PM · Auth
aklapper updated the task description for T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.
Jul 17 2019, 10:36 PM · Auth
aklapper created T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.
Jul 17 2019, 10:34 PM · Auth
epriestley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

We also need --enable-zip to get the zip extension, to get the ZipArchive class, so "Export to Excel" works. See upcoming change on T13342.

Jul 17 2019, 10:27 PM · Infrastructure
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 8:09 PM · Workboards (v3), User Delight, Wikimedia
epriestley moved T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full from vNext to Far Future on the Aphlict board.
Jul 17 2019, 6:30 PM · Aphlict, Phacility, Ops
epriestley moved T7013: Support bulk transmission of notification frames in internal Aphlict protocol from Backlog to Far Future on the Aphlict board.
Jul 17 2019, 6:29 PM · Aphlict, Conpherence
epriestley closed T10823: Aphlict admin server doesn't connect when SSL cert and key are supplied as Wontfix.

This is super old and doesn't have any apparent reproduction instructions.

Jul 17 2019, 6:29 PM · Aphlict, Bug Report
epriestley moved T12908: Allow verbosity of Aphlict log to be reduced from Backlog to Far Future on the Aphlict board.
Jul 17 2019, 6:28 PM · Aphlict, Feature Request
epriestley added a comment to T4900: Workboards updating in real time.

a logical clock to complement the wall-time clocks

Jul 17 2019, 6:25 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

From D20653:

Jul 17 2019, 6:15 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 6:04 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 5:53 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 17 2019, 5:39 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13342: Support export of "date" and "remarkup" custom fields as Normal priority.
Jul 17 2019, 4:40 PM · Custom Fields, Data Exporters
arielyang edited the content of Organizations Using Phabricator.
Jul 17 2019, 4:36 PM

Jul 16 2019

Krinkle awarded T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang a Orange Medal token.
Jul 16 2019, 6:44 PM · Restricted Project, Arcanist

Jul 15 2019

epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Oh, sorry, I misread which half you were asking about.

Jul 15 2019, 8:53 PM · Restricted Project, Auth, Conduit
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Am I going crazy, or do those methods only handle the "blob fetching" part of this equation? I was looking for examples of the "create a File, do a chunked upload, attach said File to an existing object" flow.

Jul 15 2019, 8:28 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Yeah, diffusion.rawdiffquery and diffusion.filecontentquery both do this.

Jul 15 2019, 8:18 PM · Restricted Project, Auth, Conduit
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

For uploading binary blobs, we'd do the reverse: have the client stream the blob into Files, then call an API method with a reference to the object.

Jul 15 2019, 8:16 PM · Restricted Project, Auth, Conduit
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI, a subtask of T6755: Allow more granular configuration of `security.allow-outbound-http`, as Resolved.
Jul 15 2019, 6:53 PM · Security
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI as Resolved by committing Restricted Diffusion Commit.
Jul 15 2019, 6:53 PM · Auth, Security
epriestley triaged T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22 as Low priority.
Jul 15 2019, 6:42 PM · Phortune, Phacility

Jul 14 2019

epriestley added a comment to T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE.

An adjacent issue is that PhabricatorMarkupCache is not currently marked as having cache persistence (PhabricatorConfigTableSchema::PERSISTENCE_CACHE), so the data dumps even when we do not intend to dump data for readthrough caches.

Jul 14 2019, 10:22 PM · Infrastructure
epriestley triaged T13340: "PeopleDatasource" improperly uses "closed" state to sort bot/mailing list results to the bottom of the list as Low priority.
Jul 14 2019, 3:07 PM · Typeahead

Jul 12 2019

20after4 awarded T13322: Allow parent projects to have direct members a Love token.
Jul 12 2019, 6:23 PM · Projects
epriestley closed T10127: Migrating repository between storage hosts in a cluster as Resolved.

I assume this is being done already in the Phacility cluster on some level when repositories get really large, but I'm not particularly sure how to perform this migration.

Jul 12 2019, 5:11 PM · Clusters, Feature Request
epriestley updated the task description for T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases.
Jul 12 2019, 5:05 PM · Diffusion, Conduit
epriestley added a project to T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases: Diffusion.
Jul 12 2019, 5:04 PM · Diffusion, Conduit
epriestley triaged T13339: Update "diffusion.searchquery" to handle multiple path arguments and various weird cases as Normal priority.
Jul 12 2019, 5:04 PM · Diffusion, Conduit
epriestley triaged T13338: Provide "differential.diff.edit" with an option to create a diff from an uploaded file source as Normal priority.
Jul 12 2019, 4:39 PM · Differential, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T550: Build an SSH conduit client, as Resolved.
Jul 12 2019, 4:28 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings as Resolved.

Deprecate conduit sessions and conduit.connect.
Support direct token-based auth (?token=abdef123) and make this the standard.

Jul 12 2019, 4:28 PM · Restricted Project, Auth, Conduit
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T9124: Support uploading build log data via the Harbormaster API, as Resolved.
Jul 12 2019, 4:28 PM · Restricted Project, Harbormaster
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T4377: Long-running bots which don't make Conduit calls for 24 hours fail all future calls, as Resolved.
Jul 12 2019, 4:28 PM · Conpherence, Phabot
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T7288: configuring certificates for bots is hard/confusing, as Resolved.
Jul 12 2019, 4:28 PM · Documentation
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T6633: 'differential.creatediff' exception when repository paths contain SHIFT-JIS characters, as Resolved.
Jul 12 2019, 4:28 PM · Arcanist
epriestley closed T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings, a subtask of T10803: PhabricatorApplicationTransactionPublishWorker task failing due to malformed UTF-8, as Resolved.
Jul 12 2019, 4:28 PM · Bug Report (Needs Information)
epriestley triaged T13337: Resolve structural problems with Conduit API methods related to large input/output sizes and binary data as Low priority.
Jul 12 2019, 4:23 PM · Conduit
epriestley triaged T13336: "bin/storage dump" option "--for-replica" might not interact properly with "--no-indexes" and PERSISTENCE_CACHE as Low priority.
Jul 12 2019, 4:02 PM · Infrastructure

Jul 11 2019

epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

D20647 should fix this. It isn't very satisfying as a general resolution.

Jul 11 2019, 9:50 PM · Javelin
epriestley renamed T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way from Exception "Attempting to add more metadata after metadata has been locked" when trying to view a specific Pholio mockup to Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.
Jul 11 2019, 9:41 PM · Javelin
epriestley added a revision to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way: Unknown Object (Differential Revision).
Jul 11 2019, 9:40 PM · Javelin
epriestley added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

The renderHTMLFooter() method does a bunch of Javascript stuff and isn't actually related to the page footer, but PHUIRemarkupView and renderObjectRefForAnyMedia() were enough of a hint that think I have a reproduction case locally now -- let me figure out what I actually did and this will likely be fairly easy to fix.

Jul 11 2019, 7:53 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

Could this be related to the custom footer markup? The code in question hasn't changed in a long time but I suspect maybe it's related to changes in the remarkup rendering code that's adding metadata where it didn't previously?

Jul 11 2019, 7:00 PM · Javelin
20after4 added a comment to T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

I toggled developer mode on for a moment and managed to get a stack trace:

Jul 11 2019, 6:56 PM · Javelin

Jul 10 2019

epriestley triaged T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup as Wishlist priority.
Jul 10 2019, 10:11 PM · Remarkup
amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Unknown Object (Differential Revision).
Jul 10 2019, 3:05 PM · Auth, Security
epriestley triaged T13334: The "Read-Only" URI repository setting may vary misleadingly across display variations of the same URI as Low priority.
Jul 10 2019, 3:05 PM · Diffusion
epriestley triaged T13333: The "Cancel" button in the "New Repository URI" workflow returns users to "/diffusion/", not the URI management page as Low priority.
Jul 10 2019, 2:50 PM · Diffusion

Jul 9 2019

amckinley created P2119 (An Untitled Masterwork).
Jul 9 2019, 6:51 PM
amckinley created P2118 (An Untitled Masterwork).
Jul 9 2019, 6:45 PM
andytruong created P2117 Test.
Jul 9 2019, 10:40 AM

Jul 8 2019

epriestley updated the task description for T11036: Put subproject columns on workboards.
Jul 8 2019, 11:20 PM · Workboards (v3), Projects (v3)
epriestley updated subscribers of T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.

@20after4, any chance there's a stack trace for this in the webserver error logs? I can't immediately figure out how to reproduce this locally.

Jul 8 2019, 3:57 PM · Javelin

Jul 6 2019

aklapper created T13332: Javelin behaviors which pass PHUIViews to configuration parameters fatal the page in an abrupt way.
Jul 6 2019, 9:37 AM · Javelin

Jul 5 2019

amckinley closed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()" as Resolved by committing Restricted Diffusion Commit.
Jul 5 2019, 9:25 PM · Flags

Jul 4 2019

amckinley added a comment to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".

Thanks for the report. Fixed in D20642, which may or may not land today because of the holiday.

Jul 4 2019, 11:02 PM · Flags
amckinley added a revision to T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()": Unknown Object (Differential Revision).
Jul 4 2019, 11:01 PM · Flags
amckinley claimed T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".
Jul 4 2019, 10:40 PM · Flags
aklapper created T13331: "Next" button on personal Flags page triggers error "Call to undefined method PhabricatorFlagQuery::withIDs()".
Jul 4 2019, 2:49 PM · Flags

Jul 3 2019

20after4 awarded T11036: Put subproject columns on workboards a Love token.
Jul 3 2019, 11:03 PM · Workboards (v3), Projects (v3)
epriestley added a comment to T4900: Workboards updating in real time.

Just thinking out loud:

Jul 3 2019, 5:54 PM · Workboards (v3), User Delight, Wikimedia
epriestley closed T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board) as Resolved by committing Restricted Diffusion Commit.
Jul 3 2019, 5:02 PM · Workboards
epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: Unknown Object (Differential Revision).
Jul 3 2019, 3:19 PM · Quicksand

Jul 2 2019

epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 8:58 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 5:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

Here's roughly where I'm headed next. I'm planning to:

Jul 2 2019, 5:18 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

The "default" controller currently needs to "force" the URI parameters...
The "filter" controller currently needs to "force" the URI parameters...
The "apply" flow, where a new custom filter is applied...

Jul 2 2019, 4:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 4:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 3:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): Unknown Object (Differential Revision).
Jul 2 2019, 3:32 PM · Workboards
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 2:43 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): Unknown Object (Differential Revision).
Jul 2 2019, 2:43 PM · Workboards
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 1:16 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 12:50 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 12:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley closed T13330: OAuth Application object view pages have some out-of-date UI elements as Resolved by committing Restricted Diffusion Commit.
Jul 2 2019, 12:15 PM · OAuthServer

Jun 29 2019

epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 10:35 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

A couple of weird cases on state management:

Jun 29 2019, 10:14 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 10:12 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 9:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T13233: Consider supporting GPG/PGP.

This is sort of generically concerning to me:

Jun 29 2019, 8:47 PM · Diffusion, Mail
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 8:07 PM · Workboards (v3), User Delight, Wikimedia
epriestley moved T13301: Browser "Find..." feature isn't very useful in Safari on Workboards from Backlog to Far Future on the Workboards board.
Jun 29 2019, 7:54 PM · Workboards
epriestley closed T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts as Resolved.

This is deployed everywhere now, and kicking secure004 over seemed to work correctly, at least.

Jun 29 2019, 6:57 PM · Phacility
epriestley closed T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date as Resolved.

This stuff is all deployed, now.

Jun 29 2019, 6:56 PM · Daemons, Phacility
epriestley closed T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date, a subtask of T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts, as Resolved.
Jun 29 2019, 6:56 PM · Phacility
epriestley added a revision to T13330: OAuth Application object view pages have some out-of-date UI elements: Unknown Object (Differential Revision).
Jun 29 2019, 3:36 PM · OAuthServer
epriestley added a revision to T13330: OAuth Application object view pages have some out-of-date UI elements: Unknown Object (Differential Revision).
Jun 29 2019, 3:28 PM · OAuthServer
epriestley triaged T13330: OAuth Application object view pages have some out-of-date UI elements as Low priority.
Jun 29 2019, 3:24 PM · OAuthServer
epriestley edited the content of Changelog.
Jun 29 2019, 12:45 AM
epriestley created an object: 2019 Week 26 (Very Late June).
Jun 29 2019, 12:39 AM

Jun 28 2019

jbrownEP added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Any update on when this is going to reach stable? We're ~16 weeks past the earlier estimate...

Jun 28 2019, 11:13 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential