Page MenuHomePhabricator
Feed All Stories

Jan 3 2019

epriestley added a comment to T6994: Write a general "Security guidelines" document.

See a note in T12509 about HMAC key regeneration.

Jan 3 2019, 1:21 PM · Security
epriestley added a revision to T12509: Plan the path forward from HMAC-SHA1: Unknown Object (Differential Revision).
Jan 3 2019, 1:18 PM · Infrastructure, Security
klimek added a comment to T4926: When emails are sent to new people (or lists) they should contain the change description and patch.

For the record: I'd like us to get away from maintaining our own phab fork, and I agree that means probably migrating to a different system at some point.

Jan 3 2019, 11:18 AM · llvm, Mail, Differential
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Jan 3 2019, 1:16 AM · Plans

Jan 2 2019

epriestley moved T11782: Inconsistent mail notification subject ([Updated] vs [Merged]) depending on from which task a duplicate task was merged from Backlog to Soon? on the Mail board.
Jan 2 2019, 10:39 PM · Mail, Maniphest, Bug Report
chandlerc added a comment to T4926: When emails are sent to new people (or lists) they should contain the change description and patch.

FWIW, I think describing these as "non mainstream" and the entire description of these communities sounds to me ... somewhere between biased and pejorative. Makes it hard for me to keep engaging in the discussion.

Jan 2 2019, 9:17 PM · llvm, Differential, Mail
amckinley added a comment to T13230: Native Applications.

Does anyone have experience with an existing Push Notifications As A Service provider? I would naively suggest AWS SNS, because we already depend on other AWS services and it's free for the first 1m pushes, and then $0.50/1m pushes after that. It also wouldn't raise any new data privacy issues for Phacility customers since we wouldn't have to deliver pushes outside of our existing VPC infrastructure. List of supported push targets:

Jan 2 2019, 8:25 PM · Phacility
epriestley added a comment to T13123: Plans: Improve SSH key parsing and handling.

See PHI500 and T13179. Recent versions of SSH support passing the key fingerprint to the AuthorizedKeysCommand by specifying it like this:

Jan 2 2019, 8:22 PM · Plans, Auth
amckinley created P2113 (An Untitled Masterwork).
Jan 2 2019, 8:10 PM
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

D19935 prepares for multiple MFA provider types.

Jan 2 2019, 6:59 PM · Plans
epriestley added a comment to T4926: When emails are sent to new people (or lists) they should contain the change description and patch.

Maybe worth a mention -- GHC is another somewhat-similar project and moving to GitLab (e.g., https://mail.haskell.org/pipermail/ghc-devs/2018-October/016425.html). It sounds like GitLab is currently better able to spend resources to support free users with relatively non-mainstream use cases than we are.

Jan 2 2019, 6:38 PM · llvm, Mail, Differential
emaste added a comment to T4926: When emails are sent to new people (or lists) they should contain the change description and patch.

For the record, yes, FreeBSD is quite similar and what @chandlerc wrote is very much applicable to our community as well.

Jan 2 2019, 6:37 PM · llvm, Mail, Differential
epriestley added a comment to T4926: When emails are sent to new people (or lists) they should contain the change description and patch.

I think a lot of this behavior may be fairly unique to the LLVM project, since we've never really received this general class of feedback from other installs (except, perhaps, FreeBSD, which I think is somewhat culturally similar).

Jan 2 2019, 6:23 PM · llvm, Mail, Differential
chandlerc added a comment to T4926: When emails are sent to new people (or lists) they should contain the change description and patch.

For the record, while the rationale can be flippantly described as "I don't like clicking things", I'd like to give it a serious description.

Jan 2 2019, 5:44 PM · llvm, Mail, Differential
epriestley updated the task description for T13230: Native Applications.
Jan 2 2019, 5:42 PM · Phacility
epriestley moved T8636: Update "Configuring Inbound Email" to describe application email configuration in greater detail from v3 to Soon? on the Mail board.
Jan 2 2019, 5:23 PM · Documentation, Mail
epriestley renamed T5969: Add timeouts to service calls to external mailers (was: PhabricatorMetaMTAWorker may hang indefinitely if "sendmail" hangs indefinitely) from PhabricatorMetaMTAWorker may hang indefinitely if "sendmail" hangs indefinitely to Add timeouts to service calls to external mailers (was: PhabricatorMetaMTAWorker may hang indefinitely if "sendmail" hangs indefinitely).
Jan 2 2019, 5:14 PM · Mail
epriestley moved T5969: Add timeouts to service calls to external mailers (was: PhabricatorMetaMTAWorker may hang indefinitely if "sendmail" hangs indefinitely) from v3 to Soon? on the Mail board.
Jan 2 2019, 5:14 PM · Mail
epriestley added a comment to T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title.

This is the most upsetting bug in the software.

Jan 2 2019, 5:13 PM · Transactions, Mail
epriestley awarded T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title a Pirate Logo token.
Jan 2 2019, 5:13 PM · Transactions, Mail
epriestley moved T13082: Sometimes, mail about attaching revisions to tasks doesn't render the revision title from Backlog to Soon? on the Mail board.
Jan 2 2019, 5:12 PM · Transactions, Mail
epriestley closed T9012: Nag users who reply-all as Wontfix.

I'm generally very hesitant to "nag" users, and this conflicts with T7477 (which wants email to a group of users, including an application email address, to work). Of the two, I think T7477 is significantly more valuable. And, some day, many years from now, I'd theoretically like to make metamta.one-mail-per-recipient the only supported mode, which fixes this anyway.

Jan 2 2019, 5:11 PM · llvm, Mail, Restricted Project
epriestley closed T1109: Allow inbound e-mail without any agent configuration via IMAP as Wontfix.

This is a big chunk of work with no current customer interest. It could be implemented as a third-party extension today; otherwise I think it's unlikely to move forward without customer interest.

Jan 2 2019, 5:08 PM · Mail
epriestley closed T2806: Document fetchmail/procmail as inbound mail options as Wontfix.

These are so niche that I think we probably don't want to formally support them in the upstream.

Jan 2 2019, 5:07 PM · Mail, Documentation
epriestley moved T6162: Add an "Email and unread notification" option in user's Email Preferences from Backlog to Future on the Mail board.
Jan 2 2019, 5:05 PM · Notifications, llvm, Restricted Project, Mail
epriestley closed T4926: When emails are sent to new people (or lists) they should contain the change description and patch as Wontfix.

I don't plan to change this without a better understanding of what problem we're solving. New users can click the link in the email to review the discussion, summary, and patch.

Jan 2 2019, 5:00 PM · llvm, Mail, Differential
epriestley added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

See also PHI1011. I think the fix here is likely easy, but I'd like more clarity on:

Jan 2 2019, 4:43 PM · Diffusion
epriestley removed a project from T13233: Consider supporting GPG/PGP: Must Encrypt Mail.

(Must Encrypt Mail is a magic meta-tag for testing the feature, not an organizational tag.)

Jan 2 2019, 4:20 PM · Diffusion, Mail
epriestley updated the task description for T13233: Consider supporting GPG/PGP.
Jan 2 2019, 4:16 PM · Diffusion, Mail
epriestley added a comment to T13233: Consider supporting GPG/PGP.

See T8962, somewhat. When receiving inbound mail, we could decrypt PGP messages and verify PGP signatures.

Jan 2 2019, 4:14 PM · Diffusion, Mail
epriestley closed T8962: GPG signed emails confuse phabricator as Wontfix.

It sounds like behavior here is basically correct/expected (content is treated as content; attachments are treated as attachments) and the original report was a top-posting vs quoting issue perhaps (see also T5181), just not ideal (preferable would be validating the signature, or at least discarding these attachments).

Jan 2 2019, 4:10 PM · Differential, Mail
epriestley added a comment to T13233: Consider supporting GPG/PGP.

The existence of alternate ... code signing standards would motivate

Jan 2 2019, 4:07 PM · Diffusion, Mail
epriestley triaged T13233: Consider supporting GPG/PGP as Low priority.
Jan 2 2019, 3:55 PM · Diffusion, Mail
epriestley closed T13204: First mail sent by Differential doesn't have a Message-ID header set properly as Wontfix.

It seems like any client which has this behavior must always break when a user is added to an existing thread (via, for example, "Reply All" + add them as a "Cc"). I think we're either missing something significant, or those clients (possibly just KMail?) aren't handling this situation correctly and this is a bug which should be fixed in those clients rather than Phabricator.

Jan 2 2019, 3:39 PM · Mail, Differential
epriestley closed T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading as Wontfix.

I'm not confident there's really a path forward here even for the subset of mailers where we have full control of the SMTP envelope and can generate Message-IDs, which is only a small subset of mailers today. Even if it does work, it makes the "Reply All" problem worse.

Jan 2 2019, 3:33 PM · Restricted Project, Mail, Feature Request
epriestley closed T1837: Implement correct send-as-user behavior. as Wontfix.

Not clear that "Sender" is worth pursuing, even if it does give us more flexibility around configuring the "From" header in some cases.

Jan 2 2019, 3:30 PM · llvm, Restricted Project, Mail
epriestley closed T1735: Improve implementation of "Re:" prefix by dropping it from messages which are unambiguously first-in-thread as Invalid.

This is years old and I have no idea how to reproduce it. (I use Mail with "Organize by Conversation" as my primary mail client, and have for about a decade.)

Jan 2 2019, 3:27 PM · llvm, Restricted Project, Mail
epriestley moved T6670: Macro images don't show up on html emails if your instance requires logins from Backlog to Soon? on the Mail board.
Jan 2 2019, 3:22 PM · Macros, Mail
epriestley moved T9896: make images from comments visible in email from Backlog to Soon? on the Mail board.
Jan 2 2019, 3:21 PM · Restricted Project, Remarkup, Mail
epriestley moved T12910: Allow SES to be used for inbound mail from Backlog to Future on the Mail board.
Jan 2 2019, 3:20 PM · Mail
epriestley moved T12921: Link to referenced object in transaction emails from Backlog to Soon? on the Mail board.
Jan 2 2019, 3:19 PM · Mail
epriestley moved T7477: Handle inbound email with phabricator address in the CC from Future to Soon? on the Mail board.
Jan 2 2019, 3:19 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley moved T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender from Future to Soon? on the Mail board.
Jan 2 2019, 3:19 PM · Mail
epriestley renamed T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender from Refine inbound mail error behaviors to Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender.
Jan 2 2019, 3:15 PM · Mail
epriestley moved T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender from Far Future to Future on the Mail board.
Jan 2 2019, 3:15 PM · Mail
epriestley added a comment to T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender.

This logic should probably look more like this [differentiating between explicit senders and receive-as-users].

Jan 2 2019, 3:15 PM · Mail
kerberizer awarded T9720: Provide a way to link to Diffusion files a Like token.
Jan 2 2019, 2:43 PM · Restricted Project, Remarkup
epriestley added a revision to T920: Provide SMS Support: Unknown Object (Differential Revision).
Jan 2 2019, 2:07 PM · Restricted Project, Herald
epriestley added a revision to T12509: Plan the path forward from HMAC-SHA1: Unknown Object (Differential Revision).
Jan 2 2019, 4:56 AM · Infrastructure, Security
epriestley added a revision to T920: Provide SMS Support: Unknown Object (Differential Revision).
Jan 2 2019, 4:24 AM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: Unknown Object (Differential Revision).
Jan 2 2019, 4:03 AM · Restricted Project, Herald
epriestley added a comment to T920: Provide SMS Support.

As tends to be par for the course, this is turning into a bit of a rabbit hole.

Jan 2 2019, 3:56 AM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: Unknown Object (Differential Revision).
Jan 2 2019, 3:16 AM · Restricted Project, Herald
epriestley added a revision to T920: Provide SMS Support: Unknown Object (Differential Revision).
Jan 2 2019, 3:12 AM · Restricted Project, Herald

Dec 31 2018

avivey added a comment to T13231: Duo MFA Support.

I expect Google to expose a similar solution to Duo soonish (if you use Android and try to login to Google, MFA is just like Duo now).

Dec 31 2018, 6:29 AM · Auth
avivey added a comment to T13230: Native Applications.

Some of these things are supposed to be implemented in a reasonable way via browsers "eventually" (offline push notifications have a bunch of attempts, Screenshots use case has some solutions that sometimes work, and there's rumor about MFA and NFC floating around.)

Dec 31 2018, 6:24 AM · Phacility
avivey renamed T13230: Native Applications from Native Mobile Applications to Native Applications.
Dec 31 2018, 6:10 AM · Phacility
avivey renamed T13230: Native Applications from Native Applications to Native Mobile Applications.
Dec 31 2018, 6:07 AM · Phacility

Dec 30 2018

epriestley added a revision to T920: Provide SMS Support: Unknown Object (Differential Revision).
Dec 30 2018, 6:57 PM · Restricted Project, Herald
epriestley added a comment to T920: Provide SMS Support.

I'm considering pushing this forward since MFA is getting an update (see T13231 and adjacent tasks).

Dec 30 2018, 6:53 PM · Restricted Project, Herald
epriestley triaged T13232: Mac OS X Mojave, SIP, Code Signing, and Apache as Low priority.
Dec 30 2018, 6:28 PM · Infrastructure

Dec 29 2018

epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 29 2018, 1:54 AM · Plans
epriestley added a revision to T13231: Duo MFA Support: Unknown Object (Differential Revision).
Dec 29 2018, 1:54 AM · Auth
cburroughs awarded T13229: On Third-Party Integrations a Piece of Eight token.
Dec 29 2018, 12:57 AM · Phacility

Dec 28 2018

epriestley triaged T13231: Duo MFA Support as Normal priority.
Dec 28 2018, 11:18 PM · Auth
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

I expect to make TOTP configuration a concrete object, then pursue Yubikey/U2F (T8787) and Duo (PHI912).

Dec 28 2018, 10:54 PM · Plans
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.
  • Also, comment interactions should get a warning when you'll be required to MFA on submit, especially when you don't have MFA on your account.
Dec 28 2018, 10:47 PM · Plans
epriestley edited the content of Changelog.
Dec 28 2018, 10:46 PM
epriestley triaged T13230: Native Applications as Low priority.
Dec 28 2018, 10:44 PM · Phacility
jcox awarded T13229: On Third-Party Integrations a Mountain of Wealth token.
Dec 28 2018, 10:20 PM · Phacility
epriestley renamed T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available from Yubikey Multi-Factor Authentication support to Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.
Dec 28 2018, 10:02 PM · Haskell.org, Auth
epriestley closed T11937: GCloud SQL does not support configuring sql_mode as Wontfix.

...it is virtually inconceivable to me that this is something we would ever bring upstream in any form.

Dec 28 2018, 9:58 PM · Infrastructure, Setup, Feature Request
epriestley added a subtask for T5055: Distribution mechanism for arc extensions: T13229: On Third-Party Integrations.
Dec 28 2018, 9:57 PM · Arcanist
epriestley added a parent task for T13229: On Third-Party Integrations: T5055: Distribution mechanism for arc extensions.
Dec 28 2018, 9:57 PM · Phacility
epriestley triaged T13229: On Third-Party Integrations as Low priority.
Dec 28 2018, 9:57 PM · Phacility
epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

Also, just so I don't forget:

Dec 28 2018, 8:47 PM · Plans
epriestley created 2018 Week 51 (End of Year).
Dec 28 2018, 8:44 PM
quark.zju added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

I'm not an Windows expert. But to my knowledge there are a couple of things missing here:

Dec 28 2018, 8:14 PM · Arcanist, Windows
adamchainz added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

Yes the exact text from the announcement about the intermittent failures states:

Dec 28 2018, 6:42 PM · Auth
kristo.mario added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

I received email from google announcing the deprecation few days ago. In the announcement they stated that they'll introduce intermittent failures on responses from the G+ API as soon as 01/2019.

Dec 28 2018, 5:55 PM · Auth

Dec 24 2018

renatomassaro awarded T13115: Handle mail bounces inside Phabricator a Like token.
Dec 24 2018, 8:07 AM · Mail

Dec 23 2018

epriestley added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

The original request focused on OTP, not U2F, but I think the amount of configuration required by OTP and the lack (?) of a pathway on mobile make it a better candidate for third-party integration than first-party integration. If we were supporting OTP in the upstream I'd want to run a first-party verification service so we aren't dependent on Yubikey's service, but the whole thing seems very messy and very bound to the Yubikey stack. It also looks (?) like Yubikey OTP and Yubikey U2F aren't linked to the same key (I think?) so you can't use U2F on one device and then fall back to OTP on mobile, even if you want to type in 44 characters? You have to enroll OTP and U2F separately.

Dec 23 2018, 1:06 AM · Haskell.org, Auth
epriestley added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

This browser doesn’t support the FIDO U2F standard yet.

Dec 23 2018, 12:00 AM · Haskell.org, Auth

Dec 22 2018

epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.

The bit-strength change above should still happen.

Dec 22 2018, 10:41 PM · Plans
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 22 2018, 10:17 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a comment to T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

$table = new PhabricatorUser();
$cache_path = 'progress.json';

Dec 22 2018, 10:15 PM · People, Phacility, Abuse
epriestley added a comment to T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

I just deleted the users above and am backing away from D19933, at least for now, since it doesn't feel like an especially great fit for either secure or admin.

Dec 22 2018, 6:35 PM · People, Phacility, Abuse
epriestley added a comment to T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

On admin, basically every user with a blurb is abusive. I've just disabled the field as a coarse reaction.

Dec 22 2018, 6:28 PM · People, Phacility, Abuse
epriestley updated subscribers of T13215: Secure/Admin have many accounts with commercial links in profile blurbs.

I'm planning to banish these users from secure. This is mostly: polish (?) SEO bots; printer fax spam; and "security researchers":

Dec 22 2018, 5:49 PM · People, Phacility, Abuse
epriestley added a revision to T13215: Secure/Admin have many accounts with commercial links in profile blurbs: Unknown Object (Differential Revision).
Dec 22 2018, 5:09 PM · People, Phacility, Abuse
epriestley triaged T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019 as Normal priority.
Dec 22 2018, 2:36 PM · Auth
epriestley closed T13228: Cycle AWS Hosts (January 2019) as Wontfix.

There's some ephemeral data on this host and my house doesn't currently burn down if the associated services are unavailable, so I'm just going to let AWS restart it when the time comes.

Dec 22 2018, 2:35 PM
epriestley added a revision to T13222: 2018 Week 48-51 Bonus Content: Unknown Object (Differential Revision).
Dec 22 2018, 12:54 PM · Plans

Dec 21 2018

avivey added a comment to T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.

Since the google-api is also disabled by default in Google Cloud env, I had to make changes to some other oauth provider at https://gitlab.com/SirEdvin/sanic-oauth/commit/fae23f6b35517dd9e8bec328dbb4dc883e033d78.
There, the g+ api was only used to get the user's email, iirc, and an alternative exists in https://www.googleapis.com/userinfo/v2/me.

Dec 21 2018, 1:51 AM · Auth

Dec 20 2018

epriestley added a comment to T13222: 2018 Week 48-51 Bonus Content.
  • We still need to key the Image table in Pholio (see D19914) although the right key looks like just <mockPHID>.
  • instances/ should get some cleanup for the changes to transactions.
Dec 20 2018, 10:53 PM · Plans
epriestley claimed T13228: Cycle AWS Hosts (January 2019).

Oh, this is on my personal AWS account. Oops!

Dec 20 2018, 10:50 PM
epriestley created T13228: Cycle AWS Hosts (January 2019).
Dec 20 2018, 10:48 PM
epriestley created T13227: Figure out if Google Auth needs to be updated before Google+ shutdown on March 7, 2019.
Dec 20 2018, 10:47 PM · Auth
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 9:53 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request
epriestley added a revision to T11351: Move Pholio to EditEngine and modern APIs: Unknown Object (Differential Revision).
Dec 20 2018, 9:33 PM · Restricted Project, EditEngine, Conduit, Pholio, Feature Request