Page MenuHomePhabricator
Feed All Stories

Oct 19 2018

epriestley closed T12703: When integrated, CircleCI and Harbormaster can send redundant notifications as Wontfix.

This currently appears to be mooted by T13188.

Oct 19 2018, 9:27 AM · Feature Request, Harbormaster

Oct 17 2018

epriestley added a comment to T13109: Improve cluster write feedback and write routing.

I think you can cherry-pick those changes safely. I suspect further changes connected to T13211 and/or T10884 in the near future are likely to be difficult to cherry-pick, though, so ideally you should try to upgrade.

Oct 17 2018, 10:01 PM · Diffusion
epriestley added a comment to T13115: Handle mail bounces inside Phabricator.

To pull the list down (this takes a while since we can only grab 100 results at a time and the API takes a while to respond):

Oct 17 2018, 8:47 PM · Mail
epriestley added a comment to T13115: Handle mail bounces inside Phabricator.

See PHI926, where a GSuite-backed install has seen multiple "550 No Such User" bounces to the same address even though the address exists. It's currently unclear if this is an issue in Mailgun, GSuite, the series of tubes between the two, or elsewhere.

Oct 17 2018, 8:24 PM · Mail
nickz added a comment to T13109: Improve cluster write feedback and write routing.

@epriestley : our current phabricator version is c46be2a70b4db72d61e76690ef095384de2c3f91 that was landed on 04/13, will there be any issues if we directly cherry pick the recent two versions without pulling any other changes?
rP51073b972ece: Try to route cluster writes to nodes which won't need to synchronize first.Wed, Oct 17, 3:08 PM
rPbc6c8c0e93a7: Explicitly shuffle nodes before selecting one for cluster sync.

Oct 17 2018, 7:37 PM · Diffusion
epriestley updated the task description for T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Oct 17 2018, 2:04 PM · Plans, Phacility
epriestley edited the content of Changelog.
Oct 17 2018, 6:45 AM
epriestley created 2018 Week 41 (Mid October).
Oct 17 2018, 6:43 AM

Oct 16 2018

epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: Unknown Object (Differential Revision).
Oct 16 2018, 7:48 PM · Plans
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

One idea here: T12961 and T13012 are security issues related to the misuse of -- in argument lists. I think there was one more (less severe issue?) with Git elsewhere, too.

Oct 16 2018, 2:54 PM · Arcanist, Plans
epriestley renamed T13210: Plans: 2018 Week 41-44 Bonus Content from Plans: 2018 Week 41 Bonus Content to Plans: 2018 Week 41-42 Bonus Content.
Oct 16 2018, 2:32 PM · Plans
epriestley added a project to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call: Drydock.
Oct 16 2018, 2:32 PM · Drydock
epriestley added a comment to T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.

This is entirely reasonable, the only reason it doesn't already exist is that the lease owner may be any of several different types of objects (I think: user, repository, another Drydock object, maybe null?) and we don't have a convenient UI datasource for letting users type to select any one of these various object types.

Oct 16 2018, 2:32 PM · Drydock
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 16 2018, 1:36 PM · Plans, Harbormaster
• yingshu awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Pterodactyl token.
Oct 16 2018, 8:06 AM · Workboards (v3), Restricted Project

Oct 15 2018

epriestley closed T13213: Thoughts on Control Systems as Resolved.

¯\_(ツ)_/¯

Oct 15 2018, 9:49 PM
epriestley added a revision to T13213: Thoughts on Control Systems: Restricted Differential Revision.
Oct 15 2018, 9:42 PM
epriestley triaged T13213: Thoughts on Control Systems as Wishlist priority.
Oct 15 2018, 8:04 PM

Oct 12 2018

jwarner updated the task description for T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call.
Oct 12 2018, 4:27 PM · Drydock
jwarner triaged T13212: Add 'ownerPHIDs' query constraint to 'drydock.lease.search' conduit call as Normal priority.
Oct 12 2018, 4:27 PM · Drydock
epriestley added a member for Blessed Committers: jwarner.
Oct 12 2018, 4:13 PM
epriestley added a member for Community: jwarner.
Oct 12 2018, 4:13 PM
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 12 2018, 3:19 PM · Plans, Harbormaster

Oct 11 2018

epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: Unknown Object (Differential Revision).
Oct 11 2018, 7:38 PM · Plans
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: Unknown Object (Differential Revision).
Oct 11 2018, 3:31 PM · Plans

Oct 10 2018

epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Oct 10 2018, 11:42 PM · Plans, Harbormaster
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: Unknown Object (Differential Revision).
Oct 10 2018, 7:44 PM · Plans
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

I think that workflow is pretty strongly undesirable: it suggests users make an incorrect change (e.g., suggest a patch which violates the style guideline) and they're expected to answer "Y" to it.

Oct 10 2018, 7:30 PM · Restricted Project, Arcanist
jparise added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

One additional perspective on this:

Oct 10 2018, 7:03 PM · Restricted Project, Arcanist
epriestley updated the task description for T13210: Plans: 2018 Week 41-44 Bonus Content.
Oct 10 2018, 4:08 PM · Plans
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Oct 10 2018, 12:04 AM · XHPAST

Oct 9 2018

urzds added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

See-Also: https://circleci.com/ideas/?idea=CCI-I-430
See-Also: https://discuss.circleci.com/t/webhook-support-removed-from-documentation-still-supported/19984

Oct 9 2018, 10:08 AM · Guides, Harbormaster
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Oct 9 2018, 1:39 AM · XHPAST

Oct 8 2018

epriestley triaged T13211: Improve intracluster synchronization routing as Normal priority.
Oct 8 2018, 7:29 PM · Clusters, Diffusion
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: Unknown Object (Differential Revision).
Oct 8 2018, 6:22 PM · Plans
epriestley added a revision to T13210: Plans: 2018 Week 41-44 Bonus Content: Unknown Object (Differential Revision).
Oct 8 2018, 5:19 PM · Plans
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I think this is all done but want to let things run against bastion007 for a bit before I tear down bastion005.

Oct 8 2018, 3:43 PM · Phacility, Ops
epriestley added a revision to T13207: Cycle More AWS Hosts (October 2018): Unknown Object (Differential Revision).
Oct 8 2018, 3:41 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I also needed to copy the old master.key from bastion005 to bastion007 in /core/lib/keystore/.

Oct 8 2018, 3:40 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I turned bastion.phacility.net and bastion-external.phacillity.net into CNAME records and pointed them at the new bastions.

Oct 8 2018, 3:35 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

There's a minor deadlock on bastion deployment with the current scripts: during deploy, we run deploy-key to copy the deploy key from the bastion to the target host during deployment, so that we don't need to put the entire keystore on normal cluster nodes, and so that we don't need to have the keystore on the control host (staff laptop) outside the cluster.

Oct 8 2018, 3:31 PM · Phacility, Ops
wjiang added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Oct 8 2018, 12:51 AM · XHPAST

Oct 7 2018

avivey added a comment to T8440: Tooltip flicker at certain cursor positions.

https://discourse.phabricator-community.org/t/differential-ui-tooltip-flicks-on-hover/1970 has some css witchcraft to make this not happen.

Oct 7 2018, 9:42 PM · PHUI

Oct 6 2018

epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I cycled all the hosts except bastion. saux001 needs to be vetted a bit (it handles "Land Revision" from the web UI) but it isn't critical if it needs a bit more work.

Oct 6 2018, 3:38 PM · Phacility, Ops
epriestley added a comment to T13207: Cycle More AWS Hosts (October 2018).

I 'm going to get these underway once the deploy finishes.

Oct 6 2018, 2:45 PM · Phacility, Ops
epriestley edited the content of Changelog.
Oct 6 2018, 1:35 PM
epriestley created 2018 Week 40 (Early October).
Oct 6 2018, 1:32 PM

Oct 5 2018

epriestley raised the priority of T13210: Plans: 2018 Week 41-44 Bonus Content from Low to Normal.
Oct 5 2018, 11:19 PM · Plans
epriestley triaged T13210: Plans: 2018 Week 41-44 Bonus Content as Low priority.
Oct 5 2018, 11:19 PM · Plans
epriestley closed T13202: Plans: 2018 Week 38-40 Bonus Content as Resolved.
Oct 5 2018, 11:19 PM · Plans
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Unknown Object (Differential Revision).
Oct 5 2018, 9:01 PM · Diffusion
epriestley added a revision to T10884: Sort repository, database and notification services better (by network distance): Unknown Object (Differential Revision).
Oct 5 2018, 9:01 PM · Clusters
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 5 2018, 9:01 PM · Plans
epriestley closed T12814: pholio transaction emails have too much html as Resolved by committing Restricted Diffusion Commit.
Oct 5 2018, 8:37 PM · Pholio, Transactions, Bug Report
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Unknown Object (Differential Revision).
Oct 5 2018, 8:35 PM · Diffusion
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 5 2018, 8:35 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 5 2018, 7:23 PM · Plans
epriestley added a revision to T12814: pholio transaction emails have too much html: Unknown Object (Differential Revision).
Oct 5 2018, 6:43 PM · Pholio, Transactions, Bug Report
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 5 2018, 6:43 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 5 2018, 6:14 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 5 2018, 5:52 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 5 2018, 5:52 PM · Plans
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

For now, I just hard-wiped the cache and regenerated the documentation again. ¯\_(ツ)_/¯

Oct 5 2018, 4:15 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The file cache says that these files have already been parsed and contain no atoms, so the rest of the program behavior is expected after that. I'm not sure how this state came to exist.

Oct 5 2018, 4:03 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
  • DivinerPublisher->publishAtoms() is being passed nothing, so it's correctly deleting everything.
  • The graph cache is empty.
  • The actual atom.cache file on disk is empty.
  • The input to the cache is empty.
  • The files aren't being passed to the atomizer rules (although the rules appear to be applying correctly).
Oct 5 2018, 3:36 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

So, so far it looks like the database is in a "good" state but the publish workflow incorrectly deleted all the articles. From previous efforts, I believe dropping the cache fixes this issue.

Oct 5 2018, 3:26 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

But note that the graphHash and nodeHash columns are 0, which I believe is a signal that these nodes have been deleted (I haven't touched this code in a while).

Oct 5 2018, 3:21 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

Oh, the contrib stuff got separated into a different book and has fully unpublished:

Oct 5 2018, 1:27 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The "Contributor Introduction" document, specifically, seems to have unpublished. Let me see what I can dig up about the current database state.

Oct 5 2018, 1:14 PM · Diviner

Oct 4 2018

epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 4 2018, 10:45 PM · Plans
epriestley added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

"Yes", but post- T13098.

Oct 4 2018, 1:46 PM · Arcanist
joshuaspence added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

@epriestley, would you be open to making the chunk size configurable? Changing the chunk size from 32 to 512 reduced the amount of time required for us to lint ~1500 TypeScript files from 370 seconds to 66 seconds.

Oct 4 2018, 3:00 AM · Arcanist

Oct 3 2018

epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 3:15 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 2:54 PM · Plans
epriestley renamed T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Replace arc.bat with something better to Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]".
Oct 3 2018, 2:52 PM · Arcanist, Windows
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 1:30 AM · Plans

Oct 2 2018

epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:38 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:35 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:25 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:08 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 5:57 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 5:51 PM · Arcanist, Windows
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

In retrospect, I should have rigged the hash for the the "Remove libphutil" commit to have some cool recognizable prefix like de1e7ed, since half of arcanist/ now ends up there on git blame.

Oct 2 2018, 5:05 PM · Arcanist, Plans
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Also, guess what this checkbox does on Windows 10?

Oct 2 2018, 4:57 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Consider this script:

Oct 2 2018, 4:56 PM · Arcanist, Windows
epriestley lowered the priority of T2465: Context not available for revisions created on Windows from High to Low.
Oct 2 2018, 1:05 PM · Windows, Subversion, Arcanist
epriestley moved T9441: Cygwin PHP segfaults with arcanist from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:05 PM · Windows, Arcanist
epriestley moved T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:03 PM · Arcanist, Windows
epriestley renamed T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD") from arc patch fails on Windows with SVN to arc patch fails on Windows with SVN (because it uses "cd", not "setCWD").
Oct 2 2018, 1:03 PM · Windows, Arcanist
epriestley moved T8855: Add Powershell support to Arcanist documentation from Backlog to Powershell on the Windows board.
Oct 2 2018, 1:01 PM · Windows, Arcanist
epriestley moved T2465: Context not available for revisions created on Windows from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Subversion, Arcanist
epriestley moved T4964: Windows installer for Arcanist from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Setup, Wikimedia
epriestley moved T10910: Creating an arc diff from a working directory that is not the repository root from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Bug Report
epriestley moved T11072: Arcanist reports that it cannot generate a diff from SVN repo even though there are changes in the working copy from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Bug Report
epriestley renamed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) from Arcanist failed patch lint on windows to Arcanist failed patch lint on windows (because "cp" does not exist).
Oct 2 2018, 12:59 PM · Windows, Bug Report
epriestley closed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) as Resolved.

This was almost certainly resolved by D16273.

Oct 2 2018, 12:59 PM · Windows, Bug Report
epriestley moved T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint, Arcanist
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Windows, XHPAST
epriestley moved T5730: `arc lint --everything` reporting all symbols missing in libphutil/ on Windows? from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Lint, Windows, Arcanist