Page MenuHomePhabricator
Feed All Stories

Mar 15 2018

janitorial awarded T13105: Plans: Rich presentation and diff rendering pipelines for various file types a Pterodactyl token.
Mar 15 2018, 1:49 PM · Plans, Files, Differential, Diffusion
zacchiro added a comment to T5505: Plan Legalpad v2.

It would be nice if exemptions could be granted for all members of a given Phabricator group, rather than only on a user basis.
Use case: having a group of employees of a given organization, who don't need to sign a DCO-like document, because their employment contracts take care of it; while at the same time requiring DCO signing by external contributors.

Mar 15 2018, 9:03 AM · Restricted Project, Restricted Project
epriestley closed T13106: Task detail pages are issuing an egregious number of queries? as Resolved.

Some of this got fixed, some ended up in T13081.

Mar 15 2018, 3:37 AM · Performance

Mar 14 2018

epriestley closed T9950: Provide a URL that indicates Harbormaster build status as an image as Wontfix.
Mar 14 2018, 9:24 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

With that stuff, we're down from 473 to 227 on T9950. That's still awful, but not quite as ridiculous.

Mar 14 2018, 9:24 PM · Performance
epriestley closed T10102: No way to control PonderAnswer emails/notifications as Wontfix.

See T13069 for mail stamp plans.

Mar 14 2018, 9:18 PM · Restricted Project, Ponder
epriestley closed T10122: ctrl+enter to commit in all fields as Wontfix.
Mar 14 2018, 9:18 PM · Restricted Project, ApplicationEditor, Feature Request
epriestley closed T10078: Implement global readthrough cache pools as Resolved.

This was largely tackled above.

Mar 14 2018, 9:17 PM · Restricted Project, Infrastructure, Performance
epriestley added a revision to T13069: Make mail stamps routable on the server, include transaction information, and replace mail tags: Unknown Object (Differential Revision).
Mar 14 2018, 8:07 PM · Mail
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: Unknown Object (Differential Revision).
Mar 14 2018, 7:49 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

I'm having some difficulty merging (5) and (6), or either of them into (2). My local test also has a lot of nonsense going on that a real install shouldn't. I'm going to land what I've got so far and see how much progress we've made here.

Mar 14 2018, 7:33 PM · Performance
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: Unknown Object (Differential Revision).
Mar 14 2018, 7:14 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Queries are down to 139 for me locally.

Mar 14 2018, 7:10 PM · Performance
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: Unknown Object (Differential Revision).
Mar 14 2018, 6:57 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Queries are now down from 151 to 145 for me locally.

Mar 14 2018, 6:48 PM · Performance
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: Unknown Object (Differential Revision).
Mar 14 2018, 6:47 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Next problem:

Mar 14 2018, 6:34 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

For my local test task (T369), the initial page query load was 199 queries. After D19222 we're down slightly to 151 queries.

Mar 14 2018, 6:26 PM · Performance
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: Unknown Object (Differential Revision).
Mar 14 2018, 6:25 PM · Performance
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 6:24 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: Unknown Object (Differential Revision).
Mar 14 2018, 6:08 PM · Performance
epriestley updated the task description for T13106: Task detail pages are issuing an egregious number of queries?.
Mar 14 2018, 6:05 PM · Performance
epriestley added a revision to T13106: Task detail pages are issuing an egregious number of queries?: Unknown Object (Differential Revision).
Mar 14 2018, 5:55 PM · Performance
epriestley added a comment to T13106: Task detail pages are issuing an egregious number of queries?.

Some of this is:

Mar 14 2018, 5:53 PM · Performance
epriestley updated the task description for T13106: Task detail pages are issuing an egregious number of queries?.
Mar 14 2018, 5:31 PM · Performance
epriestley updated the task description for T13081: Quicksand breaks the back button after a reload, et al.
Mar 14 2018, 5:27 PM · Quicksand
epriestley triaged T13106: Task detail pages are issuing an egregious number of queries? as Normal priority.
Mar 14 2018, 5:17 PM · Performance
epriestley closed T9972: Profile image from Google not being picked up as Wontfix.
Mar 14 2018, 5:11 PM · Auth, Bug Report
epriestley closed T10004: ApplicationEditor Errata as Resolved.
Mar 14 2018, 5:11 PM · ApplicationEditor
epriestley closed T10061: Split the view policy into "space" and "visible to" line in forms as Wontfix.
Mar 14 2018, 5:09 PM · Maniphest, Spaces, Feature Request
epriestley closed T10103: Proxied object policies are not evaluated in the proper context as Resolved.

This was resolved by the introduction of PhabricatorExtendedPolicyInterface. Older cases with missing policy proxies occasionally crop up, but I believe most of them are resolved at HEAD of master. These errors always fail closed (deny access which should be acceptable), never fail open (allow impermissible access) so there's no urgency to hunting them down.

Mar 14 2018, 5:04 PM · Policy
epriestley updated the task description for T13064: `arc patch` can fail when a non-UTF8 file is detected as binary and moved (?).
Mar 14 2018, 3:30 PM · Arcanist, Differential
epriestley edited the content of Welcome.
Mar 14 2018, 3:10 PM
epriestley edited the content of Paid Prioritization.
Mar 14 2018, 3:09 PM
epriestley edited the content of Consulting.
Mar 14 2018, 3:06 PM
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 2:55 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 2:48 PM · Plans, Files, Differential, Diffusion
epriestley closed T2849: Implement alternate markup engines (Markdown, reStructuredText, ...) as Wontfix.

See followup in T13105.

Mar 14 2018, 6:45 AM · Remarkup
epriestley closed T2849: Implement alternate markup engines (Markdown, reStructuredText, ...), a subtask of T2815: Render Remarkup files in Diffusion, as Wontfix.
Mar 14 2018, 6:45 AM · Diffusion
epriestley closed T5698: Github-style Remarkup previews on a checked-in resource as Wontfix.

See followup in T13105.

Mar 14 2018, 6:45 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley added a project to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Plans.
Mar 14 2018, 6:43 AM · Plans, Files, Differential, Diffusion
epriestley triaged T13105: Plans: Rich presentation and diff rendering pipelines for various file types as Normal priority.
Mar 14 2018, 6:43 AM · Plans, Files, Differential, Diffusion

Mar 13 2018

epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: Unknown Object (Differential Revision).
Mar 13 2018, 11:39 PM · Plans
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Mar 13 2018, 11:12 PM · Plans, Harbormaster
epriestley updated the task description for T13102: Plans: 2018 Week 11 Bonus Content.
Mar 13 2018, 11:07 PM · Plans
epriestley closed T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async) as Resolved by committing Restricted Diffusion Commit.
Mar 13 2018, 7:38 PM · Database, Infrastructure
epriestley added a comment to T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async).

(I'll follow up in T13102 if there's more to be done here, it's possible that some installs are missing this for reasons other than "Ubuntu + apt get install php5-mysql").

Mar 13 2018, 7:38 PM · Database, Infrastructure
epriestley added a revision to T12994: Add a setup warning if MYSQLI_ASYNC is not defined (support for MySQLi async): Unknown Object (Differential Revision).
Mar 13 2018, 7:35 PM · Database, Infrastructure
epriestley added a comment to T13102: Plans: 2018 Week 11 Bonus Content.

It appears that MYSQLI_ASYNC depends mostly on mysqlnd ("MySQL Native Driver"). This has been the default since PHP 5.3 was released in 200 BC, but Ubuntu, at least, unbundles it and you can still install php5-mysql (non-native driver). Compounding this, we currently recommend installs install php5-mysql (bad), rather than php5-msyqlnd (good).

Mar 13 2018, 7:06 PM · Plans
jbrownEP added a comment to T11002: permit wildcards in OWNERs paths.

Yeah, that was the commit that reminded me how I wanted this. Unfortunately, it looks like the database still stores literal repositoryPHIDs, so the schema would need to change if it were to handle functions (which is why I bumped the ticket instead of taking a stab at implementing it myself first). I figured I'd add my voice to the ticket for now and continue toiling along with complex Herald rules for now.

Mar 13 2018, 7:05 PM · FreeBSD, Owners, Feature Request
jbrownEP edited the content of Organizations Using Phabricator.
Mar 13 2018, 7:04 PM
epriestley added a comment to T11002: permit wildcards in OWNERs paths.

After D19191 it would be relatively easy to support projects and wildcard functions (like "Any Repository") but there's currently no interest in this from customers.

Mar 13 2018, 6:59 PM · FreeBSD, Owners, Feature Request
jbrownEP added a comment to T11002: permit wildcards in OWNERs paths.

I don't suppose there's been any interest in adding wildcards/function matchers to Owners in the last couple of years?

Mar 13 2018, 6:56 PM · FreeBSD, Owners, Feature Request
epriestley added a comment to T13102: Plans: 2018 Week 11 Bonus Content.

While testing D19215 I ran into this behavior in Asana:

Mar 13 2018, 6:24 PM · Plans
epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: Unknown Object (Differential Revision).
Mar 13 2018, 6:15 PM · Plans
epriestley added a revision to T13103: Document favicon customization and validate the "ui.favicons" configuration option: Unknown Object (Differential Revision).
Mar 13 2018, 4:30 PM · Files, Aphront, Infrastructure
epriestley added a comment to T5741: Transparent meme animated gifs show up with a black background.

I wasn't able to reproduce the black background issue, exactly, but here's what I changed:

Mar 13 2018, 4:28 PM · Macros
epriestley closed T5741: Transparent meme animated gifs show up with a black background as Resolved by committing Restricted Diffusion Commit.
Mar 13 2018, 4:20 PM · Macros
epriestley added a revision to T5741: Transparent meme animated gifs show up with a black background: Unknown Object (Differential Revision).
Mar 13 2018, 4:07 PM · Macros
epriestley created Image Macro "tatsumakisenpukyaku".
Mar 13 2018, 3:31 PM
epriestley closed T13104: Policy "Subscribers" does not consider members of subprojects as Resolved by committing Restricted Diffusion Commit.
Mar 13 2018, 3:30 PM · Projects, Policy
epriestley added a revision to T13104: Policy "Subscribers" does not consider members of subprojects: Unknown Object (Differential Revision).
Mar 13 2018, 3:27 PM · Projects, Policy
epriestley claimed T13104: Policy "Subscribers" does not consider members of subprojects.

Thanks, I wasn't able to puzzle out the reproduction instructions on the original report since they didn't mention actually making any policy changes.

Mar 13 2018, 3:22 PM · Projects, Policy
avivey created T13104: Policy "Subscribers" does not consider members of subprojects.
Mar 13 2018, 6:34 AM · Projects, Policy
avivey awarded T13103: Document favicon customization and validate the "ui.favicons" configuration option a Yellow Medal token.
Mar 13 2018, 6:26 AM · Files, Aphront, Infrastructure

Mar 12 2018

epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: Unknown Object (Differential Revision).
Mar 12 2018, 11:54 PM · Plans
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 12 2018, 11:43 PM · Plans, Harbormaster
epriestley added a revision to T13102: Plans: 2018 Week 11 Bonus Content: Unknown Object (Differential Revision).
Mar 12 2018, 11:08 PM · Plans
epriestley renamed T13103: Document favicon customization and validate the "ui.favicons" configuration option from Make favicons composited and customizable to Document favicon customization and validate the "ui.favicons" configuration option.
Mar 12 2018, 10:34 PM · Files, Aphront, Infrastructure
epriestley added a comment to T13103: Document favicon customization and validate the "ui.favicons" configuration option.

(This still needs documentation and validation for the configuration option before it's done, but I don't have any short-term plans to pursue those.)

Mar 12 2018, 10:31 PM · Files, Aphront, Infrastructure
epriestley added a comment to T13103: Document favicon customization and validate the "ui.favicons" configuration option.

To customize this:

Mar 12 2018, 10:28 PM · Files, Aphront, Infrastructure
epriestley added a revision to T13103: Document favicon customization and validate the "ui.favicons" configuration option: Unknown Object (Differential Revision).
Mar 12 2018, 10:14 PM · Files, Aphront, Infrastructure
epriestley added a comment to T13103: Document favicon customization and validate the "ui.favicons" configuration option.

Safari, Chrome, and Firefox all seem fine with PNG icons so I think we don't need to deal with actual .ico icons.

Mar 12 2018, 7:45 PM · Files, Aphront, Infrastructure
epriestley closed T5857: Change favicon for Harbormaster builds, a subtask of T1049: Implement Harbormaster, as Wontfix.
Mar 12 2018, 7:15 PM · Harbormaster
epriestley closed T5857: Change favicon for Harbormaster builds as Wontfix.

I'm rolling this forward into T13103 but don't actually plan to implement Harbormaster build icons at this time since there are no outstanding requests from customers.

Mar 12 2018, 7:15 PM · Restricted Project, Harbormaster
epriestley triaged T13103: Document favicon customization and validate the "ui.favicons" configuration option as Normal priority.
Mar 12 2018, 7:14 PM · Files, Aphront, Infrastructure
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I lost the Tectonic Slam Facebreakers Juggernaut at to Arakaali's lasers (pew pew lasers, not graph paper lasers) at level 60. My Haku was still at level 1 and I was having a hard time with resists, and I think my lightning resist was at like 48% since A6 and I just sort of forgot about it.

Mar 12 2018, 6:51 PM · Phacility
epriestley updated the task description for T13102: Plans: 2018 Week 11 Bonus Content.
Mar 12 2018, 5:30 PM · Plans

Mar 11 2018

• kvaster added a comment to T13036: Fix issues with recent Mercurial wire protocol versions.

For recent versions of mercurial to work over http I had to force httpheader=1024 in code which filters bundle2 capabilities.

Mar 11 2018, 8:21 PM · Mercurial

Mar 9 2018

epriestley edited the content of Changelog.
Mar 9 2018, 9:10 PM
epriestley created 2018 Week 10 (Early March).
Mar 9 2018, 9:09 PM
epriestley added a comment to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction.

When phage is executed against a large number of hosts, a bunch of the processes fail immediately. This is likely easy to fix, either some sort of macOS ulimit or one of the sshd knobs. This isn't the limiting factor in any operational activity today but will be some day.

Mar 9 2018, 8:30 PM · Plans, Ops, Infrastructure, Phacility
epriestley closed T13099: Plans: 2018 Week 10 Bonus Content as Resolved.

That's probably it for promoting this week, see T13102 for next week.

Mar 9 2018, 4:05 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 9 2018, 4:04 PM · Plans
epriestley updated the task description for T13102: Plans: 2018 Week 11 Bonus Content.
Mar 9 2018, 4:04 PM · Plans
epriestley triaged T13102: Plans: 2018 Week 11 Bonus Content as Normal priority.
Mar 9 2018, 4:03 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 9 2018, 4:02 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 9 2018, 1:30 PM · Plans
kornrunner backed I2 Donate to Phacility with $10.00 USD.
Mar 9 2018, 1:20 PM · Phacility
Gryllida awarded T9412: Annotate all the reasons that a user is included on the recipient list for mail a Love token.
Mar 9 2018, 12:48 AM · llvm, Restricted Project, Mail

Mar 8 2018

epriestley closed T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy as Resolved.

Macro frowncat: Presuming this is resolved until I learn otherwise.

Mar 8 2018, 7:24 PM · Remarkup, Security, Macros
epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

very good memes

Mar 8 2018, 7:19 PM · Remarkup, Security, Macros
epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

Macro nyancat:  meow

Mar 8 2018, 7:19 PM · Remarkup, Security, Macros
epriestley added a comment to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy.

hmmm

Mar 8 2018, 7:18 PM · Remarkup, Security, Macros
epriestley closed T5258: Memes use older image transform code without modern error handling as Resolved by committing Restricted Diffusion Commit.
Mar 8 2018, 7:09 PM · Restricted Project, Macros, Files
epriestley closed T5258: Memes use older image transform code without modern error handling, a subtask of T7707: Implement a read-through cache layer, as Resolved.
Mar 8 2018, 7:09 PM · Performance
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Unknown Object (Differential Revision).
Mar 8 2018, 7:04 PM · Remarkup, Security, Macros
epriestley added a revision to T13099: Plans: 2018 Week 10 Bonus Content: Unknown Object (Differential Revision).
Mar 8 2018, 6:54 PM · Plans
epriestley updated the task description for T13099: Plans: 2018 Week 10 Bonus Content.
Mar 8 2018, 6:54 PM · Plans
epriestley added a revision to T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy: Unknown Object (Differential Revision).
Mar 8 2018, 6:50 PM · Remarkup, Security, Macros