Page MenuHomePhabricator
Feed All Stories

May 29 2017

Nirjhar created T12773: User image is found broken on migrating to the latest version of Phabricator..
May 29 2017, 10:23 AM · Bug Report (Needs Information)
atul.agrawal9911 added a comment to T12729: CLI scripts do not detect execution with bad SAPI binary (like `fcgi` instead of `cli` under cPanel).

Now i have changed that

May 29 2017, 9:02 AM · Setup
michelkaeser added a comment to T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).

In case anyone is still looking for a Trac Wiki -> Phabricator Phriction importer, we have an ugly but mainly functional script I pasted here: P2056. Code blocks are not always converted correctly, but for us that script was enough.

May 29 2017, 9:01 AM · Guides, Doorkeeper
michelkaeser created P2056 Trac Wiki Import Script.
May 29 2017, 8:59 AM · Phriction
jjooss added a comment to T12766: Can't use `differential.createcomment` with message and action.

Also, test agents probably shouldn't be accepting revisions at all. But ¯\_(ツ)_/¯

May 29 2017, 8:43 AM · Differential, Conduit, Bug Report
aik099 created T12772: Editing tabbed panel on dashboard removes tabs on save.
May 29 2017, 8:14 AM · Bug Report
bbrdaric asked Q624: How to rename files in Files app?.
May 29 2017, 8:03 AM · Files
• sshannin created T12771: Users can mistakenly create revisions with no repository through confusion or misconfiguration.
May 29 2017, 12:57 AM · Arcanist, Customer Impact, Differential, Spaces, Feature Request

May 28 2017

joshuaspence added a comment to D18040: Maintain POST requests when following redirects.

@epriestley, if you had any thoughts on this it would be appreciated as this issue is heavily affecting our users. There is a workaround (update our .arcconfig files to point to the new domain), but we have a lot of repositories...

May 28 2017, 11:04 PM
joshuaspence created D18040: Maintain POST requests when following redirects.
May 28 2017, 11:03 PM
amckinley created P2055 migration.php.
May 28 2017, 10:51 PM
chad added projects to T12770: The "need" saved query of Diffusion not upgraded : Audit, Dashboards.
May 28 2017, 8:22 PM · Dashboards, Audit, Bug Report
chad added a comment to T12770: The "need" saved query of Diffusion not upgraded .

Thanks! We'll keep this around and see if a migration is needed. Sounds like mostly a dashboards issue.

May 28 2017, 8:22 PM · Dashboards, Audit, Bug Report
chad added a comment to T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys.

@exp10r3r you still need to provide reproduction steps. Based on the ones provided, I cannot reproduce any issue using a new/clean install on Phacility or locally. That doesn't mean there isn't a bug to fix, but without the specifics needed to observe and troubleshoot the issue, we have no idea where to start or what to look for. Because we provide support for free, it's on report submitters to fill in all the details needed here. We can't assist with that. No other install is reporting this issue, so it's unlikely due to any change from the upstream.

May 28 2017, 7:46 PM · Bug Report (Needs Information)
exp10r3r updated the task description for T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys.
May 28 2017, 5:54 PM · Bug Report (Needs Information)
aik099 added a comment to T12770: The "need" saved query of Diffusion not upgraded .

Can you just pick a new query and fix the panel?

May 28 2017, 5:45 PM · Dashboards, Audit, Bug Report
chad added a comment to T12770: The "need" saved query of Diffusion not upgraded .

Can you just pick a new query and fix the panel? My thought is if only 1 person in 12 months is affected, it's going to be faster for you to fix the panel than for us to find resources to build an old image and test migrations.

May 28 2017, 3:26 PM · Dashboards, Audit, Bug Report
aik099 updated the task description for T12770: The "need" saved query of Diffusion not upgraded .
May 28 2017, 2:58 PM · Dashboards, Audit, Bug Report
aik099 created T12770: The "need" saved query of Diffusion not upgraded .
May 28 2017, 2:58 PM · Dashboards, Audit, Bug Report
LeCoyote added a comment to T7108: high server load due to continuous hg calls.

I can confirm T12129 is indeed related, and the suggested workaround is very effective. Thanks for this!
For the record, our repo has about 60 branches total (about a dozen active only).

May 28 2017, 2:46 PM · Mercurial
cspeckmim awarded M1476: Inline Comment Browse bar a Grey Medal token.
May 28 2017, 1:00 PM
aik099 awarded T10978: Modernize Audit a Like token.
May 28 2017, 8:20 AM · Audit
chad added a comment to M1476: Inline Comment Browse bar.

Took another pass here. I'd still like to figure out a way to get and working, but I could also just design them into the comments like they previously were. I think it's better though to have them in the top bar, since I could click on the and get right to the first bit of work I need to do.

May 28 2017, 4:21 AM
chad updated images of M1476: Inline Comment Browse bar.
May 28 2017, 4:14 AM
chad added a comment to M1476: Inline Comment Browse bar.

(though we could add a mini-minimap to it, just a thought)

May 28 2017, 3:31 AM
chad added a comment to M1476: Inline Comment Browse bar.

(it's probably distracting and pointless though for code review)

May 28 2017, 3:25 AM
chad added a comment to M1476: Inline Comment Browse bar.

To be clear, the "progress bar" background was a simple scroll indicator, nothing related to marking things done. Some blogs use them and I find in ... interesting ... nothing more. It's sort of nice to know how much you have to read through to be finished. It would start at the top of the first file and end when the final comment box appears. You can see one in action here: http://www.avclub.com/article/why-does-superman-keep-getting-turned-dictator-255977

May 28 2017, 3:24 AM
chad merged T12769: Applications page shows Diffusion on admin into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
May 28 2017, 2:58 AM · Audit, Diffusion, Wikimedia
chad merged task T12769: Applications page shows Diffusion on admin into T6630: Uninstalling Audit should either be impossible or interact more cleanly with Diffusion.
May 28 2017, 2:58 AM · Phacility, Bug Report
joshuaspence created T12769: Applications page shows Diffusion on admin.
May 28 2017, 2:26 AM · Phacility, Bug Report

May 27 2017

epriestley merged T12765: Autofixes removing lines render incorrectly in `arc lint` into T9846: Diff on `arc lint` misleading when the replacement has newlines.
May 27 2017, 8:08 PM · Restricted Project, Arcanist, Lint
epriestley merged task T12765: Autofixes removing lines render incorrectly in `arc lint` into T9846: Diff on `arc lint` misleading when the replacement has newlines.
May 27 2017, 8:08 PM · Lint, Arcanist, Bug Report
epriestley added a comment to T12765: Autofixes removing lines render incorrectly in `arc lint`.

I'm going to merge this into T9846 since I think they're the same, yell if it looks like I'm missing anything.

May 27 2017, 8:08 PM · Lint, Arcanist, Bug Report
chad awarded Phabricator Gold to recipient: reed.
May 27 2017, 7:54 PM
reed added a comment to T12766: Can't use `differential.createcomment` with message and action.

Thanks, everybody! Appreciate it, especially on a Friday night. :-)

May 27 2017, 6:36 AM · Differential, Conduit, Bug Report
reed backed I2 Donate to Phacility with $19.78 USD.
May 27 2017, 6:10 AM · Phacility
alexmv closed T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error) as Resolved.

Based on two points of anecdata so far, things indeed seem snappier with D17959.

May 27 2017, 4:32 AM · Restricted Project, Workboards
chad added a comment to T12768: PhabricatorTaskmasterDaemon using fabulous amounts of RAM.

Please read and follow Contributing Bug Reports carefully.

May 27 2017, 4:12 AM · Bug Report
chad closed T12768: PhabricatorTaskmasterDaemon using fabulous amounts of RAM as Invalid.
May 27 2017, 4:09 AM · Bug Report
kcloze created T12768: PhabricatorTaskmasterDaemon using fabulous amounts of RAM.
May 27 2017, 4:08 AM · Bug Report
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

Here's an example of the old style:

May 27 2017, 3:31 AM · Customer Impact, Feature Request
chad claimed T12766: Can't use `differential.createcomment` with message and action.
May 27 2017, 3:26 AM · Differential, Conduit, Bug Report
epriestley added a comment to T12766: Can't use `differential.createcomment` with message and action.

Also, test agents probably shouldn't be accepting revisions at all. But ¯\_(ツ)_/¯

May 27 2017, 3:18 AM · Differential, Conduit, Bug Report
epriestley added a comment to T12766: Can't use `differential.createcomment` with message and action.

Note also that differential.revision.edit accepts IDs and harbormaster.createartifact allows you to create links to build results without needing to gum up the feed with comments. We will eventually remove differential.createcomment so things will need to update sooner or later.

May 27 2017, 3:17 AM · Differential, Conduit, Bug Report
epriestley closed T12766: Can't use `differential.createcomment` with message and action as Resolved.

This should be fixed in HEAD of master and stable. Thanks for the report!

May 27 2017, 3:15 AM · Differential, Conduit, Bug Report
chad added a comment to T12767: Viewing a badge details page should show users that have received it.

Its on another page for scalability, we used to just have a single page.

May 27 2017, 3:06 AM · Badges, Feature Request
amckinley closed T12767: Viewing a badge details page should show users that have received it as Invalid.

Yep, that would be the page. I was expecting to see details ala "Related Objects" in Maniphest and failed to move my eyes sufficiently left.

May 27 2017, 3:05 AM · Badges, Feature Request
chad added a comment to T12767: Viewing a badge details page should show users that have received it.

This page?

May 27 2017, 3:02 AM · Badges, Feature Request
amckinley created T12767: Viewing a badge details page should show users that have received it.
May 27 2017, 2:58 AM · Badges, Feature Request
chad added a revision to T12766: Can't use `differential.createcomment` with message and action: Unknown Object (Differential Revision).
May 27 2017, 1:56 AM · Differential, Conduit, Bug Report
reed added a comment to T12766: Can't use `differential.createcomment` with message and action.

That does indeed work! Thank you so much!

May 27 2017, 1:53 AM · Differential, Conduit, Bug Report
chad added a comment to T12766: Can't use `differential.createcomment` with message and action.

Does this work?

May 27 2017, 1:41 AM · Differential, Conduit, Bug Report
reed added a comment to T12766: Can't use `differential.createcomment` with message and action.

Not easily. :/

May 27 2017, 1:29 AM · Differential, Conduit, Bug Report
amckinley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

From a technical standpoint, we did not record these relationships in a normalized way prior to D16196 (June 2016, about 7 months ago) -- they only existed in the transaction log, and we just wrote a "close", extra_data="as duplicate of X" transaction that can't be queried efficiently.

May 27 2017, 1:17 AM · Customer Impact, Feature Request
amckinley added a revision to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page: Unknown Object (Differential Revision).
May 27 2017, 1:14 AM · Customer Impact, Feature Request
chad added a comment to T12766: Can't use `differential.createcomment` with message and action.

Can you use the modern conduit calls?

May 27 2017, 1:13 AM · Differential, Conduit, Bug Report
amckinley claimed T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.
May 27 2017, 1:05 AM · Customer Impact, Feature Request
reed updated subscribers of T12766: Can't use `differential.createcomment` with message and action.
May 27 2017, 12:57 AM · Differential, Conduit, Bug Report
reed created T12766: Can't use `differential.createcomment` with message and action.
May 27 2017, 12:56 AM · Differential, Conduit, Bug Report

May 26 2017

alexmv created T12765: Autofixes removing lines render incorrectly in `arc lint`.
May 26 2017, 11:20 PM · Lint, Arcanist, Bug Report
chad closed T12185: Action Lists on Repository edit pages don't display on tablet/mobile as Resolved.

This accidentally got fixed this week

May 26 2017, 11:14 PM · Diffusion (v3), Bug Report
epriestley edited the content of Changelog.
May 26 2017, 11:05 PM
epriestley created 2017 Week 21 (Very Late May).
May 26 2017, 11:04 PM
isfs awarded T9868: PHUIDocumentViewPro ToC menu improvements a Party Time token.
May 26 2017, 10:59 PM · PHUI
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

That looks great to me.

May 26 2017, 10:30 PM · Maniphest, Conduit, Bug Report
amckinley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Actual example output:

May 26 2017, 10:30 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Yeah, with whatever wrapping context maniphest.search has, so like:

May 26 2017, 10:28 PM · Maniphest, Conduit, Bug Report
amckinley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

So should the return value for priority.search look something like this?

May 26 2017, 10:22 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

That is, the specific error "use lists" is aimed at preventing is this:

May 26 2017, 9:10 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

The config also looks like this right now:

May 26 2017, 9:07 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

I guess we already have "keywords" and should probably accept any of them, too, so "!priority high" in mail, /priority high in a comment, and "high" in Conduit all work consistently even if the actual key is "elevated".

May 26 2017, 9:02 PM · Maniphest, Conduit, Bug Report
amckinley closed T12104: Clean up remnants of old Differential draft storage as Resolved by committing Restricted Diffusion Commit.
May 26 2017, 8:59 PM · Infrastructure, Differential
epriestley added a comment to T12124: Counterintuitive priority setting via maniphest.edit conduit call.

Ideally, we should maybe freeze maniphest.querystatuses (which has a sort of ridiculous output format, I think?) and provide maniphest.status.search and maniphest.priority.search, which return results similar to other modern *.search methods even if they aren't implemented quite the same way (at least make the output format similar enough that a client library with methods like "turn a x.search call into a list of objects" would work on these methods, too).

May 26 2017, 8:57 PM · Maniphest, Conduit, Bug Report
amckinley added a revision to T12104: Clean up remnants of old Differential draft storage: Unknown Object (Differential Revision).
May 26 2017, 8:51 PM · Infrastructure, Differential
amckinley claimed T12124: Counterintuitive priority setting via maniphest.edit conduit call.

It looks like what we really need is a new method like maniphest.querystatuses, called maniphest.querypriorities to avoid anyone trying to hardcode these values.

May 26 2017, 8:43 PM · Maniphest, Conduit, Bug Report
epriestley added a comment to T12104: Clean up remnants of old Differential draft storage.

That sounds right to me.

May 26 2017, 8:39 PM · Infrastructure, Differential
chad added a comment to T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys.

Specifically, reproduction steps are a set of complete, detailed steps we can follow and see the same issue you are seeing locally. Bonus if you've taken a new, clean image and reproduced the issue.

May 26 2017, 8:31 PM · Bug Report (Needs Information)
chad edited projects for T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys, added: Bug Report (Needs Information); removed Bug Report.
May 26 2017, 8:30 PM · Bug Report (Needs Information)
chad added a comment to T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys.

This bug report is missing version information and reproduction steps.

May 26 2017, 8:27 PM · Bug Report (Needs Information)
amckinley claimed T12104: Clean up remnants of old Differential draft storage.

This looks pretty easy. No mentions of DifferentialDraft in the codebase other than the class itself and a single migration. Steps here (I think) are:

May 26 2017, 8:25 PM · Infrastructure, Differential
exp10r3r created T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys.
May 26 2017, 8:20 PM · Bug Report (Needs Information)
amckinley closed T12505: Ownership rules whose owning package is a milestone fail to show as accepted as Resolved by committing Restricted Diffusion Commit.
May 26 2017, 8:10 PM · Restricted Project, Projects, Owners, Bug Report
amckinley added a revision to T12505: Ownership rules whose owning package is a milestone fail to show as accepted: Unknown Object (Differential Revision).
May 26 2017, 7:56 PM · Restricted Project, Projects, Owners, Bug Report
epriestley closed T12762: Feed queries should support date range constraints as Resolved by committing Restricted Diffusion Commit.
May 26 2017, 7:24 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

See Planning for information on timelines and priorities.

May 26 2017, 6:52 PM · Diffusion, Mercurial
jeremy.norris added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Just curious if there is any news on this front?

May 26 2017, 6:50 PM · Diffusion, Mercurial
epriestley added a revision to T12762: Feed queries should support date range constraints: Unknown Object (Differential Revision).
May 26 2017, 6:24 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: Unknown Object (Differential Revision).
May 26 2017, 5:44 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: Unknown Object (Differential Revision).
May 26 2017, 5:24 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: Unknown Object (Differential Revision).
May 26 2017, 5:11 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Anyways, let's just go with "See all" in the header for now.

May 26 2017, 5:02 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

I'm also not sure how that works with pagination, like, do you update the URL so people can send links?

May 26 2017, 4:58 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

But that sounds like a lot of work.

May 26 2017, 4:57 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Basically what I'd like is something that auto-pulls maybe 5 times, then just makes you click a button thereafter. That solves the footer issue, makes it nicer for people who only want 2-3 more pages, and then the edge case of "no really I want to keep reading past 500 results" have to click a button.

May 26 2017, 4:57 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Let me marinate on it.

May 26 2017, 4:52 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a comment to T12762: Feed queries should support date range constraints.

Sure, we can do that too.

May 26 2017, 4:49 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a revision to T12762: Feed queries should support date range constraints: Unknown Object (Differential Revision).
May 26 2017, 4:45 PM · Customer Impact, ApplicationSearch, Feed
chad added a comment to T12762: Feed queries should support date range constraints.

Isn't auto-scroll with lots of JavaScript the right answer?

May 26 2017, 4:44 PM · Customer Impact, ApplicationSearch, Feed
epriestley claimed T12762: Feed queries should support date range constraints.
May 26 2017, 4:44 PM · Customer Impact, ApplicationSearch, Feed
epriestley added a comment to T12762: Feed queries should support date range constraints.

Ah, that makes sense. If there's some "good enough" way to get a button/link into these things today I'm happy to drop that in place while I'm in here, but we can just leave it for fiddling later too.

May 26 2017, 4:42 PM · Customer Impact, ApplicationSearch, Feed