Page MenuHomePhabricator
Feed All Stories

Mar 10 2021

epriestley committed rP404b55ce573a: Give audit statuses API constants that match their UI strings (authored by epriestley).
Give audit statuses API constants that match their UI strings
Mar 10 2021, 6:20 PM
epriestley closed D21601: Allow "transaction.search" to be called on an object type.
Mar 10 2021, 6:20 PM
epriestley closed D21600: Give audit statuses API constants that match their UI strings.
Mar 10 2021, 6:20 PM
epriestley requested review of D21601: Allow "transaction.search" to be called on an object type.
Mar 10 2021, 6:14 PM
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21601: Allow "transaction.search" to be called on an object type.
Mar 10 2021, 6:13 PM · Diffusion
epriestley requested review of D21600: Give audit statuses API constants that match their UI strings.
Mar 10 2021, 6:08 PM
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21600: Give audit statuses API constants that match their UI strings.
Mar 10 2021, 6:07 PM · Diffusion
epriestley committed rP2636d84d0c24: Remove very old Audit status constants and AuditRequest data (authored by epriestley).
Remove very old Audit status constants and AuditRequest data
Mar 10 2021, 5:22 PM
epriestley closed D21598: Remove very old Audit status constants and AuditRequest data.
Mar 10 2021, 5:22 PM
epriestley committed rPac2f5a10469a: Modernize and clean up "PhabricatorAuditStatusConstants" (authored by epriestley).
Modernize and clean up "PhabricatorAuditStatusConstants"
Mar 10 2021, 5:22 PM
epriestley closed D21597: Add a very basic "auditors" attachment to "differential.commit.search".
Mar 10 2021, 5:22 PM
epriestley closed D21599: Modernize and clean up "PhabricatorAuditStatusConstants".
Mar 10 2021, 5:22 PM
epriestley committed rP55532b3f7489: Add a very basic "auditors" attachment to "differential.commit.search" (authored by epriestley).
Add a very basic "auditors" attachment to "differential.commit.search"
Mar 10 2021, 5:22 PM
epriestley requested review of D21599: Modernize and clean up "PhabricatorAuditStatusConstants".
Mar 10 2021, 5:16 PM
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21599: Modernize and clean up "PhabricatorAuditStatusConstants".
Mar 10 2021, 5:15 PM · Diffusion
epriestley added inline comments to D21598: Remove very old Audit status constants and AuditRequest data.
Mar 10 2021, 12:08 AM
epriestley requested review of D21598: Remove very old Audit status constants and AuditRequest data.
Mar 10 2021, 12:02 AM
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21598: Remove very old Audit status constants and AuditRequest data.
Mar 10 2021, 12:01 AM · Diffusion

Mar 9 2021

epriestley added a comment to T13631: Support an "auditors" attachment for "diffusion.commit.search".

Long ago, we used to write a <package, commit> audit relationship with "AUDIT_NOT_REQUIRED", meaning "This commit affects the package, but package owners don't need to audit it.".

Mar 9 2021, 11:50 PM · Diffusion
epriestley requested review of D21597: Add a very basic "auditors" attachment to "differential.commit.search".
Mar 9 2021, 11:05 PM
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": D21597: Add a very basic "auditors" attachment to "differential.commit.search".
Mar 9 2021, 11:03 PM · Diffusion
epriestley added a comment to T13631: Support an "auditors" attachment for "diffusion.commit.search".

PhabricatorAuditStatusConstants appears to have a set of unused constants:

Mar 9 2021, 10:37 PM · Diffusion
epriestley triaged T13631: Support an "auditors" attachment for "diffusion.commit.search" as Low priority.
Mar 9 2021, 10:27 PM · Diffusion

Mar 6 2021

epriestley triaged T13630: Move Phacility provisioning to Piledriver as Normal priority.
Mar 6 2021, 8:03 PM · Almanac, Infrastructure, Phacility

Mar 5 2021

epriestley edited the content of Changelog.
Mar 5 2021, 9:31 PM
epriestley committed rPe7a40f84697f: (stable) Promote 2021 Week 10 (authored by epriestley).
(stable) Promote 2021 Week 10
Mar 5 2021, 9:30 PM
epriestley committed rARCe745e770fe6b: (stable) Promote 2021 Week 10 (authored by epriestley).
(stable) Promote 2021 Week 10
Mar 5 2021, 9:30 PM
epriestley renamed 2021 Week 10 (Early March) from 2021.10 to 2021 Week 10 (Early March).
Mar 5 2021, 9:29 PM
epriestley created an object: 2021 Week 10 (Early March).
Mar 5 2021, 9:29 PM
epriestley closed T13578: Provide `bin/user approve` to approve an account from the CLI as Resolved.

This is promoting to stable shortly and looks complete to me, thanks!

Mar 5 2021, 9:14 PM · Setup, Auth
epriestley added a comment to T13629: Provide alt text for images in more contexts.

These contexts are covered:

Mar 5 2021, 12:53 AM · Files
epriestley closed D21596: Provide default image alt text in more contexts and support custom alt text.
Mar 5 2021, 12:51 AM
epriestley committed rPbfe7cdc5a2af: Provide default image alt text in more contexts and support custom alt text (authored by epriestley).
Provide default image alt text in more contexts and support custom alt text
Mar 5 2021, 12:51 AM
epriestley requested review of D21596: Provide default image alt text in more contexts and support custom alt text.
Mar 5 2021, 12:49 AM
epriestley added a revision to T13629: Provide alt text for images in more contexts: D21596: Provide default image alt text in more contexts and support custom alt text.
Mar 5 2021, 12:48 AM · Files
epriestley triaged T13629: Provide alt text for images in more contexts as Low priority.
Mar 5 2021, 12:21 AM · Files

Mar 4 2021

epriestley committed rPfceb9a3f9e1d: Hide the "Author" field in Differential on the web create workflow (authored by epriestley).
Hide the "Author" field in Differential on the web create workflow
Mar 4 2021, 11:50 PM
epriestley closed D21595: Hide the "Author" field in Differential on the web create workflow.
Mar 4 2021, 11:50 PM
epriestley added a comment to T13612: Support Herald rules for Harbormaster Builds.

I dug up another one of these in PHI1439, but there is a lot of text in that issue that I haven't re-read yet.

Mar 4 2021, 5:54 PM · Herald, Harbormaster
epriestley requested review of D21595: Hide the "Author" field in Differential on the web create workflow.
Mar 4 2021, 5:45 PM
epriestley added a revision to T13628: Provide "Foist Upon", an inverse operation to "Commandeer": D21595: Hide the "Author" field in Differential on the web create workflow.
Mar 4 2021, 5:44 PM · Differential
epriestley committed rP9b6a030292d1: Use the same icon for "Resigned" in Differential and Diffusion (authored by epriestley).
Use the same icon for "Resigned" in Differential and Diffusion
Mar 4 2021, 5:34 PM
epriestley committed rPa9704428ffa5: In Audit, use repository identities to prevent author-auditors (authored by epriestley).
In Audit, use repository identities to prevent author-auditors
Mar 4 2021, 5:34 PM
epriestley closed D21594: In Audit, use repository identities to prevent author-auditors.
Mar 4 2021, 5:33 PM
epriestley closed D21593: Use the same icon for "Resigned" in Differential and Diffusion.
Mar 4 2021, 5:33 PM
epriestley requested review of D21594: In Audit, use repository identities to prevent author-auditors.
Mar 4 2021, 5:33 PM
epriestley requested review of D21593: Use the same icon for "Resigned" in Differential and Diffusion.
Mar 4 2021, 5:25 PM
epriestley committed rPf3caf7e9fcd6: Improve rendering behavior for "foist upon" with an empty tokenizer (authored by epriestley).
Improve rendering behavior for "foist upon" with an empty tokenizer
Mar 4 2021, 12:08 AM
epriestley closed D21592: Improve rendering behavior for "foist upon" with an empty tokenizer.
Mar 4 2021, 12:08 AM
epriestley added a comment to T13624: Provide an error log for `sshd` subprocesses.

Evidence increasingly suggests that the root problem here was GET_LOCK() issue in T13627, not an error in an sshd subprocess context.

Mar 4 2021, 12:08 AM · Diffusion
epriestley closed T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock as Resolved.

I deployed this to the hosts affected by PHI2009 yesterday, and it appears to have resolved the problem.

Mar 4 2021, 12:07 AM · Infrastructure
epriestley requested review of D21592: Improve rendering behavior for "foist upon" with an empty tokenizer.
Mar 4 2021, 12:02 AM
epriestley added a revision to T13628: Provide "Foist Upon", an inverse operation to "Commandeer": D21592: Improve rendering behavior for "foist upon" with an empty tokenizer.
Mar 4 2021, 12:01 AM · Differential

Mar 3 2021

epriestley commandeered D21591: Provide a more general "Author" transaction for Differential from bjshively.
Mar 3 2021, 11:56 PM
epriestley foisted D21591: Provide a more general "Author" transaction for Differential upon bjshively.
Mar 3 2021, 11:56 PM
epriestley updated the test plan for D21591: Provide a more general "Author" transaction for Differential.
Mar 3 2021, 11:51 PM
epriestley closed D21591: Provide a more general "Author" transaction for Differential.
Mar 3 2021, 11:49 PM
epriestley committed rPdec14136844d: Provide a more general "Author" transaction for Differential (authored by epriestley).
Provide a more general "Author" transaction for Differential
Mar 3 2021, 11:49 PM
epriestley requested review of D21591: Provide a more general "Author" transaction for Differential.
Mar 3 2021, 11:48 PM
epriestley added a revision to T13628: Provide "Foist Upon", an inverse operation to "Commandeer": D21591: Provide a more general "Author" transaction for Differential.
Mar 3 2021, 11:47 PM · Differential
epriestley renamed T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history from Certain "arc land" merges fail when they should succeed to When "arc land" selects a commit range with merge commits, it may fail to slice them from history.
Mar 3 2021, 10:13 PM · Arcanist
epriestley committed rARCd72fad6461b7: Add a character marker to the "IMPLICIT COMMITS" warning in "arc land" (authored by epriestley).
Add a character marker to the "IMPLICIT COMMITS" warning in "arc land"
Mar 3 2021, 9:41 PM
epriestley closed D21589: Add a character marker to the "IMPLICIT COMMITS" warning in "arc land".
Mar 3 2021, 9:41 PM
epriestley committed rARC953d742a1a9b: In "arc land", if rebasing a range fails, attempt to "reduce" it (authored by epriestley).
In "arc land", if rebasing a range fails, attempt to "reduce" it
Mar 3 2021, 9:41 PM
epriestley closed D21590: In "arc land", if rebasing a range fails, attempt to "reduce" it.
Mar 3 2021, 9:41 PM
epriestley committed rARC2d6452acb5f1: In Arcanist, when trying to write to a file configuration source, create… (authored by epriestley).
In Arcanist, when trying to write to a file configuration source, create…
Mar 3 2021, 9:41 PM
epriestley closed D21588: In Arcanist, when trying to write to a file configuration source, create missing directories.
Mar 3 2021, 9:41 PM
epriestley requested review of D21590: In "arc land", if rebasing a range fails, attempt to "reduce" it.
Mar 3 2021, 9:23 PM
epriestley added a revision to T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history: D21590: In "arc land", if rebasing a range fails, attempt to "reduce" it.
Mar 3 2021, 9:22 PM · Arcanist
epriestley requested review of D21589: Add a character marker to the "IMPLICIT COMMITS" warning in "arc land".
Mar 3 2021, 9:09 PM
epriestley added a revision to T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history: D21589: Add a character marker to the "IMPLICIT COMMITS" warning in "arc land".
Mar 3 2021, 9:08 PM · Arcanist
epriestley requested review of D21588: In Arcanist, when trying to write to a file configuration source, create missing directories.
Mar 3 2021, 9:06 PM
epriestley added a comment to T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history.

We might be able to detect that the --strategy-option theirs merge has done something suspicious by trying to merge C^ into the final state (or vice versa). If it merges cleanly, I think we can be fairly confident that the changes are actually independent. However, I'm not sure offhand what we could conclude if it doesn't merge cleanly.

Mar 3 2021, 9:01 PM · Arcanist
epriestley added a comment to T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history.

A particular example is:

Mar 3 2021, 8:55 PM · Arcanist
epriestley updated subscribers of T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history.

In the general case, the problem is that some invocations of arc, including arc land --pick A, may select an arbitrary range of commits to land which have some ancestors that we do NOT want to land.

Mar 3 2021, 8:10 PM · Arcanist
epriestley triaged T13628: Provide "Foist Upon", an inverse operation to "Commandeer" as Low priority.
Mar 3 2021, 6:51 PM · Differential
epriestley added a comment to T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history.

git diff ...

Mar 3 2021, 4:55 PM · Arcanist
matthewrbowker closed D21587: Provide new tool "bin/user approve" to approve an account..
Mar 3 2021, 4:36 AM
matthewrbowker committed rPc0ac5be8a843: Provide new tool "bin/user approve" to approve an account. (authored by matthewrbowker).
Provide new tool "bin/user approve" to approve an account.
Mar 3 2021, 4:36 AM
matthewrbowker updated the diff for D21587: Provide new tool "bin/user approve" to approve an account..
  • Address code review comments
Mar 3 2021, 4:34 AM
epriestley committed rP629429b28354: (stable) Never return external connections to the GlobalLock connection pool (authored by epriestley).
(stable) Never return external connections to the GlobalLock connection pool
Mar 3 2021, 3:26 AM
epriestley committed rPaa2d89f1d4c5: (stable) When a GlobalLock with an external connection is released, don't… (authored by epriestley).
(stable) When a GlobalLock with an external connection is released, don't…
Mar 3 2021, 3:26 AM
epriestley committed rP4aecb6f25d12: (stable) Refuse to acquire a second GlobalLock on a connection (authored by epriestley).
(stable) Refuse to acquire a second GlobalLock on a connection
Mar 3 2021, 3:26 AM
epriestley committed rP84049ed4793c: (stable) Prevent external connections from being mutated on held locks (authored by epriestley).
(stable) Prevent external connections from being mutated on held locks
Mar 3 2021, 3:26 AM
epriestley accepted D21587: Provide new tool "bin/user approve" to approve an account..

Couple minor inlines, but looks good to me. I added you to Blessed Committers so you should be able to land this yourself -- see the description of that project for guidance, or let me know if you run into issues.

Mar 3 2021, 3:25 AM
epriestley added a member for Blessed Committers: matthewrbowker.
Mar 3 2021, 3:24 AM
matthewrbowker added a reviewer for D21587: Provide new tool "bin/user approve" to approve an account.: epriestley.
Mar 3 2021, 2:23 AM
matthewrbowker requested review of D21587: Provide new tool "bin/user approve" to approve an account..
Mar 3 2021, 2:22 AM
matthewrbowker added a revision to T13578: Provide `bin/user approve` to approve an account from the CLI: D21587: Provide new tool "bin/user approve" to approve an account..
Mar 3 2021, 2:22 AM · Setup, Auth
epriestley added a comment to T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history.

Broadly, I believe these "certain changes" are approximately changes which include a merge commit.

Mar 3 2021, 12:37 AM · Arcanist

Mar 2 2021

epriestley updated the task description for T13625: Daemons may make commit-related API calls as users without privileges.
Mar 2 2021, 11:29 PM · Diffusion, Daemons
epriestley updated the task description for T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history.
Mar 2 2021, 11:19 PM · Arcanist
epriestley updated the task description for T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock.
Mar 2 2021, 9:50 PM · Infrastructure
epriestley committed rP2b473558c2b3: Refuse to acquire a second GlobalLock on a connection (authored by epriestley).
Refuse to acquire a second GlobalLock on a connection
Mar 2 2021, 9:44 PM
epriestley closed D21583: When a GlobalLock with an external connection is released, don't return it to the pool.
Mar 2 2021, 9:44 PM
epriestley committed rP33bce22ef2ad: Never return external connections to the GlobalLock connection pool (authored by epriestley).
Never return external connections to the GlobalLock connection pool
Mar 2 2021, 9:44 PM
epriestley committed rP15dbf6bdf0a5: When a GlobalLock with an external connection is released, don't return it to… (authored by epriestley).
When a GlobalLock with an external connection is released, don't return it to…
Mar 2 2021, 9:44 PM
epriestley closed D21585: Never return external connections to the GlobalLock connection pool.
Mar 2 2021, 9:44 PM
epriestley committed rP466013f11a6d: Prevent external connections from being mutated on held locks (authored by epriestley).
Prevent external connections from being mutated on held locks
Mar 2 2021, 9:44 PM
epriestley closed D21584: Prevent external connections from being mutated on held locks.
Mar 2 2021, 9:44 PM