- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 10 2021
Mar 9 2021
Long ago, we used to write a <package, commit> audit relationship with "AUDIT_NOT_REQUIRED", meaning "This commit affects the package, but package owners don't need to audit it.".
PhabricatorAuditStatusConstants appears to have a set of unused constants:
Mar 6 2021
Mar 5 2021
This is promoting to stable shortly and looks complete to me, thanks!
These contexts are covered:
Mar 4 2021
I dug up another one of these in PHI1439, but there is a lot of text in that issue that I haven't re-read yet.
Evidence increasingly suggests that the root problem here was GET_LOCK() issue in T13627, not an error in an sshd subprocess context.
I deployed this to the hosts affected by PHI2009 yesterday, and it appears to have resolved the problem.
Mar 3 2021
We might be able to detect that the --strategy-option theirs merge has done something suspicious by trying to merge C^ into the final state (or vice versa). If it merges cleanly, I think we can be fairly confident that the changes are actually independent. However, I'm not sure offhand what we could conclude if it doesn't merge cleanly.
A particular example is:
In the general case, the problem is that some invocations of arc, including arc land --pick A, may select an arbitrary range of commits to land which have some ancestors that we do NOT want to land.
git diff ...
- Address code review comments
Couple minor inlines, but looks good to me. I added you to Blessed Committers so you should be able to land this yourself -- see the description of that project for guidance, or let me know if you run into issues.
Broadly, I believe these "certain changes" are approximately changes which include a merge commit.