Page MenuHomePhabricator

When a GlobalLock with an external connection is released, don't return it to the pool
ClosedPublic

Authored by epriestley on Mar 2 2021, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 25, 10:30 PM
Unknown Object (File)
Tue, Jul 23, 10:27 AM
Unknown Object (File)
Fri, Jul 19, 1:32 PM
Unknown Object (File)
Mon, Jul 15, 3:10 PM
Unknown Object (File)
Wed, Jul 10, 8:33 AM
Unknown Object (File)
Tue, Jul 9, 9:36 PM
Unknown Object (File)
Sat, Jul 6, 1:21 AM
Unknown Object (File)
Wed, Jul 3, 1:56 AM
Subscribers
None

Details

Summary

Ref T13627. Currently, global locks always return connections (even external connections) to the connection pool when unlocked.

This code is obviously buggy: isExternalConnection is set to false immediately before it is tested. This bug has existed since this code was introduced, in D15792.

  • Instead of storing a flag, store the actual connection.
  • Don't clear it when unlocking.
  • Don't return external connections to the pool.
Test Plan
  • Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable