Page MenuHomePhabricator

When a GlobalLock with an external connection is released, don't return it to the pool
ClosedPublic

Authored by epriestley on Mar 2 2021, 8:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:29 AM
Unknown Object (File)
Sat, Dec 7, 2:13 PM
Unknown Object (File)
Thu, Dec 5, 10:39 AM
Unknown Object (File)
Sun, Dec 1, 12:42 PM
Unknown Object (File)
Sun, Dec 1, 12:42 PM
Unknown Object (File)
Sun, Dec 1, 12:42 PM
Unknown Object (File)
Sun, Dec 1, 12:42 PM
Unknown Object (File)
Wed, Nov 27, 8:24 PM
Subscribers
None

Details

Summary

Ref T13627. Currently, global locks always return connections (even external connections) to the connection pool when unlocked.

This code is obviously buggy: isExternalConnection is set to false immediately before it is tested. This bug has existed since this code was introduced, in D15792.

  • Instead of storing a flag, store the actual connection.
  • Don't clear it when unlocking.
  • Don't return external connections to the pool.
Test Plan
  • Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable