Page MenuHomePhabricator

Remove very old Audit status constants and AuditRequest data
ClosedPublic

Authored by epriestley on Mar 10 2021, 12:01 AM.

Details

Summary

Ref T13631. See that task for discussion.

  • "NONE": Probably never used?
  • "CC": Obsoleted by subscribers.
  • "AUDIT_NOT_REQUIRED": For Owners packages, obsoleted by edges.
  • "CLOSED": For "Close Audit", obsoleted by "Request Verification".
Test Plan
  • Grepped for constants, browsed Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 10 2021, 12:01 AM
src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php
52

After these changes, this just means "is not-resigned", and we already have "isResigned()" to test for that.

65–73

After these changes, all audit requests are "interesting".

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 5:22 PM
This revision was automatically updated to reflect the committed changes.