Page MenuHomePhabricator

Remove very old Audit status constants and AuditRequest data
ClosedPublic

Authored by epriestley on Mar 10 2021, 12:01 AM.
Tags
None
Referenced Files
F17621075: D21598.id51422.diff
Wed, Jul 9, 9:28 PM
Unknown Object (File)
Mon, Jun 16, 8:04 PM
Unknown Object (File)
Jun 3 2025, 8:52 PM
Unknown Object (File)
Jun 1 2025, 8:21 AM
Unknown Object (File)
May 1 2025, 8:49 PM
Unknown Object (File)
Apr 29 2025, 8:27 AM
Unknown Object (File)
Apr 25 2025, 1:08 AM
Unknown Object (File)
Apr 24 2025, 5:54 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13631. See that task for discussion.

  • "NONE": Probably never used?
  • "CC": Obsoleted by subscribers.
  • "AUDIT_NOT_REQUIRED": For Owners packages, obsoleted by edges.
  • "CLOSED": For "Close Audit", obsoleted by "Request Verification".
Test Plan
  • Grepped for constants, browsed Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 10 2021, 12:01 AM
src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php
52

After these changes, this just means "is not-resigned", and we already have "isResigned()" to test for that.

65–73

After these changes, all audit requests are "interesting".

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 5:22 PM
This revision was automatically updated to reflect the committed changes.