Page MenuHomePhabricator

Never return external connections to the GlobalLock connection pool
ClosedPublic

Authored by epriestley on Mar 2 2021, 9:33 PM.

Details

Summary

Ref T13627. If a lock fails, the connection may be returned to the pool, even if the connection is an external connection. Under old versions of MySQL, connection reuse can release other locks on the same connection.

Don't return external connections to the pool.

This issue was introduced in D21369.

Test Plan

Added a failing test and made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from Never return external locks to the GlobalLock connection pool to Never return external connections to the GlobalLock connection pool.Mar 2 2021, 9:38 PM
epriestley edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.