Page MenuHomePhabricator

Use the same icon for "Resigned" in Differential and Diffusion
ClosedPublic

Authored by epriestley on Mar 4 2021, 5:24 PM.

Details

Summary

See PHI2015. Currently, "resigned" reviewers/auditors get different icons in Differential and Diffusion.

The Diffusion icon is exceptionally poor and confusing: it does not communicate "resigned" and it is similar to other icons.

For clarity and consistency, use the Differential icon (a grey "X") in both applications.

Test Plan

Screen Shot 2021-03-04 at 9.21.32 AM.png (88×191 px, 8 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This icon originally dates from D6562.

Differential didn't have an icon until D17531, since "resigned" wasn't a distinct state until then.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 5:33 PM
This revision was automatically updated to reflect the committed changes.