Use the same icon for "Resigned" in Differential and Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 4 2021, 5:24 PM.

Details

Reviewers: None
Commits: rP9b6a030292d1: Use the same icon for "Resigned" in Differential and Diffusion

Summary

See PHI2015. Currently, "resigned" reviewers/auditors get different icons in Differential and Diffusion.

The Diffusion icon is exceptionally poor and confusing: it does not communicate "resigned" and it is similar to other icons.

For clarity and consistency, use the Differential icon (a grey "X") in both applications.

Test Plan

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

This icon originally dates from D6562.

Differential didn't have an icon until D17531, since "resigned" wasn't a distinct state until then.

epriestley requested review of this revision.Mar 4 2021, 5:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 5:33 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

audit/

constants/

8 lines