Page MenuHomePhabricator

Provide new tool "bin/user approve" to approve an account.
ClosedPublic

Authored by matthewrbowker on Mar 3 2021, 2:22 AM.

Details

Summary
Test Plan

This method uses the existing transaction. As such, most of the testing focused on the integration between the workflow and transaction. The only change made to the transaction was to allow an omnipotent user to make the change in addition to an admin.

Other than that, I removed the "approved" flag from the user, then ran the command-line utilty until the user was successfully approved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Couple minor inlines, but looks good to me. I added you to Blessed Committers so you should be able to land this yourself -- see the description of that project for guidance, or let me know if you run into issues.

src/applications/people/management/PhabricatorPeopleManagementApproveWorkflow.php
5

Mark this class as final.

16

"Approve a user." (with a period) is a little more consistent with other commands.

This revision is now accepted and ready to land.Mar 3 2021, 3:25 AM
  • Address code review comments