- Group Reviewers
- Maniphest Tasks
- T13578: Provide `bin/user approve` to approve an account from the CLI
- rPc0ac5be8a843: Provide new tool "bin/user approve" to approve an account.
- Required Signatures
L28 Phacility Individual Contributor License Agreement
This method uses the existing transaction. As such, most of the testing focused on the integration between the workflow and transaction. The only change made to the transaction was to allow an omnipotent user to make the change in addition to an admin.
Other than that, I removed the "approved" flag from the user, then ran the command-line utilty until the user was successfully approved.
Couple minor inlines, but looks good to me. I added you to Blessed Committers so you should be able to land this yourself -- see the description of that project for guidance, or let me know if you run into issues.
Mark this class as final.
"Approve a user." (with a period) is a little more consistent with other commands.