Provide new tool "bin/user approve" to approve an account.
ClosedPublic
Actions

Authored by matthewrbowker on Mar 3 2021, 2:22 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T13578: Provide `bin/user approve` to approve an account from the CLI

Commits

rPc0ac5be8a843: Provide new tool "bin/user approve" to approve an account.

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

T13578

Test Plan

This method uses the existing transaction. As such, most of the testing focused on the integration between the workflow and transaction. The only change made to the transaction was to allow an omnipotent user to make the change in addition to an admin.

Other than that, I removed the "approved" flag from the user, then ran the command-line utilty until the user was successfully approved.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

matthewrbowker created this revision.Mar 3 2021, 2:22 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 3 2021, 2:22 AM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

matthewrbowker requested review of this revision.Mar 3 2021, 2:22 AM

Harbormaster completed remote builds in B25197: Diff 51390.Mar 3 2021, 2:22 AM

matthewrbowker added a reviewer: epriestley.Mar 3 2021, 2:23 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 3 2021, 2:23 AM

Couple minor inlines, but looks good to me. I added you to Blessed Committers so you should be able to land this yourself -- see the description of that project for guidance, or let me know if you run into issues.