Diffusion Phabricator 2b473558c2b3

Refuse to acquire a second GlobalLock on a connection
2b473558c2b3
Actions

Description

Refuse to acquire a second GlobalLock on a connection

Summary:
Ref T13627. MySQL versions older than 5.7 release held locks when a new lock is acquired.

Prevent acquisition of a second lock to prevent this.

Test Plan: Added a failing unit test, made it pass.

Maniphest Tasks: T13627

Differential Revision: https://secure.phabricator.com/D21586

Details

Provenance

epriestley	Authored on Mar 2 2021, 8:58 PM
epriestley	Pushed on Mar 2 2021, 9:44 PM

Differential Revision

D21586: Refuse to acquire a second GlobalLock on a connection

Parents

rP466013f11a6d: Prevent external connections from being mutated on held locks

Branches

Unknown

Tags

Unknown

Tasks

T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock

Build Status

Buildable 25194
Build 34771: Run Core Tests

Event Timeline

epriestley committed rP2b473558c2b3: Refuse to acquire a second GlobalLock on a connection (authored by epriestley).Mar 2 2021, 9:44 PM

epriestley added a task: T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock.

epriestley added an edge: D21586: Refuse to acquire a second GlobalLock on a connection.

Harbormaster completed building B25194: rP2b473558c2b3: Refuse to acquire a second GlobalLock on a connection.Mar 2 2021, 9:46 PM

Changes (2)

Path

Size

src/

infrastructure/

util/

PhabricatorGlobalLock.php

__tests__/

PhabricatorGlobalLockTestCase.php

rP2b473558c2b3

View Options

src/infrastructure/util/PhabricatorGlobalLock.php