Allow "transaction.search" to be called on an object type
ClosedPublic
Actions

Authored by epriestley on Mar 10 2021, 6:13 PM.

Tags

None

Referenced Files

	F18203728: D21601.id51424.diff
	Mon, Aug 18, 12:44 PM

	F18106249: D21601.id51426.diff
	Sun, Aug 10, 10:02 PM

	F18103176: D21601.id.diff
	Sun, Aug 10, 2:33 AM

	F18098964: D21601.diff
	Sat, Aug 9, 12:10 AM

	F17637201: D21601.id51426.diff
	Jul 11 2025, 1:23 PM

	F17624269: D21601.id.diff
	Jul 10 2025, 1:39 AM

	F17603338: D21601.diff
	Jul 8 2025, 10:46 PM

	Unknown Object (File)
	Jun 18 2025, 6:57 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13631: Support an "auditors" attachment for "diffusion.commit.search"
Commits: rPafdef332fb20: Allow "transaction.search" to be called on an object type

Summary

Ref T13631. This supports a more robust version of "poll for updates by using dateModified window queries" that uses transactions as a logical clock.

This is particularly relevant for commits, since they don't have a "dateModified" at time of writing.

Test Plan

Queried for transactions by type and object.
Issued various invalid transaction queries, got appropriate errors.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 10 2021, 6:13 PM

Harbormaster completed remote builds in B25231: Diff 51424.Mar 10 2021, 6:14 PM

epriestley requested review of this revision.Mar 10 2021, 6:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 6:20 PM

Closed by commit rPafdef332fb20: Allow "transaction.search" to be called on an object type (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPafdef332fb20: Allow "transaction.search" to be called on an object type.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

conduit/

TransactionSearchConduitAPIMethod.php

124 lines

Diff 51426

View Options

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

Allow "transaction.search" to be called on an object typeClosedPublicActions