Page MenuHomePhabricator
Differential D21584

Prevent external connections from being mutated on held locks
ClosedPublic
Actions

Authored by epriestley on Mar 2 2021, 8:56 PM.
Tags
None
Referenced Files
F13521628: D21584.diff
Fri, Jul 26, 5:39 AM
Unknown Object (File)
Sun, Jul 21, 8:19 AM
Unknown Object (File)
Tue, Jul 16, 7:49 AM
Unknown Object (File)
Thu, Jul 4, 2:22 PM
Unknown Object (File)
Mon, Jul 1, 8:34 AM
Unknown Object (File)
Sun, Jun 30, 5:21 AM
Unknown Object (File)
Sat, Jun 29, 5:26 AM
Unknown Object (File)
Jun 25 2024, 12:16 PM
View All 81 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock
Commits
rP84049ed4793c: (stable) Prevent external connections from being mutated on held locks
rP466013f11a6d: Prevent external connections from being mutated on held locks
Summary

Ref T13627. This makes the API harder to misuse: setting an external connection on a held lock isn't a meaningful operation. Prevent it.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
2 lines
infrastructure/
storage/
management/
workflow/
2 lines
util/
15 lines
__tests__/
26 lines

Diff 51386

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
View Options

src/infrastructure/util/PhabricatorGlobalLock.php

Loading...
View Options

src/infrastructure/util/__tests__/PhabricatorGlobalLockTestCase.php

Loading...
Phabricator · Built by Phacility