Page MenuHomePhabricator

Prevent external connections from being mutated on held locks
ClosedPublic

Authored by epriestley on Mar 2 2021, 8:56 PM.
Tags
None
Referenced Files
F13360831: D21584.diff
Tue, Jun 25, 12:16 PM
F13354362: D21584.id51381.diff
Mon, Jun 24, 4:27 AM
F13333616: D21584.diff
Tue, Jun 18, 8:20 AM
F13324852: D21584.diff
Sat, Jun 15, 1:03 AM
F13312260: D21584.diff
Tue, Jun 11, 6:19 AM
F13298230: D21584.diff
Fri, Jun 7, 6:28 AM
F13260426: D21584.diff
Sun, May 26, 11:53 PM
F13242796: D21584.diff
May 23 2024, 3:06 AM
Subscribers
None

Details

Summary

Ref T13627. This makes the API harder to misuse: setting an external connection on a held lock isn't a meaningful operation. Prevent it.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable