Page MenuHomePhabricator
Differential D21584

Prevent external connections from being mutated on held locks
ClosedPublic
Actions

Authored by epriestley on Mar 2 2021, 8:56 PM.
Tags
None
Referenced Files
F15508841: D21584.diff
Wed, Apr 16, 6:47 AM
F15503828: D21584.id.diff
Mon, Apr 14, 1:26 PM
F15483646: D21584.id51386.diff
Wed, Apr 9, 1:40 PM
F15457904: D21584.diff
Sun, Mar 30, 7:59 PM
F15436443: D21584.id.diff
Tue, Mar 25, 2:11 PM
F15431269: D21584.diff
Mon, Mar 24, 11:27 AM
F15423894: D21584.diff
Sat, Mar 22, 7:17 PM
F15353813: D21584.diff
Mar 11 2025, 12:18 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13627: Until MySQL 5.7, each MySQL connection may hold only one simultaneous lock
Commits
rP84049ed4793c: (stable) Prevent external connections from being mutated on held locks
rP466013f11a6d: Prevent external connections from being mutated on held locks
Summary

Ref T13627. This makes the API harder to misuse: setting an external connection on a held lock isn't a meaningful operation. Prevent it.

Test Plan

Added a failing test, made it pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
2 lines
infrastructure/
storage/
management/
workflow/
2 lines
util/
15 lines
__tests__/
26 lines

Diff 51386

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
View Options

src/infrastructure/util/PhabricatorGlobalLock.php

Loading...
View Options

src/infrastructure/util/__tests__/PhabricatorGlobalLockTestCase.php

Loading...
Phabricator · Built by Phacility