Page MenuHomePhabricator
Feed All Stories

Jul 30 2019

epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 30 2019, 6:20 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:20 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 30 2019, 6:18 PM · Ops, Restricted Project, Phacility

Jul 24 2019

epriestley added a comment to D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.

Some recent change has disrupted this...

Jul 24 2019, 6:20 PM
epriestley requested review of D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.
Jul 24 2019, 6:15 PM
epriestley added a revision to T4900: Workboards updating in real time: D20681: Fix an issue where editing cards on a workboard with implicit column ordering could reorder cards improperly.
Jul 24 2019, 6:11 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

There's currently a bug (likely related to D20652 or D20654?) where normal edits aren't respecting card order correctly during the redraw. I suspect this is just an order parameter getting lost somewhere.

Jul 24 2019, 5:31 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20680: When a task card is edited, emit update events for old boards and parent boards.
Jul 24 2019, 5:31 PM
epriestley added a revision to T4900: Workboards updating in real time: D20680: When a task card is edited, emit update events for old boards and parent boards.
Jul 24 2019, 5:29 PM · Workboards (v3), User Delight, Wikimedia
jmeador awarded D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules a Y So Serious token.
Jul 24 2019, 5:11 PM
epriestley closed T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion as Resolved.

Everything has made it to master now so I suspect we're in good shape here.

Jul 24 2019, 5:04 PM · Auth
epriestley committed rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart… (authored by epriestley).
Tailor "Restart All Builds" for the complex realities of modern build restart…
Jul 24 2019, 4:26 PM
epriestley closed D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 4:25 PM
epriestley closed T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Resolved by committing rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart….
Jul 24 2019, 4:25 PM · Harbormaster
amckinley accepted D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 3:43 PM
epriestley requested review of D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 3:16 PM
epriestley added a revision to T13348: "Restart All Builds" is misleading in the presence of non-restartable builds: D20679: Tailor "Restart All Builds" for the complex realities of modern build restart rules.
Jul 24 2019, 3:14 PM · Harbormaster
epriestley committed rP99c864f5e6fb: Provide a basic detail view for user activity logs (authored by epriestley).
Provide a basic detail view for user activity logs
Jul 24 2019, 2:14 PM
epriestley closed D20674: Provide a basic detail view for user activity logs.
Jul 24 2019, 2:14 PM
epriestley committed rP60db658d52c4: Record account recovery email links in the user activity log and make the mail… (authored by epriestley).
Record account recovery email links in the user activity log and make the mail…
Jul 24 2019, 2:13 PM
epriestley closed D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Jul 24 2019, 2:13 PM
epriestley committed rP57799bc82bad: Give user log types a tokenizer and datasource instead of a page of checkboxes (authored by epriestley).
Give user log types a tokenizer and datasource instead of a page of checkboxes
Jul 24 2019, 2:11 PM
epriestley closed D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Jul 24 2019, 2:11 PM
epriestley committed rP32dd13d43421: Modularize user activity log message types (authored by epriestley).
Modularize user activity log message types
Jul 24 2019, 2:10 PM
epriestley closed D20671: Modularize user activity log message types.
Jul 24 2019, 2:10 PM
epriestley committed rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages (authored by epriestley).
Contain fallout from overheating feed queries on user profile pages
Jul 24 2019, 2:09 PM
epriestley closed D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 24 2019, 2:09 PM
epriestley closed T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Resolved by committing rP6831ed94faf6: Contain fallout from overheating feed queries on user profile pages.
Jul 24 2019, 2:09 PM · Feed
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Adjusting log_warnings = 2 in production (to get connection aborts into the error log) is also possibly desirable, although the background level of connection abortions (general network flakiness, server restarts during deploy, wait_timeout on very long-running demons?) may be high enough that this is more noise than signal.

Jul 24 2019, 2:03 PM · Ops, Restricted Project, Phacility
amckinley accepted D20674: Provide a basic detail view for user activity logs.
Jul 24 2019, 2:18 AM
amckinley accepted D20671: Modularize user activity log message types.
Jul 24 2019, 2:17 AM
amckinley accepted D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 24 2019, 2:14 AM

Jul 23 2019

epriestley requested review of D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 23 2019, 11:04 PM
epriestley added a revision to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core: D20678: Contain fallout from overheating feed queries on user profile pages.
Jul 23 2019, 11:03 PM · Feed
epriestley added a comment to T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core.

To reproduce this easily:

Jul 23 2019, 10:57 PM · Feed
epriestley triaged T13349: When the "FeedQuery" on user profile pages overheats, the event is not contained to the reactor core as Low priority.
Jul 23 2019, 10:47 PM · Feed
epriestley abandoned D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".

I'm likely going to propose some variation of this change, but focus it on max_allowed_packet and on emphasizing that there are two different copies of this setting with different error/failure behavior.

Jul 23 2019, 1:24 PM
epriestley triaged T13348: "Restart All Builds" is misleading in the presence of non-restartable builds as Normal priority.
Jul 23 2019, 1:18 PM · Harbormaster
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

We could also consider these things:

Jul 23 2019, 1:10 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

So actual actionable stuff here is:

Jul 23 2019, 1:04 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?) to During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
Jul 23 2019, 12:59 PM · Ops, Restricted Project, Phacility
artms committed rPcd449254256d: Allow users with no CAN_EDIT permissions to silence projects if they want to (authored by artms).
Allow users with no CAN_EDIT permissions to silence projects if they want to
Jul 23 2019, 10:14 AM
artms closed D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 23 2019, 10:14 AM

Jul 22 2019

epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Bumping max_allowed_packet to 1G in the server config resolved things. The export process then spent a long time doing a bin/files migration (which could use a progress bar, maybe) and is now doing a dump (which could too, although I'm less sure of how we'd build one).

Jul 22 2019, 11:52 PM · Ops, Restricted Project, Phacility
amckinley accepted D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Jul 22 2019, 11:00 PM
amckinley accepted D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Jul 22 2019, 10:59 PM
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.
190722 18:55:55 [Warning] Aborted connection 6 to db: '<instance>_differential' user: 'root' host: 'localhost' (Got a packet bigger than 'max_allowed_packet' bytes)
Jul 22 2019, 6:59 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I adjusted innodb_log_file_size to 1GB and attempted the import again, but ran into the same issue.

Jul 22 2019, 6:16 PM · Ops, Restricted Project, Phacility
epriestley planned changes to D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".

Let me hold this until I'm more confident I'm on the right track.

Jul 22 2019, 6:16 PM
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size" (?).
Jul 22 2019, 6:13 PM · Ops, Restricted Project, Phacility
epriestley added inline comments to D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Jul 22 2019, 5:08 PM
epriestley updated the summary of D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Jul 22 2019, 5:07 PM
epriestley requested review of D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Jul 22 2019, 5:06 PM
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: D20677: Provide import/restore guidance for "max_allowed_packet" and "innodb_log_file_size".
Jul 22 2019, 5:05 PM · Ops, Restricted Project, Phacility
epriestley added a revision to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting: Unknown Object (Differential Revision).
Jul 22 2019, 4:38 PM · Ops, Restricted Project, Phacility
epriestley renamed T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting from During MySQL import, server may "go away" on large dumps? to During MySQL import, server may "2006 MySQL server has gone away" when row data size is large relative to "innodb_log_file_size".
Jul 22 2019, 4:27 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

The "age of the last checkpoint" error appears to primarily implicate innodb_log_file_size, which is currently set to the default value (5MB):

Jul 22 2019, 4:26 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

I'll also double check wait_timeout and interactive_timeout...

Jul 22 2019, 4:01 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Aha! The MySQL error log actually appears to have something useful:

Jul 22 2019, 3:55 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Run it with source ...;

Jul 22 2019, 3:54 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Unzip the dump before running it.

Jul 22 2019, 3:45 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

Look at the unzipped dump and see if line 13935 is bad in some obvious way.

Jul 22 2019, 3:40 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Whatever the resolution is here might also motivate tailoring our restore/import instructions, since this error is pretty opaque and the next steps aren't obvious.)

Jul 22 2019, 3:21 PM · Ops, Restricted Project, Phacility
epriestley added a comment to T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting.

(Internally, see also PHI1329.)

Jul 22 2019, 3:18 PM · Ops, Restricted Project, Phacility
epriestley triaged T13347: During MySQL import, server may "2006 MySQL server has gone away" when "max_allowed_packet" server setting is too small, despite client setting as Low priority.
Jul 22 2019, 3:18 PM · Ops, Restricted Project, Phacility
epriestley accepted D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 22 2019, 2:13 PM
artms requested review of D20675: Allow users with no CAN_EDIT permissions to silence projects if they want to.
Jul 22 2019, 11:09 AM

Jul 20 2019

Krinkle awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Orange Medal token.
Jul 20 2019, 7:07 PM · Auth
Krinkle added a comment to T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang.

See also https://trac.wildfiregames.com/wiki/Phabricator#Downloadapatch where a tedious workaround is needed in order to apply patches to a mirror of an SVN repo that is updated once a day:

Jul 20 2019, 5:51 PM · Restricted Project, Arcanist

Jul 19 2019

aklapper awarded T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion a Love token.
Jul 19 2019, 11:07 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Not all of this has landed yet, but once it does:

Jul 19 2019, 10:55 PM · Auth
epriestley committed rP4fd473e7eda6: Remove explicit administrative actions from the user activity log (authored by epriestley).
Remove explicit administrative actions from the user activity log
Jul 19 2019, 10:46 PM
epriestley closed D20670: Remove explicit administrative actions from the user activity log.
Jul 19 2019, 10:46 PM
epriestley committed rP2ee5e71029af: Simplify implementation of "SysetemAction->getSystemActionConstant()" (authored by epriestley).
Simplify implementation of "SysetemAction->getSystemActionConstant()"
Jul 19 2019, 10:45 PM
epriestley closed D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()".
Jul 19 2019, 10:45 PM
epriestley committed rPa75766c0e501: Replace old rate limiting in password login flow with "SystemAction" rate… (authored by epriestley).
Replace old rate limiting in password login flow with "SystemAction" rate…
Jul 19 2019, 10:45 PM
epriestley closed D20668: Replace old rate limiting in password login flow with "SystemAction" rate limiting.
Jul 19 2019, 10:45 PM
epriestley committed rPe090b32c7528: Add a rate limit to requesting account recovery links from a given remote… (authored by epriestley).
Add a rate limit to requesting account recovery links from a given remote…
Jul 19 2019, 10:43 PM
epriestley closed D20667: Add a rate limit to requesting account recovery links from a given remote address.
Jul 19 2019, 10:43 PM
epriestley committed rP80294e7a4ad1: Add a rate limit to generating new account recovery links for a given account (authored by epriestley).
Add a rate limit to generating new account recovery links for a given account
Jul 19 2019, 10:42 PM
epriestley closed D20666: Add a rate limit to generating new account recovery links for a given account.
Jul 19 2019, 10:42 PM
epriestley committed rPced416cc735a: Allow Auth messages to have detailed descriptions and default values, then give… (authored by epriestley).
Allow Auth messages to have detailed descriptions and default values, then give…
Jul 19 2019, 10:39 PM
epriestley closed D20665: Allow Auth messages to have detailed descriptions and default values, then give "Email Login" both.
Jul 19 2019, 10:39 PM
Harbormaster failed to build B23170: rPa0c9f9f90c81: Allow installs to customize mail body guidance in the "Email Login" and "Set… for rPa0c9f9f90c81: Allow installs to customize mail body guidance in the "Email Login" and "Set…!
Jul 19 2019, 10:39 PM
epriestley committed rP38d30af362e6: Give "Auth Messages" a view/detail state before users customize them (authored by epriestley).
Give "Auth Messages" a view/detail state before users customize them
Jul 19 2019, 10:39 PM
epriestley closed D20664: Give "Auth Messages" a view/detail state before users customize them.
Jul 19 2019, 10:38 PM
epriestley committed rPa0c9f9f90c81: Allow installs to customize mail body guidance in the "Email Login" and "Set… (authored by epriestley).
Allow installs to customize mail body guidance in the "Email Login" and "Set…
Jul 19 2019, 10:37 PM
epriestley closed D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.
Jul 19 2019, 10:37 PM
epriestley added a comment to D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.

(Noted in T13346 before I land this and we forget about it.)

Jul 19 2019, 10:37 PM
epriestley triaged T13346: Make "bin/auth lock" also lock "Customize Messages" in Auth as Low priority.
Jul 19 2019, 10:36 PM · Auth
epriestley requested review of D20674: Provide a basic detail view for user activity logs.
Jul 19 2019, 10:32 PM
epriestley committed rP5dd489500155: Move "Password Reset" email to "PeopleMailEngine" (authored by epriestley).
Move "Password Reset" email to "PeopleMailEngine"
Jul 19 2019, 10:30 PM
epriestley closed D20662: Move "Password Reset" email to "PeopleMailEngine".
Jul 19 2019, 10:30 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20674: Provide a basic detail view for user activity logs.
Jul 19 2019, 10:30 PM · Auth
epriestley requested review of D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Jul 19 2019, 10:07 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20673: Record account recovery email links in the user activity log and make the mail message reference the log.
Jul 19 2019, 10:05 PM · Auth
epriestley requested review of D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Jul 19 2019, 9:53 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20672: Give user log types a tokenizer and datasource instead of a page of checkboxes.
Jul 19 2019, 9:51 PM · Auth
amckinley accepted D20670: Remove explicit administrative actions from the user activity log.
Jul 19 2019, 9:45 PM