Paths

Table of Contentst

Diffusion Phabricator 2ee5e71029af

Simplify implementation of "SysetemAction->getSystemActionConstant()"
2ee5e71029af
Actions

Description

Simplify implementation of "SysetemAction->getSystemActionConstant()"

Summary: Depends on D20668. Ref T13343. Just an easy cleanup/simplification while I'm here.

Test Plan: grep for getActionConstant()

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13343

Differential Revision: https://secure.phabricator.com/D20669

Details

Provenance

epriestley	Authored on Jul 19 2019, 5:26 PM
epriestley	Pushed on Jul 19 2019, 10:45 PM

Reviewer

amckinley

Differential Revision

D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()"

Parents

rPa75766c0e501: Replace old rate limiting in password login flow with "SystemAction" rate…

Branches

Unknown

Tags

Unknown

Tasks

T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion

Build Status

Buildable 23176
Build 31833: Run Core Tests

Event Timeline

epriestley committed rP2ee5e71029af: Simplify implementation of "SysetemAction->getSystemActionConstant()" (authored by epriestley).Jul 19 2019, 10:45 PM

epriestley added a task: T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

epriestley added an edge: D20669: Simplify implementation of "SysetemAction->getSystemActionConstant()".

Harbormaster completed building B23176: rP2ee5e71029af: Simplify implementation of "SysetemAction->getSystemActionConstant()".Jul 19 2019, 10:47 PM

Changes (13)

Path

Size

src/

applications/

auth/

action/

PhabricatorAuthChangePasswordAction.php

PhabricatorAuthEmailLoginAction.php

PhabricatorAuthNewFactorAction.php

PhabricatorAuthTestSMSAction.php

PhabricatorAuthTryEmailLoginAction.php

PhabricatorAuthTryFactorAction.php

PhabricatorAuthTryPasswordAction.php

PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php

files/

action/

PhabricatorFilesOutboundRequestAction.php

metamta/

action/

PhabricatorMetaMTAErrorMailAction.php

phortune/

action/

PhortuneAddPaymentMethodAction.php

settings/

action/

PhabricatorSettingsAddEmailAction.php

system/

action/

PhabricatorSystemAction.php

rP2ee5e71029af

View Options

src/applications/auth/action/PhabricatorAuthChangePasswordAction.php

View Options

src/applications/auth/action/PhabricatorAuthEmailLoginAction.php

View Options

src/applications/auth/action/PhabricatorAuthNewFactorAction.php

View Options

src/applications/auth/action/PhabricatorAuthTestSMSAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryEmailLoginAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryFactorAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryPasswordAction.php

View Options

src/applications/auth/action/PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php

View Options

src/applications/files/action/PhabricatorFilesOutboundRequestAction.php

View Options

src/applications/metamta/action/PhabricatorMetaMTAErrorMailAction.php

View Options

src/applications/phortune/action/PhortuneAddPaymentMethodAction.php

View Options

src/applications/settings/action/PhabricatorSettingsAddEmailAction.php

View Options

src/applications/system/action/PhabricatorSystemAction.php

Simplify implementation of "SysetemAction->getSystemActionConstant()"2ee5e71029afActions

Description

Details

Event Timeline

Changes (13)

rP2ee5e71029af

src/applications/auth/action/PhabricatorAuthChangePasswordAction.php

src/applications/auth/action/PhabricatorAuthEmailLoginAction.php

src/applications/auth/action/PhabricatorAuthNewFactorAction.php

src/applications/auth/action/PhabricatorAuthTestSMSAction.php

src/applications/auth/action/PhabricatorAuthTryEmailLoginAction.php

src/applications/auth/action/PhabricatorAuthTryFactorAction.php

src/applications/auth/action/PhabricatorAuthTryPasswordAction.php

src/applications/auth/action/PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php

src/applications/files/action/PhabricatorFilesOutboundRequestAction.php

src/applications/metamta/action/PhabricatorMetaMTAErrorMailAction.php

src/applications/phortune/action/PhortuneAddPaymentMethodAction.php

src/applications/settings/action/PhabricatorSettingsAddEmailAction.php

src/applications/system/action/PhabricatorSystemAction.php

Simplify implementation of "SysetemAction->getSystemActionConstant()"
2ee5e71029af
Actions