Page MenuHomePhabricator
Feed All Stories

Jul 19 2019

epriestley requested review of D20664: Give "Auth Messages" a view/detail state before users customize them.
Jul 19 2019, 4:04 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20664: Give "Auth Messages" a view/detail state before users customize them.
Jul 19 2019, 4:02 PM · Auth
epriestley added a comment to T13279: Build Charting for Facts.

Yeah, this is still in a transitional state, it's just been stalled for a bit (not blocked by anything, just other stuff has been getting attention). The two major issues I'm aware of right now are:

Jul 19 2019, 3:54 PM · Plans, Facts
Krinkle added a comment to T13279: Build Charting for Facts.

Not sure where to report this, but since a recent upgrade at Wikimedia, the new version of the Burnup Graph (now Reports: Burndown), has a tendency to go below zero. I'm aware the old version had inaccuracies so perhaps it was happening before as well but hidden (e.g. artificially replaced with zero or something like that).

Jul 19 2019, 3:32 PM · Plans, Facts
epriestley requested review of D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.
Jul 19 2019, 2:42 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20663: Allow installs to customize mail body guidance in the "Email Login" and "Set Password" emails.
Jul 19 2019, 2:41 PM · Auth
epriestley requested review of D20662: Move "Password Reset" email to "PeopleMailEngine".
Jul 19 2019, 2:18 PM
epriestley added a revision to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion: D20662: Move "Password Reset" email to "PeopleMailEngine".
Jul 19 2019, 2:17 PM · Auth
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Another general note is that we also require users go through this flow if they're setting a password for the first time on an account which does not already have a password. For example, this workflow will set up the "set your own password" flow:

Jul 19 2019, 1:10 PM · Auth
epriestley committed rPf55aac49f4d7: Rename "pastebin" database to "paste" (authored by epriestley).
Rename "pastebin" database to "paste"
Jul 19 2019, 12:53 PM
epriestley closed D20661: Rename "pastebin" database to "paste".
Jul 19 2019, 12:53 PM
amckinley accepted D20661: Rename "pastebin" database to "paste".
Jul 19 2019, 2:41 AM

Jul 18 2019

joshuaspence created P2121 bulk_move_columns.php.
Jul 18 2019, 10:34 PM
joshuaspence created P2120 ConduitIterator.php.
Jul 18 2019, 10:33 PM
epriestley committed rPcb4add311649: In Ferret, allow documents with no title to match query terms by using LEFT… (authored by epriestley).
In Ferret, allow documents with no title to match query terms by using LEFT…
Jul 18 2019, 5:37 PM
epriestley closed D20660: In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field.
Jul 18 2019, 5:37 PM
epriestley closed T13345: Ferret does not match documents with no title as Resolved by committing rPcb4add311649: In Ferret, allow documents with no title to match query terms by using LEFT….
Jul 18 2019, 5:37 PM · Search
epriestley requested review of D20661: Rename "pastebin" database to "paste".
Jul 18 2019, 5:36 PM
epriestley added a comment to D20650: Add Ferret support to Paste.

That wasn't as nearly as bad as I thought.

Jul 18 2019, 5:35 PM
amckinley accepted D20660: In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field.
Jul 18 2019, 5:27 PM
amckinley updated the task description for T13345: Ferret does not match documents with no title.
Jul 18 2019, 5:26 PM · Search
epriestley requested review of D20660: In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field.
Jul 18 2019, 5:23 PM
epriestley added a revision to T13345: Ferret does not match documents with no title: D20660: In Ferret, allow documents with no title to match query terms by using LEFT JOIN on the "title" ranking field.
Jul 18 2019, 5:22 PM · Search
epriestley triaged T13345: Ferret does not match documents with no title as Low priority.
Jul 18 2019, 5:16 PM · Search
epriestley added a comment to D20650: Add Ferret support to Paste.

..database names are a pain to change..

Jul 18 2019, 5:06 PM
epriestley added a comment to D20650: Add Ferret support to Paste.

(Also, "Pastebin" is the name of a product/company and our database name really shouldn't be pastebin, it just is since it was a contributed patch a million years ago and database names are a pain to change. This is basically like having a database named phabricator_yelp or whatever, though.)

Jul 18 2019, 5:02 PM
epriestley retitled D20650: Add Ferret support to Paste from Add Ferret support to Pastebin to Add Ferret support to Paste.
Jul 18 2019, 5:01 PM
epriestley committed rP17caecdda35d: Make workboard real-time updates mostly work (authored by epriestley).
Make workboard real-time updates mostly work
Jul 18 2019, 5:00 PM
epriestley closed D20656: Make workboard real-time updates mostly work.
Jul 18 2019, 5:00 PM
epriestley committed rP9ab5f59ca23c: Export "date" and "remarkup" custom fields to Excel + "zip" extension check (authored by epriestley).
Export "date" and "remarkup" custom fields to Excel + "zip" extension check
Jul 18 2019, 4:59 PM
epriestley closed D20658: Export "date" and "remarkup" custom fields to Excel + "zip" extension check.
Jul 18 2019, 4:59 PM
epriestley closed T13342: Support export of "date" and "remarkup" custom fields as Resolved by committing rP9ab5f59ca23c: Export "date" and "remarkup" custom fields to Excel + "zip" extension check.
Jul 18 2019, 4:59 PM · Custom Fields, Data Exporters
epriestley added a comment to D20650: Add Ferret support to Paste.

I'm a little uneasy about indexing the actual content, since I worry this will lead to a tragic event like "we learn that many installs routinely send 1GB logfiles consisting mostly of /dev/urandom output into Paste".

Jul 18 2019, 4:58 PM
epriestley triaged T13344: "Disable/Enable Provider" action in Auth does not entirely respect "auth.locked" setting as Low priority.
Jul 18 2019, 4:38 PM · Auth
epriestley accepted D20659: Modularize auth provider configuration.
Jul 18 2019, 4:32 PM
amckinley accepted D20658: Export "date" and "remarkup" custom fields to Excel + "zip" extension check.
Jul 18 2019, 4:14 PM
epriestley claimed T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Rough intentions here:

Jul 18 2019, 2:49 PM · Auth
am9obgo awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Jul 18 2019, 2:36 PM · Conpherence (v4)
d.maznekov edited the content of Organizations Using Phabricator.
Jul 18 2019, 6:35 AM

Jul 17 2019

aeiser added a comment to T13342: Support export of "date" and "remarkup" custom fields.

Trying to preserve markup format in the output is likely a road to mental ruin (Hyperlinking, referencing, bolding, formatting in who knows what export formats). PhabricatorStringExportField should be sufficient.

Jul 17 2019, 11:26 PM · Custom Fields, Data Exporters
amckinley added inline comments to D20659: Modularize auth provider configuration.
Jul 17 2019, 11:19 PM
amckinley requested review of D20659: Modularize auth provider configuration.
Jul 17 2019, 11:18 PM
epriestley requested review of D20658: Export "date" and "remarkup" custom fields to Excel + "zip" extension check.
Jul 17 2019, 10:59 PM
epriestley added a revision to T13342: Support export of "date" and "remarkup" custom fields: D20658: Export "date" and "remarkup" custom fields to Excel + "zip" extension check.
Jul 17 2019, 10:57 PM · Custom Fields, Data Exporters
epriestley added a comment to T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.

Potentially don't allow the "Send a login link to your email address" action at all if the corresponding Phab account is already only linked to external accounts for authentication and the installation does not use passwords? But I might lack technical understanding here.

Jul 17 2019, 10:47 PM · Auth
amckinley accepted D20656: Make workboard real-time updates mostly work.

howneatisthat

Jul 17 2019, 10:42 PM
aklapper updated the task description for T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.
Jul 17 2019, 10:36 PM · Auth
aklapper created T13343: Make "Send a login link to your email address" email include why it was sent to avoid confusion.
Jul 17 2019, 10:34 PM · Auth
epriestley added a comment to T13232: Mac OS X Mojave, SIP, Code Signing, and Apache.

We also need --enable-zip to get the zip extension, to get the ZipArchive class, so "Export to Excel" works. See upcoming change on T13342.

Jul 17 2019, 10:27 PM · Infrastructure
epriestley committed rPd02beaf8161a: Make reloading workboards with "R" respect workboard ordering (authored by epriestley).
Make reloading workboards with "R" respect workboard ordering
Jul 17 2019, 8:17 PM
epriestley closed D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 8:17 PM
epriestley committed rP8669c3c0d226: When updating a workboard with "R", send the client visible set with version… (authored by epriestley).
When updating a workboard with "R", send the client visible set with version…
Jul 17 2019, 8:16 PM
epriestley closed D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 8:16 PM
epriestley committed rP1ee6ecf39768: Move "BoardResponseEngine" toward a more comprehensive update model (authored by epriestley).
Move "BoardResponseEngine" toward a more comprehensive update model
Jul 17 2019, 8:13 PM
epriestley closed D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 8:13 PM
epriestley committed rPdb69686927bd: Make pressing "R" on your keyboard reload the card state on workboards (authored by epriestley).
Make pressing "R" on your keyboard reload the card state on workboards
Jul 17 2019, 8:11 PM
epriestley closed D20639: Make pressing "R" on your keyboard reload the card state on workboards.
Jul 17 2019, 8:11 PM
epriestley requested review of D20656: Make workboard real-time updates mostly work.
Jul 17 2019, 8:10 PM
epriestley added a revision to T4900: Workboards updating in real time: D20656: Make workboard real-time updates mostly work.
Jul 17 2019, 8:09 PM · Workboards (v3), User Delight, Wikimedia
epriestley retitled D20654: Make reloading workboards with "R" respect workboard ordering from Make reloading workboards with "R", respect workboard ordering to Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 8:07 PM
amckinley accepted D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 7:51 PM
amckinley accepted D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 7:44 PM
amckinley committed rP97c16997561b: Fix transaction title rendering for AuthenticationConfigs (authored by amckinley).
Fix transaction title rendering for AuthenticationConfigs
Jul 17 2019, 7:41 PM
amckinley closed D20655: Fix transaction title rendering for AuthenticationConfigs.
Jul 17 2019, 7:41 PM
epriestley accepted D20655: Fix transaction title rendering for AuthenticationConfigs.

This seems very likely to always work properly when we expect it to.

Jul 17 2019, 7:39 PM
amckinley requested review of D20655: Fix transaction title rendering for AuthenticationConfigs.
Jul 17 2019, 7:34 PM
epriestley moved T10696: Aphlict slowly grows to use an uncomfortably large amount of memory if the disk is full from vNext to Far Future on the Aphlict board.
Jul 17 2019, 6:30 PM · Aphlict, Phacility, Ops
epriestley moved T7013: Support bulk transmission of notification frames in internal Aphlict protocol from Backlog to Far Future on the Aphlict board.
Jul 17 2019, 6:29 PM · Aphlict, Conpherence
epriestley closed T10823: Aphlict admin server doesn't connect when SSL cert and key are supplied as Wontfix.

This is super old and doesn't have any apparent reproduction instructions.

Jul 17 2019, 6:29 PM · Aphlict, Bug Report
epriestley moved T12908: Allow verbosity of Aphlict log to be reduced from Backlog to Far Future on the Aphlict board.
Jul 17 2019, 6:28 PM · Aphlict, Feature Request
epriestley added a comment to T4900: Workboards updating in real time.

a logical clock to complement the wall-time clocks

Jul 17 2019, 6:25 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

From D20653:

Jul 17 2019, 6:15 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 6:05 PM
epriestley added a revision to T4900: Workboards updating in real time: D20654: Make reloading workboards with "R" respect workboard ordering.
Jul 17 2019, 6:04 PM · Workboards (v3), User Delight, Wikimedia
epriestley requested review of D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 5:54 PM
epriestley added a revision to T4900: Workboards updating in real time: D20653: When updating a workboard with "R", send the client visible set with version numbers.
Jul 17 2019, 5:53 PM · Workboards (v3), User Delight, Wikimedia
amckinley accepted D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:53 PM
epriestley requested review of D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:40 PM
epriestley added a revision to T4900: Workboards updating in real time: D20652: Move "BoardResponseEngine" toward a more comprehensive update model.
Jul 17 2019, 5:39 PM · Workboards (v3), User Delight, Wikimedia
epriestley triaged T13342: Support export of "date" and "remarkup" custom fields as Normal priority.
Jul 17 2019, 4:40 PM · Custom Fields, Data Exporters
arielyang edited the content of Organizations Using Phabricator.
Jul 17 2019, 4:36 PM

Jul 16 2019

Krinkle awarded T9044: arc diff eagerly detects git-svn repo, which makes arc-patch hang a Orange Medal token.
Jul 16 2019, 6:44 PM · Restricted Project, Arcanist
Krinkle awarded D20327: In remarkup, strip one leading space from each line in a quoted block if possible a Orange Medal token.
Jul 16 2019, 4:27 PM

Jul 15 2019

amckinley committed rP2f313a0e0d55: Remove "unstable" status and T2784-specific warning message (authored by amckinley).
Remove "unstable" status and T2784-specific warning message
Jul 15 2019, 9:05 PM
amckinley closed D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:05 PM
epriestley accepted D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:04 PM
amckinley requested review of D20651: Remove "unstable" status and T2784-specific warning message.
Jul 15 2019, 9:04 PM
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Oh, sorry, I misread which half you were asking about.

Jul 15 2019, 8:53 PM · Restricted Project, Auth, Conduit
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Am I going crazy, or do those methods only handle the "blob fetching" part of this equation? I was looking for examples of the "create a File, do a chunked upload, attach said File to an existing object" flow.

Jul 15 2019, 8:28 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Yeah, diffusion.rawdiffquery and diffusion.filecontentquery both do this.

Jul 15 2019, 8:18 PM · Restricted Project, Auth, Conduit
amckinley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

For uploading binary blobs, we'd do the reverse: have the client stream the blob into Files, then call an API method with a reference to the object.

Jul 15 2019, 8:16 PM · Restricted Project, Auth, Conduit
amckinley requested review of D20650: Add Ferret support to Paste.
Jul 15 2019, 7:44 PM
amckinley committed rP7852adb84bbe: Actually enforce auth.lock-config (authored by amckinley).
Actually enforce auth.lock-config
Jul 15 2019, 6:53 PM
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI, a subtask of T6755: Allow more granular configuration of `security.allow-outbound-http`, as Resolved.
Jul 15 2019, 6:53 PM · Security
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI as Resolved by committing rP7852adb84bbe: Actually enforce auth.lock-config.
Jul 15 2019, 6:53 PM · Auth, Security
amckinley closed D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:53 PM
amckinley updated the diff for D20645: Actually enforce auth.lock-config.

Pop a dialog instead of navigating away.

Jul 15 2019, 6:51 PM
amckinley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:50 PM
epriestley triaged T13341: Phacility/Phortune invoice email merchant behavior changed circa June 22 as Low priority.
Jul 15 2019, 6:42 PM · Phortune, Phacility
epriestley added inline comments to D20645: Actually enforce auth.lock-config.
Jul 15 2019, 6:41 PM