Jun 20 2019
(Build failure is just D20599 landing out-of-order, oops.)
I just ran into this for the first time:
I've also never seen anyone use kill -TERM `cat /path/to/pidfile` in real life over some flavor of pkill, which is basically the same thing as "pattern match the process titles".
provided I'm not missing some secret reason to retain PID files.
Pick up changes from D20594.
I've marked D20604 as resolving this; it does so by making bin/phd status report local process status only. I strongly suspect that this is probably a better / less confusing behavior.
- "DEAMONS" -> "DAEMONS"
One inline thing, but the rest of this looks correct as far as I can tell.
Rename some variables for clarity.
- Renamed classes to remove Configuration
- Created PhabricatorApplicationTransactionJSONDiffDetailView to reduce JSON-related boilerplate
- Found one callsite to switch to PhabricatorApplicationTransactionJSONDiffDetailView
- Implemented getTitle for the various JSON-encoded transactions
- Requested fixes
I have a patch for this which basically says "don't try to kill any process which doesn't look like a daemon process".
No wonder I couldn't pass the Facebook eng interview!!
We've run instances in the Phacility cluster for a long time now, but this is generally not something we really support or plan to support since there's no real customer interest in instancing Phabricator.
Builds have a hard dependency on D20597.
The power is in my hands, now.
But wait! It says there are two ways! The other way is:
If you are just writing an upstart job that needs to start the service after the basic facilities are up, either of these will work:
start on (local-filesystems and net-device-up IFACE!=lo)
This was effectively resolved in 2019 Week 17 (Very Late April). Now, only ancestors of "Permanent Refs" trigger any publishing behavior (audits, notifications, feed, etc).
This is very old and it doesn't look like we ever found a working set of reproduction steps.
To avoid the extreme case of ComComComJava-itis we could maybe just drop the word Configuration from these classes?
To avoid the extreme case of ComComComJava-itis we could maybe just drop the word Configuration from these classes? No other type of EditEngine ... Transaction is ever likely to exist or make sense.
Jun 19 2019
the (Show Details) would be a great first step for us - and cover our needs. Much like the logs for Herald Rules and other areas.