Page MenuHomePhabricator
Feed All Stories

Sep 11 2018

epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 5:07 PM · Plans, Phriction
epriestley added a comment to T5811: Phriction does not correctly save and restore document drafts of in-progress edits.
  • This feature was originally added in D1378.
  • This feature was accidentally broken by D11169.
  • In D19661, I removed the nonfunctional remnants of D1378.
Sep 11 2018, 4:44 PM · Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 4:39 PM · Plans, Phriction
epriestley added a revision to T5811: Phriction does not correctly save and restore document drafts of in-progress edits: Unknown Object (Differential Revision).
Sep 11 2018, 4:39 PM · Phriction
epriestley added a revision to T1894: Support commenting on Phriction documents: Unknown Object (Differential Revision).
Sep 11 2018, 3:40 PM · Restricted Project, Restricted Project, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 3:40 PM · Plans, Phriction
kerberizer awarded T1894: Support commenting on Phriction documents a Like token.
Sep 11 2018, 3:19 PM · Restricted Project, Restricted Project, Phriction
epriestley added a revision to T1894: Support commenting on Phriction documents: Unknown Object (Differential Revision).
Sep 11 2018, 3:15 PM · Restricted Project, Restricted Project, Phriction
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Sep 11 2018, 3:15 PM · Plans, Phriction
epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 11 2018, 3:06 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:52 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:22 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:14 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 11 2018, 2:05 PM · Plans
pouyana added a comment to T8656: Parse ANSI-style color strings in build output.

I wrote a patch for this, for both new log prototype and old log viewer here some screenshots for the view. If it is look OK, I will submit it.

Sep 11 2018, 9:32 AM · Haskell.org, Restricted Project, Harbormaster
epriestley closed T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes as Resolved.

This is now live.

Sep 11 2018, 12:52 AM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

Deploying the changes to web now.

Sep 11 2018, 12:48 AM · Ops, Phacility

Sep 10 2018

epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 10 2018, 9:43 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 9:34 PM · Plans
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

I've issued all instances a 24-hour service credit for the disruption. This should be reflected on your next invoice.

Sep 10 2018, 9:17 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

Here's the request rate leading up to the rate limiting:

Sep 10 2018, 9:11 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

D19653 (above) changes the per-"Host" rate limit to require "X-Forwarded-For" be present in the request. This should exempt ELB requests from these limits.

Sep 10 2018, 8:55 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.
...
[Mon Sep 10 20:48:43.928021 2018] [:error] [pid 21570] [client 172.30.0.171:16516] Array\n(\n    [f] => \n    [h] => 172.30.0.60\n)\n
...
Sep 10 2018, 8:51 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

... in production today as a next step.

Sep 10 2018, 8:46 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

This should have the pleasant side effect of letting us drop the goofy hard-coded internal rate limiting IP list.

Sep 10 2018, 8:44 PM · Ops, Phacility
epriestley added a comment to T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes.

There are four rate limits, and I don't currently have enough information to figure out which one triggered. The rate limits are:

Sep 10 2018, 8:41 PM · Ops, Phacility
epriestley triaged T13199: All "web" host rate limited ELB `/status/` requests simultaneously after 11 months without configuration changes as High priority.
Sep 10 2018, 8:25 PM · Ops, Phacility
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 7:50 PM · Plans
epriestley added a comment to T13197: 2018 Week 37 Bonus Content.

The remaining work on the audit constants is:

Sep 10 2018, 7:19 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 7:11 PM · Plans
epriestley added a revision to T13197: 2018 Week 37 Bonus Content: Unknown Object (Differential Revision).
Sep 10 2018, 6:44 PM · Plans
epriestley added a comment to T13198: Consider an "arc prompts" or similar, to improve automation on top of "arc".

See also PHI862 for a request for arc amend --force.

Sep 10 2018, 3:25 PM · Arcanist, Plans
epriestley triaged T13198: Consider an "arc prompts" or similar, to improve automation on top of "arc" as Normal priority.
Sep 10 2018, 3:24 PM · Arcanist, Plans
• GoogleLegacy added a comment to T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.
Sep 10 2018, 9:48 AM · Differential, Audit
• GoogleLegacy added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.
Sep 10 2018, 9:47 AM · Restricted Project, User Delight, Maniphest
• GoogleLegacy added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).
Sep 10 2018, 9:46 AM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
• GoogleLegacy added a comment to T5811: Phriction does not correctly save and restore document drafts of in-progress edits.
Sep 10 2018, 9:45 AM · Phriction
• GoogleLegacy added a comment to T7303: Provide OAuth access to Conduit.
Sep 10 2018, 9:44 AM · Restricted Project, Conduit, Restricted Project
• GoogleLegacy added a comment to T9303: Improve Phacility Onboarding/NUX.
Sep 10 2018, 9:44 AM · Phacility
• GoogleLegacy added a comment to T4316: Allow a comment to be added on the Maniphest edit interface.
Sep 10 2018, 9:43 AM · Maniphest
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:40 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:39 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to T7429: Update tour screenshots on dot org.
Sep 10 2018, 9:35 AM · Public & Media Relations
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:32 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to 5 Years .
Sep 10 2018, 9:31 AM
• GoogleLegacy added a comment to T9304: Workflow for inviting new users to a Phacility instance is unnecessarily confusing.
Sep 10 2018, 9:20 AM · Phacility
• GoogleLegacy added a comment to T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.
Sep 10 2018, 9:19 AM · Phortune, Phacility
• GoogleLegacy added a comment to T9690: Remove calls to methods deprecated by newPage().
Sep 10 2018, 9:18 AM · Contributor Onboarding, Modernization, Infrastructure
• GoogleLegacy added a comment to T7303: Provide OAuth access to Conduit.
Sep 10 2018, 9:17 AM · Restricted Project, Conduit, Restricted Project
• GoogleLegacy added a comment to T10034: Plan the future of Maniphest task relationships.
Sep 10 2018, 9:10 AM · Maniphest
• GoogleLegacy added a comment to T10187: hard to understand status of sub-tasks from parent.
Sep 10 2018, 9:09 AM · Restricted Project, Maniphest
• GoogleLegacy added a comment to T7804: Implement an "Acting User" Herald condition.
Sep 10 2018, 9:06 AM · Restricted Project, Herald, Mail
• GoogleLegacy added a comment to T8726: Modularize Herald fields and actions.
Sep 10 2018, 9:06 AM · Herald
• GoogleLegacy added a comment to T9054: Undefined class constant ACTION_BLOCK.
Sep 10 2018, 9:05 AM · Herald
• GoogleLegacy added a comment to T13057: Formalize "reverts" and "resurrects" between revisions.
Sep 10 2018, 8:41 AM · Differential

Sep 8 2018

epriestley edited the content of Changelog.
Sep 8 2018, 11:53 AM
epriestley created 2018 Week 36 (Mid September).
Sep 8 2018, 11:52 AM
epriestley updated the task description for T13197: 2018 Week 37 Bonus Content.
Sep 8 2018, 11:46 AM · Plans
epriestley closed T13195: 2018 Week 36 Bonus Content as Resolved.
Sep 8 2018, 1:05 AM · Plans
epriestley triaged T13197: 2018 Week 37 Bonus Content as Normal priority.
Sep 8 2018, 1:05 AM · Plans

Sep 7 2018

epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 7:21 PM · Plans
epriestley closed T8573: All reviewers should be allowed to mark a comment as done, a subtask of T1460: Add "Done" link to an inline comment, as Resolved.
Sep 7 2018, 6:18 PM · User Delight, Differential
epriestley closed T8573: All reviewers should be allowed to mark a comment as done as Resolved by committing Restricted Diffusion Commit.
Sep 7 2018, 6:18 PM · Restricted Project, Differential, Restricted Project
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 7 2018, 4:53 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 7 2018, 4:53 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 4:53 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 4:05 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 3:37 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 7 2018, 3:07 PM · Plans
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Sep 7 2018, 3:05 PM · Plans, Harbormaster
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 7 2018, 3:04 PM · Plans

Sep 6 2018

epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

See PHI860 and T13111. In the future, repository nodes may automatically gc/prune/repack. If they do, it may make sense to sort them to the bottom of the list so traffic is sent to them only if no other nodes are available, in order to minimize the impact that gc/prune/repack have on other activity.

Sep 6 2018, 6:43 PM · Clusters
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

PHI860 is a close variant of this and discusses periodically running git repack. Most concerns around git repack are likely similar to concerns around gc and prune.

Sep 6 2018, 6:42 PM · Phacility, Diffusion
epriestley added a comment to T3130: Improve recognition of symbols in Java.

D19637 doesn't actually improve this, but it brings us a step closer (since the logic is now in PHP and can be modified more easily to label symbols and add context).

Sep 6 2018, 5:35 PM · Symbols, libphutil
avivey changed the visibility for T3130: Improve recognition of symbols in Java.
Sep 6 2018, 5:34 PM · Symbols, libphutil
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 6 2018, 1:30 PM · Plans

Sep 5 2018

epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 8:49 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 5:32 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 5:11 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 5 2018, 4:34 PM · Plans
epriestley added a comment to T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine .

Yes. The diff is a relatively small amount of the work I must do to respond to this issue: install ElasticSearch, configure it in the way you describe, reproduce the issue, write or apply a change, verify it actually fixes the problem, go read through the documentation enough that I'm confident the fix is the best available fix and that we've understood the issue reasonably well.

Sep 5 2018, 4:28 PM · Search, Elasticsearch
Pawka added a comment to T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine .

Even if I'd provide the diff?

Sep 5 2018, 4:16 PM · Search, Elasticsearch
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Sep 5 2018, 3:54 PM · Arcanist, Plans
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
Sep 5 2018, 3:29 PM · Arcanist, Plans
epriestley renamed T13077: Plans: Phriction modern "v3" APIs, Drafts from Plans: Phriction modern "v3" APIs to Plans: Phriction modern "v3" APIs, Drafts.
Sep 5 2018, 2:35 PM · Plans, Phriction
epriestley added a comment to T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine .

(Just to set expectations, anything which isn't coming in through Support Pacts may take a very long time for us to get to.)

Sep 5 2018, 2:27 PM · Search, Elasticsearch
epriestley moved T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction from Tentative to Soon on the Plans board.
Sep 5 2018, 1:34 PM · Plans, Ops, Infrastructure, Phacility
epriestley moved T13195: 2018 Week 36 Bonus Content from Backlog to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Plans
epriestley moved T13178: Plans: Support Pact Competitive Update from Backlog to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Plans, Support, Phacility
epriestley moved T13098: Plans: Arcanist toolsets and extensions from Tentative to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Arcanist, Plans
epriestley moved T13077: Plans: Phriction modern "v3" APIs, Drafts from Future to Soon on the Plans board.
Sep 5 2018, 1:33 PM · Plans, Phriction
Pawka triaged T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine as Normal priority.
Sep 5 2018, 6:09 AM · Search, Elasticsearch

Sep 4 2018

epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 9:51 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 9:45 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 9:20 PM · Plans
epriestley added a revision to T3130: Improve recognition of symbols in Java: Unknown Object (Differential Revision).
Sep 4 2018, 9:01 PM · Symbols, libphutil
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 9:01 PM · Plans
epriestley added a revision to T13195: 2018 Week 36 Bonus Content: Unknown Object (Differential Revision).
Sep 4 2018, 7:50 PM · Plans
epriestley updated the task description for T13195: 2018 Week 36 Bonus Content.
Sep 4 2018, 7:35 PM · Plans
epriestley updated the task description for T13083: Plans: Portals and Facts.
Sep 4 2018, 7:34 PM · Plans, Facts, Dashboards