Page MenuHomePhabricator
Create Task
Maniphest T13197

2018 Week 37 Bonus Content
Closed, ResolvedPublic
Actions

Description

See PHI847, which requests better logging from RepositoryOperation. A RepositoryOperationLog is likely reasonable.

See https://discourse.phabricator-community.org/t/cant-see-commits-at-a-newly-created-phabricator/1869/10. Some of the documentation has unpublished itself.

See PHI841, which would like author and committer information exposed via diffusion.commit.search.

See PHI851. diffusion.commit.search should accept string constants (not numeric constants) for the statuses constraint.

See PHI871, which requests better accessibility section headers.

Revisions and Commits

rP Phabricator
D19674rP0167f357b723 Provide a convenient way to log arbitrary text in Drydock without needing…
D19673rPa7e060f062e0 Write a trivial log when starting a repository operation
D19672rP92bcf859747d Add Drydock logs to the RepositoryOperation UI
D19671rP10f219fb8277 Allow Drydock logs to be associated with RepositoryOperation objects
D19670rP40d5d5c9848e Remove "mailKey" from "PhabricatorRepositoryCommit"
D19669rP2ddc770fd881 Update Phriction documentation for drafts
D19668rP0abf29765e05 Make Phriction diff-of-changes view draft-aware and clarify some language
D19665rPf5e90a363e7a When a user takes actions while in a high security session, note it on the…
D19658rP8268abcb7880 Enrich "diffusion.commit.search" with identity, status, and message information
D19657rPc7e7b63f155f Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"…
D19656rPaaf22695515a Remove legacy numeric Audit status constants
D19655rPd63281cc549e Migrate remaining Audit database status constants
D19652rP09703938fb44 Migrate old commit saved queries to new audit status constants
D19654rP185e72c881cf Add aural section headers for "Event Timeline", "Add Comment", and "Comment…
D19651rP8eb8e8e1d86f Make DiffusionCommitSearch accept modern (string) constants
D19650rP853a816b3caf Continue converting Audit constants, allowing the Query to handle either…

Event Timeline

epriestley triaged this task as Normal priority.Sep 8 2018, 1:05 AM
epriestley created this task.
Herald added a subscriber: faulconbridge. · View Herald TranscriptSep 8 2018, 1:05 AM
epriestley updated the task description. (Show Details)Sep 8 2018, 11:46 AM
epriestley added a revision: D19650: Continue converting Audit constants, allowing the Query to handle either strings or integers.Sep 10 2018, 6:44 PM
epriestley added a revision: D19651: Make DiffusionCommitSearch accept modern (string) constants.Sep 10 2018, 7:11 PM
epriestley added a comment.Sep 10 2018, 7:19 PM

The remaining work on the audit constants is:

  • Migrate stored searches (not technically required, but nice for completeness).
  • Change transaction values and migrate transactions.
  • Change object values and migrate objects.
  • Rename PhabricatorAuditCommitStatusConstants to PhabricatorAuditCommitStatus.
  • Get rid of the old constants.
  • Rename away the MODERN_ constant tags.
epriestley added a revision: D19652: Migrate old commit saved queries to new audit status constants.Sep 10 2018, 7:50 PM
epriestley added a revision: D19654: Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview".Sep 10 2018, 9:34 PM
epriestley updated the task description. (Show Details)Sep 10 2018, 9:43 PM
epriestley added a commit: rP853a816b3caf: Continue converting Audit constants, allowing the Query to handle either….Sep 10 2018, 9:46 PM
epriestley added a commit: rP8eb8e8e1d86f: Make DiffusionCommitSearch accept modern (string) constants.Sep 10 2018, 11:25 PM
epriestley added a revision: D19655: Migrate remaining Audit database status constants.Sep 11 2018, 2:05 PM
epriestley added a revision: D19656: Remove legacy numeric Audit status constants.Sep 11 2018, 2:14 PM
epriestley added a revision: D19657: Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"; remove "MODERN_".Sep 11 2018, 2:22 PM
epriestley added a revision: D19658: Enrich "diffusion.commit.search" with identity, status, and message information.Sep 11 2018, 2:52 PM
epriestley updated the task description. (Show Details)Sep 11 2018, 3:06 PM
epriestley updated the task description. (Show Details)Sep 11 2018, 8:29 PM
epriestley added a commit: rP185e72c881cf: Add aural section headers for "Event Timeline", "Add Comment", and "Comment….Sep 11 2018, 8:30 PM
epriestley added a revision: D19665: When a user takes actions while in a high security session, note it on the resulting transactions.Sep 11 2018, 8:53 PM
epriestley added a commit: rP09703938fb44: Migrate old commit saved queries to new audit status constants.Sep 12 2018, 7:21 PM
epriestley added a commit: rPd63281cc549e: Migrate remaining Audit database status constants.
epriestley added a commit: rPaaf22695515a: Remove legacy numeric Audit status constants.Sep 12 2018, 7:41 PM
epriestley added a commit: rPc7e7b63f155f: Rename "PhabricatorAuditCommitStatusConstants" to "DiffusionCommitAuditStatus"….Sep 12 2018, 7:44 PM
epriestley added a commit: rP8268abcb7880: Enrich "diffusion.commit.search" with identity, status, and message information.
epriestley added a commit: rPf5e90a363e7a: When a user takes actions while in a high security session, note it on the….Sep 12 2018, 7:57 PM
epriestley added a revision: D19668: Make Phriction diff-of-changes view draft-aware and clarify some language.Sep 13 2018, 3:33 PM
epriestley added a revision: D19669: Update Phriction documentation for drafts.Sep 13 2018, 4:12 PM
epriestley added a commit: rP0abf29765e05: Make Phriction diff-of-changes view draft-aware and clarify some language.Sep 13 2018, 9:12 PM
epriestley added a commit: rP2ddc770fd881: Update Phriction documentation for drafts.Sep 13 2018, 9:16 PM
epriestley added a revision: D19670: Remove "mailKey" from "PhabricatorRepositoryCommit".Sep 14 2018, 1:27 PM
epriestley added a revision: D19671: Allow Drydock logs to be associated with RepositoryOperation objects.Sep 14 2018, 1:39 PM
epriestley added a revision: D19672: Add Drydock logs to the RepositoryOperation UI.Sep 14 2018, 1:50 PM
epriestley added a revision: D19673: Write a trivial log when starting a repository operation.Sep 14 2018, 4:12 PM
epriestley added a revision: D19674: Provide a convenient way to log arbitrary text in Drydock without needing structured log classes.Sep 14 2018, 4:25 PM
epriestley updated the task description. (Show Details)Sep 14 2018, 5:01 PM
epriestley added a commit: rP40d5d5c9848e: Remove "mailKey" from "PhabricatorRepositoryCommit".Sep 15 2018, 2:54 PM
epriestley added a commit: rP10f219fb8277: Allow Drydock logs to be associated with RepositoryOperation objects.
epriestley added a commit: rP92bcf859747d: Add Drydock logs to the RepositoryOperation UI.Sep 15 2018, 2:56 PM
epriestley added a commit: rPa7e060f062e0: Write a trivial log when starting a repository operation.
epriestley added a commit: rP0167f357b723: Provide a convenient way to log arbitrary text in Drydock without needing….Sep 15 2018, 2:59 PM
epriestley closed this task as Resolved.Sep 18 2018, 3:00 AM
Phabricator · Built by Phacility