Page MenuHomePhabricator
Feed All Stories

Nov 9 2017

• tinytiongson created E1668: Beach.
Nov 9 2017, 2:39 PM
• tinytiongson created E1667: ASEAN Summit.
Nov 9 2017, 2:38 PM

Nov 8 2017

rbalik awarded T5391: Support custom fields in 'Export to Excel' a Like token.
Nov 8 2017, 5:27 PM · Data Exporters
rbalik added a comment to T5391: Support custom fields in 'Export to Excel'.

We need something like this too because the exporter doesn't include points at the moment.

Nov 8 2017, 5:27 PM · Data Exporters
maxim.efremoff added a watcher for OAuthServer: maxim.efremoff.
Nov 8 2017, 10:34 AM
Twilight added a comment to T8883: Allow desktop notifications to replace normal notifications.

Could this be closed now that Phab supports this? (in /settings/user/Username/page/notifications/)

Nov 8 2017, 3:27 AM · Notifications

Nov 7 2017

epriestley edited the content of Changelog.
Nov 7 2017, 11:57 PM
epriestley created 2017 Week 44 (Early November).
Nov 7 2017, 11:56 PM
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

(Another possibility is to add behavior to arc to control this.)

Nov 7 2017, 1:50 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Maybe. Another possibility is to mark builds as "nonblocking" in some sense. There are some other open requests for defining "advisory" or "noncritical" builds where build failure doesn't cause the Buildable to report a failed result overall. If we end up adding this state to builds anyway, it probably makes sense to include a "Does Not Block Review" flag to the "Does Not Fail Buildable" / "Does Not Block Dependent Builds" / "Failure Is Totally Meaningless" / Whatever flags.

Nov 7 2017, 1:28 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Nov 7 2017, 1:17 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
jmeador added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

The harbormaster builds that we have running on revision creation can sometimes be rather slow; they're builds in our primary CI system, but with less of a priority than jobs in the submit queue. This will result in 10-30 minute delays for every revision in our monorepo. I understand the preference for only adding configuration settings when absolutely necessary, but since this may result in a significant time sink for any installs with expensive builds, is it worth keeping something around like differential.initial-state?

Nov 7 2017, 7:31 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Nov 6 2017

pouyana added a comment to T12856: Evaluate various "infrastructure-as-code" products.

For any body still interested, the project was in PHP, I had to rewrite in go, so it can be used elsewhere.

Nov 6 2017, 1:18 PM · Ops, Phacility
richardvanvelzen edited P2078 arc-unit-sorting.
Nov 6 2017, 12:37 PM
petr.biza awarded T9720: Provide a way to link to Diffusion files a Like token.
Nov 6 2017, 10:46 AM · Restricted Project, Remarkup

Nov 2 2017

epriestley closed T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review" as Resolved by committing Restricted Diffusion Commit.
Nov 2 2017, 12:20 AM · Differential

Nov 1 2017

epriestley added a revision to T12689: Mail is still received after resigning from a revision: Unknown Object (Differential Revision).
Nov 1 2017, 6:12 PM · Mail, Differential, Bug Report
epriestley updated the task description for T12689: Mail is still received after resigning from a revision.
Nov 1 2017, 6:10 PM · Mail, Differential, Bug Report
epriestley merged T7704: Rejecting then accepting a revision with blocking reviewers doesn't correctly change state into T12920: Retracting requested changes can leave revision in "Needs Revision" state.
Nov 1 2017, 6:05 PM · Restricted Project, Differential, Bug Report
epriestley merged task T7704: Rejecting then accepting a revision with blocking reviewers doesn't correctly change state into T12920: Retracting requested changes can leave revision in "Needs Revision" state.
Nov 1 2017, 6:05 PM · Restricted Project, Differential
epriestley added a comment to T12920: Retracting requested changes can leave revision in "Needs Revision" state.

Pretty sure T7704 is the same as this.

Nov 1 2017, 6:05 PM · Restricted Project, Differential, Bug Report
epriestley added a revision to T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review": Unknown Object (Differential Revision).
Nov 1 2017, 6:00 PM · Differential
epriestley updated the task description for T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review".
Nov 1 2017, 5:57 PM · Differential
epriestley added a revision to T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review": Unknown Object (Differential Revision).
Nov 1 2017, 5:50 PM · Differential
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 1 2017, 5:37 PM · Phacility

Oct 31 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 31 2017, 6:53 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 31 2017, 5:36 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley edited the content of Changelog.
Oct 31 2017, 5:23 PM
epriestley created 2017 Week 43 (Very Late October).
Oct 31 2017, 5:22 PM
epriestley added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

PHI181 has an entangling concern (T11372).

Oct 31 2017, 4:37 PM · Diffusion, Restricted Project
epriestley closed T13011: Let community to fund features and bug fixes for increased priority and earlier delivery, a subtask of T8552: Increase user control over document hierarchy in Phriction, as Wontfix.
Oct 31 2017, 2:47 PM · Phriction, Restricted Project
epriestley closed T13011: Let community to fund features and bug fixes for increased priority and earlier delivery as Wontfix.

Generally, this sort of discussion is better on Discourse (https://discourse.phabricator-community.org) than here.

Oct 31 2017, 2:47 PM · Feature Request, Fund
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

From T10109, we shouldn't make revisions "Buildable" to Herald if the update is an automatic update in response to a commit being discovered.

Oct 31 2017, 1:52 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T10109: Differental does not trigger Herald for mundane updates.

Ah, thanks. I think your guess is right. I'll make a note in T2543, should be a one-line fix I think.

Oct 31 2017, 1:51 PM · Differential, Restricted Project, Herald, Bug Report
spawnlt updated the task description for T13011: Let community to fund features and bug fixes for increased priority and earlier delivery.
Oct 31 2017, 12:02 PM · Feature Request, Fund
spawnlt created T13011: Let community to fund features and bug fixes for increased priority and earlier delivery.
Oct 31 2017, 11:56 AM · Feature Request, Fund
avivey added a comment to T10109: Differental does not trigger Herald for mundane updates.

From https://discourse.phabricator-community.org/t/644 - it appears that HM now triggers a build on revisions when they are closed via landing, which fails because the build expects a Staging ref. I don't have the setup to test any of it, but the latest revision landed here doesn't show the behavior, so either f7f3dd5b2084 hasn't rolled in here yet, or that user is doing something funny.

Oct 31 2017, 11:09 AM · Differential, Restricted Project, Herald, Bug Report
avivey updated the task description for T3626: Detection of language for some file types isn't good.
Oct 31 2017, 9:09 AM · Customer Impact, Restricted Project, Differential
siepkes added a comment to T8552: Increase user control over document hierarchy in Phriction.
In T8552#233072, @mejaz wrote:

Why is Phriction being kept on such a low priority? This task has been since 2014 if we take into account this: T5254: Allow top-level wiki doc to display entire document hierarchy instead of only 2 levels

Oct 31 2017, 8:24 AM · Phriction, Restricted Project
• mejaz added a comment to T8552: Increase user control over document hierarchy in Phriction.

Why is Phriction being kept on such a low priority? This task has been since 2014 if we take into account this: T5254: Allow top-level wiki doc to display entire document hierarchy instead of only 2 levels

Oct 31 2017, 2:53 AM · Phriction, Restricted Project

Oct 27 2017

epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

After all that stuff:

Oct 27 2017, 5:43 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a project to T13010: Upgrading: Differential Draft State: Installing & Upgrading.
Oct 27 2017, 5:41 PM · Installing & Upgrading
epriestley created T13010: Upgrading: Differential Draft State.
Oct 27 2017, 5:41 PM · Installing & Upgrading
epriestley added a comment to T11911: Arcanist Experimental Branch.

Additionally, arc diff no longer dispatches ArcanistEventType::TYPE_REVISION_WILLCREATEREVISION if the server is sufficiently modern. (It no longer uses the datastructure this event received.)

Oct 27 2017, 5:33 PM · Restricted Project, Arcanist
epriestley added a comment to T11911: Arcanist Experimental Branch.

See T2543. The flags related to previewing a diff have changed:

Oct 27 2017, 5:31 PM · Restricted Project, Arcanist
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 27 2017, 5:24 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 27 2017, 4:25 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 27 2017, 4:20 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 27 2017, 4:15 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 27 2017, 4:10 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T10109: Differental does not trigger Herald for mundane updates as Resolved by committing Restricted Diffusion Commit.
Oct 27 2017, 3:44 PM · Differential, Restricted Project, Herald, Bug Report
• svr678 added a comment to T5015: Allow Herald rules for Maniphest to act on task status changes.

oh, nice work, it will trigger parent task as well when subtask changed, seems I need to add the "condition" like subtask status instead of a "action" for this... any samples? Thanks!

Oct 27 2017, 3:17 AM · Herald, Maniphest

Oct 26 2017

epriestley added a revision to T12974: Upgrading: "Ferret" Fulltext Engine: Unknown Object (Differential Revision).
Oct 26 2017, 8:41 PM · Installing & Upgrading, Search
• svr678 added a comment to T5015: Allow Herald rules for Maniphest to act on task status changes.

Question: When subtask was fixed, the parent task want to have a action, for example, add a tag or change status if all subtasks were fixed.
So how to get this work in the extention of herald action? Thanks in advance!~

Oct 26 2017, 8:42 AM · Herald, Maniphest

Oct 24 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 24 2017, 9:21 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T10109: Differental does not trigger Herald for mundane updates: Unknown Object (Differential Revision).
Oct 24 2017, 9:21 PM · Differential, Restricted Project, Herald, Bug Report
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 24 2017, 4:32 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
clemvangelis awarded T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them a Like token.
Oct 24 2017, 9:32 AM · Restricted Project, Arcanist

Oct 23 2017

amckinley created Image Macro "moneyfire".
Oct 23 2017, 11:18 PM
epriestley added a revision to T12974: Upgrading: "Ferret" Fulltext Engine: Unknown Object (Differential Revision).
Oct 23 2017, 10:09 PM · Installing & Upgrading, Search
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

This is technically accurate but real awkward for humans:

Oct 23 2017, 10:05 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query: Unknown Object (Differential Revision).
Oct 23 2017, 10:01 PM · Customer Impact, Restricted Project, Performance, Audit
epriestley closed T13009: MySQL may take several seconds after restart to begin listening on domain socket as Resolved.

I pushed secure004 with that patch and it worked fine, although mysql came back up fast enough that we didn't have to wait. Since I don't have a way to actually trigger this condition, I'm going to assume this is resolved until we have evidence otherwise.

Oct 23 2017, 8:11 PM · Ops, Phacility
epriestley closed T13008: Process slot exhaustion in Phacility web tier as Resolved.

This has been stable for about a week now.

Oct 23 2017, 6:24 PM · Ops, Phacility
epriestley added a comment to T13003: `admin.phacility.com` is receiving a huge volume of "leafweb" traffic.

This traffic eventually stopped on October 20th.

Oct 23 2017, 6:24 PM · Ops, Phacility
epriestley closed T13000: Sustained MySQL I/O overwhelmed db009 / huge Ferret engine ngrams table as Resolved.

The pruned (at 0.15 threshold), optimized ngram index for the original affected instance is only ~13GB, which is entirely manageable with the changes to backups, and we haven't run into other issues.

Oct 23 2017, 6:21 PM · Ops, Phacility
epriestley added a comment to T13009: MySQL may take several seconds after restart to begin listening on domain socket.

We hit one of more of these (db024) last week so D18725 should fix it.

Oct 23 2017, 6:09 PM · Ops, Phacility
epriestley added a revision to T13009: MySQL may take several seconds after restart to begin listening on domain socket: Unknown Object (Differential Revision).
Oct 23 2017, 6:03 PM · Ops, Phacility
epriestley closed T12190: In PHP7, include-time warnings from source files are ignored, a subtask of T12101: Phabricator PHP 7 Compatibility, as Resolved.
Oct 23 2017, 5:54 PM · Infrastructure, Guides
epriestley closed T12190: In PHP7, include-time warnings from source files are ignored as Resolved by committing Restricted Diffusion Commit.
Oct 23 2017, 5:54 PM · Infrastructure
epriestley added a revision to T12190: In PHP7, include-time warnings from source files are ignored: Unknown Object (Differential Revision).
Oct 23 2017, 5:17 PM · Infrastructure
epriestley added a revision to T12190: In PHP7, include-time warnings from source files are ignored: Restricted Differential Revision.
Oct 23 2017, 5:14 PM · Infrastructure
francois added a comment to T5463: Could not stat AuthorizedKeysCommand .

I ran into the same issue, it turned out, that the permissions for /phabricator, /libphutil and /phabricator as well as for the preceding parent-directory had to be 755.

Until i figured this out i tried running all directories with less permissions (750) - which did result in a

AuthorizedKeysCommand /usr/share/phabricator-ssh-hook.sh returned status 126

I really don't know which user is here trying to invoke whichever script or command (since all defined users [git, phd, www-data] are nicely coupled in their phacility-group), but since i wasn't able to track that down i think that's a good compromise. And it should be safer than letting root invoke the AuthorizedKeysCommand.

Oct 23 2017, 7:07 AM · Diffusion
cburroughs awarded T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential a Love token.
Oct 23 2017, 12:31 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Oct 22 2017

holmboe added a comment to T12856: Evaluate various "infrastructure-as-code" products.

I wrote a small dynamic inventory client (based on almanac /passphrase conduit API). It is not open source but I can open source it, if there is a need.

Oct 22 2017, 5:05 PM · Ops, Phacility

Oct 21 2017

epriestley edited the content of Changelog.
Oct 21 2017, 12:58 PM
epriestley created 2017 Week 42 (Late October).
Oct 21 2017, 12:57 PM

Oct 20 2017

epriestley added a revision to T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query: Unknown Object (Differential Revision).
Oct 20 2017, 10:42 PM · Customer Impact, Restricted Project, Performance, Audit
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 20 2017, 6:59 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
friesenschrauber awarded T9105: Decide if we should have Topics in Ponder a Like token.
Oct 20 2017, 4:06 PM · Ponder
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

A very rough version of this is now in master, but only active if phabricator.show-prototypes is on. These are some of the (substantial) remaining issues I'm aware of, and there are probably others:

Oct 20 2017, 3:51 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Oct 19 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 19 2017, 9:11 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Oct 19 2017, 8:37 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Oct 17 2017

rbalik awarded T5051: Burn down charts for Milestones a Like token.
Oct 17 2017, 10:40 PM · Restricted Project, Projects, Wikimedia
epriestley added a revision to T13000: Sustained MySQL I/O overwhelmed db009 / huge Ferret engine ngrams table: Unknown Object (Differential Revision).
Oct 17 2017, 9:00 PM · Ops, Phacility
epriestley removed a member for GitHub: • worldkingma.
Oct 17 2017, 1:19 PM
• worldkingma added a member for GitHub: • worldkingma.
Oct 17 2017, 4:59 AM

Oct 16 2017

epriestley lowered the priority of T13008: Process slot exhaustion in Phacility web tier from Unbreak Now! to Normal.

I'm going to call this tentatively done and leave it open for a week or two to see if there's any fallout.

Oct 16 2017, 3:55 PM · Ops, Phacility
epriestley added a comment to T13008: Process slot exhaustion in Phacility web tier.

Something is making a lot of requests

Oct 16 2017, 3:54 PM · Ops, Phacility
mruuska added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

I'm getting the same #1048: Column 'filename' cannot be null running just regular "arc diff". It used to work and then at some point after updates started failing.

Oct 16 2017, 3:52 PM · Arcanist, Bug Report
mruuska created P2077 Column 'filename' cannot be null.
Oct 16 2017, 3:51 PM
epriestley added a comment to T13008: Process slot exhaustion in Phacility web tier.

The behavior of mod_reqtimeout is weird in production. Some of this is the LB, but some of it I don't have a good explanation for.

Oct 16 2017, 3:38 PM · Ops, Phacility
siepkes added a comment to P2025 Aphlict behind Apache.

The above did not work for me. The following did:

Oct 16 2017, 3:09 PM
epriestley added a comment to T13008: Process slot exhaustion in Phacility web tier.

I was able to get web001 to wedge a lot of requests in "R" ("Reading Request") -- note "SS" is "seconds since beginning of most recent request".

Oct 16 2017, 2:55 PM · Ops, Phacility
epriestley added a comment to T13008: Process slot exhaustion in Phacility web tier.

I'm also unable to wedge secure. mod_status is working there, but since I can't wedge it it isn't very useful.

Oct 16 2017, 2:34 PM · Ops, Phacility
epriestley added a comment to T13008: Process slot exhaustion in Phacility web tier.

I'm going to take a more detailed look at local behavior for this specific request pattern.

Oct 16 2017, 2:19 PM · Ops, Phacility
mcorteel awarded T7332: Notification / Message icons should update in real-time a Love token.
Oct 16 2017, 1:56 PM · Conpherence (v4), Aphlict, Notifications

Oct 14 2017

epriestley added a comment to T13008: Process slot exhaustion in Phacility web tier.

This is working somewhat better than before, but I'm still able to wedge apache with enough requests using a pre-patch version of libphutil. I'm going to take a more detailed look at local behavior for this specific request pattern.

Oct 14 2017, 4:06 PM · Ops, Phacility
epriestley added a revision to T13008: Process slot exhaustion in Phacility web tier: Restricted Differential Revision.
Oct 14 2017, 3:00 PM · Ops, Phacility
epriestley added a comment to T13008: Process slot exhaustion in Phacility web tier.

It's currently possible for cluster hosts to hit rate limits against admin while doing normal deployment stuff, since they may make a lot of requests to admin very quickly.

Oct 14 2017, 2:45 PM · Ops, Phacility