Page MenuHomePhabricator
Feed All Stories

Feb 13 2017

remusvrm added Q529: Why I can not tag anymore a milestone? (Answer 509).
Feb 13 2017, 9:28 AM
• sallyjackson added a comment to T11612: Remarkup - Support rendering of iterative expressions.
Feb 13 2017, 9:20 AM · Remarkup, Feature Request
favagostar3 added a watcher for Design: favagostar3.
Feb 13 2017, 8:44 AM
favagostar3 added a watcher for Projects: favagostar3.
Feb 13 2017, 8:39 AM

Feb 12 2017

epriestley added a comment to T12172: Better color scheme for diffs.

T5701 describes a strategy for Pygments styles. I don't think we should tackle that as an accessibility issue, but I think building it as a user preference issue is reasonable.

Feb 12 2017, 1:10 PM · Accessibility, Feature Request
epriestley added a comment to T12173: Support Buildkite as a Harbormaster target.

If you configure your project so that arc unit runs your tests and then make your Buildkite build run arc unit --everything --target $HARBORMASTER_TARGET_PHID --conduit-token ..., you should get full reporting support. Then arc unit on its own will also work, arc diff will get the same integration, etc.

Feb 12 2017, 12:43 PM · Harbormaster, Phacility
johnny-bit added a comment to T7930: Let Calendar provide date services to other applications.

I've recently found myself wishing for couple kinds of functionality that would connect calendar and maniphest:

  • "due date" for tasks,
  • recurring tasks (just like events)
  • age-based priority for tasks (dunno if calendar would be involved, but i've seen some instances of similar FRs popping up)
Feb 12 2017, 11:35 AM · Calendar
johnny-bit awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 12 2017, 10:35 AM · Calendar
chad added a revision to T10390: Dashboards v2 (UX): Unknown Object (Differential Revision).
Feb 12 2017, 6:11 AM · Dashboards (v2)
chad created T12248: You can drag out a tab panel for some reason in dashboard arrange.
Feb 12 2017, 4:42 AM · Dashboards (v2)
chad merged T12247: mail notification for those tasks which overdue date into T7930: Let Calendar provide date services to other applications.
Feb 12 2017, 4:00 AM · Calendar
chad merged task T12247: mail notification for those tasks which overdue date into T7930: Let Calendar provide date services to other applications.
Feb 12 2017, 4:00 AM · Feature Request
chad added a revision to T4984: Improve design of dashboard browse list?: Unknown Object (Differential Revision).
Feb 12 2017, 3:49 AM · Dashboards (v2), Design
joshma added a comment to T12173: Support Buildkite as a Harbormaster target.

Any thoughts on deeper integration with Phabricator? Namely:

  • Reporting back which tests passed/failed
  • Reporting back code coverage (I guess right now it's part of reporting tests via the API, but I'd be happy even if it's merged under 1 dummy test case)
Feb 12 2017, 2:38 AM · Harbormaster, Phacility
joshma added a comment to T12172: Better color scheme for diffs.

:/ colors are hard. From my end, I'm very happy with what I ended up doing in Stylish (and this conversation helped, thank you) so it's not as pressing for me anymore. But LMK if there's anything I can help test out.

Feb 12 2017, 2:31 AM · Accessibility, Feature Request
chad added a comment to T12172: Better color scheme for diffs.

Basically, can we support "Large Fonts" and "Colorblind Diffs" at the same time?

Feb 12 2017, 2:27 AM · Accessibility, Feature Request
chad added a comment to T12172: Better color scheme for diffs.

if td.new-full just used td.new's background color instead (#eaffea). I think it's because:

Feb 12 2017, 2:27 AM · Accessibility, Feature Request
joshma added a comment to T12172: Better color scheme for diffs.

Based on http://enchroma.com/test/result/medium-protan/?completed=1&summary=moderate+protan&axis=3.11&exta=87.34&extb=4.85&lcs=5.69, I have protanomaly (TIL!)

Feb 12 2017, 2:16 AM · Accessibility, Feature Request
joshma added a comment to T12172: Better color scheme for diffs.

So I took another look today. Given that the syntax colors are hard to change, looking only at the 4 bg colors I realized that the main change that would help is if td.new-full just used td.new's background color instead (#eaffea). I think it's because:

Feb 12 2017, 2:07 AM · Accessibility, Feature Request
• tomekj2ee awarded T10293: Plan rest of "CoverImage" feature a Love token.
Feb 12 2017, 1:17 AM · Workboards, Projects (v3)
DemiMarie added a comment to T5301: Inline Remarkup escaping.

I see your point.

Feb 12 2017, 12:03 AM · Remarkup

Feb 11 2017

epriestley deleted Linkable Object Auto Increment.
Feb 11 2017, 9:53 PM
rsmarples created Linkable Object Auto Increment.
Feb 11 2017, 9:51 PM
chad edited the content of Object Name Prefixes / Monograms.
Feb 11 2017, 8:10 PM
chad edited the content of Object Name Prefixes / Monograms.
Feb 11 2017, 8:10 PM
chad renamed T10390: Dashboards v2 (UX) from Dashboards v2 (Home + Usability) to Dashboards v2 (UX).
Feb 11 2017, 6:45 PM · Dashboards (v2)
chad updated the task description for T10390: Dashboards v2 (UX).
Feb 11 2017, 6:45 PM · Dashboards (v2)
chad added a revision to T10390: Dashboards v2 (UX): Unknown Object (Differential Revision).
Feb 11 2017, 6:14 PM · Dashboards (v2)
swisspol added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

please no I am so young and have so much to live for

Feb 11 2017, 5:26 PM · Customer Impact, Feature Request
chad added a comment to T12247: mail notification for those tasks which overdue date .

Please read and follow Contributing Feature Requests and Describing Root Problems. Unfortunately, we don't accept feature requests into the upstream without understanding the core reasons you need a feature and what problem you are having using Phabricator. A better way to think about this is, assume we won't build what you ask for, what is the real problem you are expecting this feature to solve.

Feb 11 2017, 5:09 PM · Feature Request
shyu created T12247: mail notification for those tasks which overdue date .
Feb 11 2017, 5:01 PM · Feature Request
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

hiding policy controls when creating panels in context of the Arrange Panels page seems like a good way to minimize this

Feb 11 2017, 3:15 PM · Dashboards
chad added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

I'm hoping to make panel creation dramatically simpler, so building a new dashboard from scratch is maybe a 1-2 minute task. Getting rid of copy and maybe also hiding policy controls when creating panels in context of the Arrange Panels page seems like a good way to minimize this.

Feb 11 2017, 3:02 PM · Dashboards
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

No idea if realistic, but what if this "feature" is only enabled on installs of less than 6 months (or with the right db schema or something)?

Feb 11 2017, 2:37 PM · Customer Impact, Feature Request
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

Those seem to have been the magic words:

Feb 11 2017, 12:59 PM · Mail, Phacility, Ops
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

Panels can currently appear on multiple dashboards, so we can't use the dashboard's policy for them directly. If we could, you could always see any panel by creating a new dashboard you have permission to see, adding every panel to it, and looking at the panel you wanted.

Feb 11 2017, 12:06 PM · Dashboards
Luke081515.2 added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

Unless you can define a different default dashboard for logged in and logged out users, yeah.
The problem I see:

  • I run a phabricator instance where the main part is only accesible for logged in users, but logged out users can still see some tasks.
  • My problem: I want to inform my users about different upcoming events etc, for example per text panel
  • The logged out users should not be able to see these messages, so I restricted some panels
  • The whole problem would be easy to solve, if admins can define: logged in users get dashboard a), logged out users get dashboard b) in my situation
Feb 11 2017, 11:41 AM · Dashboards
akhayyat added a comment to T7190: Project templates/Copying tasks.

This is an essential feature for organizations running many, similarly structured projects. For us, each project is essentially a workflow of a predefined series of tasks that need to be tracked, assigned, and discussed individually for each project. Of course, each project will grow its own, custom additional tasks, too.

Feb 11 2017, 11:29 AM · Projects, Maniphest
constantx added a comment to T10293: Plan rest of "CoverImage" feature.

+1 to hide cover as an option on the board

Feb 11 2017, 8:27 AM · Workboards, Projects (v3)
constantx added a watcher for Design: constantx.
Feb 11 2017, 7:44 AM
chad moved T11651: Owners empty states are lookin' weird from Active to Backlog on the Design board.
Feb 11 2017, 4:46 AM · Owners, Design
chad closed T12246: Corrective Measures as Spite.
Feb 11 2017, 4:25 AM · Design
• greedhector28 awarded T12245: When creating an auth provider, the header says "Enabled" but you haven't created it yet a Dislike token.
Feb 11 2017, 4:10 AM · Auth
• greedhector28 added a watcher for Bug Report: • greedhector28.
Feb 11 2017, 4:07 AM
• greedhector28 created T12246: Corrective Measures.
Feb 11 2017, 4:06 AM · Design
• Hektve moved T11651: Owners empty states are lookin' weird from Backlog to Active on the Design board.
Feb 11 2017, 3:51 AM · Owners, Design
• Hektve added a member for Ops: • Hektve.
Feb 11 2017, 3:48 AM
• Hektve added a watcher for Ops: • Hektve.
Feb 11 2017, 3:46 AM
chad added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

Do we have a good reason for having separate polices for panels?

Feb 11 2017, 2:55 AM · Dashboards
swisspol added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

A possible workflow change might be to use "Edit Parent Tasks" instead of "Merge", to collect separate bugs under a single parent task but not actually close them.

Feb 11 2017, 1:55 AM · Customer Impact, Feature Request
amckinley added a revision to T12245: When creating an auth provider, the header says "Enabled" but you haven't created it yet: Unknown Object (Differential Revision).
Feb 11 2017, 1:01 AM · Auth
epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

The LocationsResource file is completely copy/pasted and wrong (still refers to "Instances").

Feb 11 2017, 12:55 AM · Phacility
epriestley added a comment to T5301: Inline Remarkup escaping.

I think the complexity of those rules exceeds their utility.

Feb 11 2017, 12:42 AM · Remarkup
DemiMarie added a comment to T5301: Inline Remarkup escaping.

What are your thoughts on allowing valid HTML entities through to the
browser without further escaping (outside of code blocks)? There seems to
be no reason to have them in text, and they could allow escaping.

Feb 11 2017, 12:22 AM · Remarkup
epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

Base scenario should create the appropriate edge tables.

Feb 11 2017, 12:13 AM · Phacility
epriestley closed T12224: Phortune "Autopay" on View controller does not respect disabled payment methods as Resolved by committing Restricted Diffusion Commit.
Feb 11 2017, 12:02 AM · Phortune
epriestley created T12245: When creating an auth provider, the header says "Enabled" but you haven't created it yet.
Feb 11 2017, 12:00 AM · Auth

Feb 10 2017

epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

And phabricator.developer-mode and phabricator.developer-mode and phabricator.developer-mode and also phabricator.show-prototypes.

Feb 10 2017, 11:39 PM · Phacility
epriestley added a comment to T12238: Write a script to populate a Phacility instance with the "Locations" scenario.

We should suggest configuring phabricator.developer-mode and phabricator.developer-mode (for UIExamples, to see icons).

Feb 10 2017, 11:38 PM · Phacility
aklapper added a comment to T12157: Make it visibly clearer that a Phabricator user account has been disabled.

I like. ♥. Thank you a lot!

Feb 10 2017, 10:23 PM · Profile, Feature Request
chad created E1381: Cirque du Soleil.
Feb 10 2017, 7:15 PM · Phacility
chad closed T12213: Task title is truncated in task graph, even if there is enough space as Resolved by committing Restricted Diffusion Commit.
Feb 10 2017, 6:58 PM · Maniphest, Bug Report
chad added a revision to T12213: Task title is truncated in task graph, even if there is enough space: Unknown Object (Differential Revision).
Feb 10 2017, 6:41 PM · Maniphest, Bug Report
epriestley created T12244: Provide a crude way to selectively disable reads and writes of repository devices by setting flags on Almanac bindings.
Feb 10 2017, 6:03 PM · Restricted Project, Almanac
chad added a comment to T12242: arc commandeer.

💃

Feb 10 2017, 5:50 PM · Feature Request
epriestley closed T12242: arc commandeer as Resolved.
Feb 10 2017, 5:48 PM · Feature Request
Willyham added a comment to T12242: arc commandeer.

Yep, if you can update other people's diffs then this is fine. I'll just upgrade if needed. Thanks.

Feb 10 2017, 5:39 PM · Feature Request
jcox closed T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock as Resolved by committing Restricted Diffusion Commit.
Feb 10 2017, 5:38 PM · Diffusion, Bug Report
jcox added a revision to T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock: Unknown Object (Differential Revision).
Feb 10 2017, 5:30 PM · Diffusion, Bug Report
chad added a comment to T12242: arc commandeer.

This is what I just did as a test:

Feb 10 2017, 5:28 PM · Feature Request
epriestley added a comment to T12242: arc commandeer.

I suppose that I'm being lazy, but the exact same argument exists for arc close-revision or arc upload.

Feb 10 2017, 5:27 PM · Feature Request
Willyham added a comment to T12242: arc commandeer.

@chad my understanding was that only the current owner of a revision can make changes. I guess I didn't read that thread through to completion, though I'm not sure that patch has made it to our install yet.

Feb 10 2017, 5:24 PM · Feature Request
yelirekim assigned T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock to jcox.
Feb 10 2017, 5:19 PM · Diffusion, Bug Report
yelirekim created T12243: Repository cluster engine throws InvalidArgument exception when failing to acquire a write lock.
Feb 10 2017, 5:19 PM · Diffusion, Bug Report
chad added a comment to T12242: arc commandeer.

Can't they just arc patch Dxxxx and arc diff their changes back up?

Feb 10 2017, 5:16 PM · Feature Request
Willyham added a comment to T12242: arc commandeer.

I'm not trying to be facetious, but I'm not sure that there are two other ways. The scenario is that somebody is out and I'd like to continuing working on their feature whilst they're away. I've read through T10584 which mostly discusses why commandeer should be used in this case rather than updating somebody else's diff. In this case, if they say to me, "hey, can you take D123 whilst I'm out?", I'd prefer to just type arc commandeer D123 than have to go to the UI, find the diff and commandeer it. I suppose that I'm being lazy, but the exact same argument exists for arc close-revision or arc upload.

Feb 10 2017, 5:14 PM · Feature Request
epriestley closed T12140: When Home is uninstalled, the user menu disappears / 2017 Week 3 Deployment Log as Resolved.

The db001 issue is still an issue, but the shard has managed to stay just under 80% for the last couple of weeks so we're not in any immediate peril. As followups, I think T12217 and T12218 better capture the broader issues here.

Feb 10 2017, 5:12 PM · Phacility, Ops, Applications
epriestley closed T12150: Restricting Push not working as Invalid.

We haven't received any more information about this in a little more than two weeks, and don't know how to reproduce it so we can't move forward. Feel free to file a new task if you're able to come up with reproduction steps which work in a clean environment.

Feb 10 2017, 5:10 PM · Bug Report (Needs Information)
epriestley added a comment to T12157: Make it visibly clearer that a Phabricator user account has been disabled.

I think there are some more things worth doing here, but user profiles should be significantly more clear after recent changes. Here's @demo on this install now:

Feb 10 2017, 5:07 PM · Profile, Feature Request
chad updated the task description for T12174: Home Menu Errata.
Feb 10 2017, 5:07 PM · Dashboards (v2), Profile Menu Item
epriestley added a comment to T12167: Unable to edit menu items on mobile.

Oh we already had one of these

Feb 10 2017, 5:05 PM · Profile Menu Item, Bug Report
epriestley closed T12168: Upgrading: Owners Packages/Commits now use edges as Resolved.

Presuming this is resolved since it's extremely boring and I ran it here and on every instance in the production cluster last week without any issues, but yell if you run into problems.

Feb 10 2017, 5:05 PM · Diffusion (v3), Installing & Upgrading, Audit
epriestley closed T12173: Support Buildkite as a Harbormaster target, a subtask of T9456: Evaluate upstream support for third-party build systems, as Resolved.
Feb 10 2017, 5:04 PM · Restricted Project, Harbormaster
epriestley closed T12173: Support Buildkite as a Harbormaster target as Resolved.

Presuming this is resolved since we haven't seen any evidence otherwise, but feel free to file followups if you run into issues or limitations.

Feb 10 2017, 5:04 PM · Harbormaster, Phacility
epriestley updated the task description for T12174: Home Menu Errata.
Feb 10 2017, 4:59 PM · Dashboards (v2), Profile Menu Item
epriestley closed T12198: Database seen as uninitialized after upgrade....cannot recover as Invalid.

We haven't received information that lets us reproduce this in about a week.

Feb 10 2017, 4:57 PM · Bug Report (Needs Information)
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

I scratched at the surface of T2794, but @chad also bought me a larger monitor so I can put more SSH terminals on it which should buy us another few weeks.

Feb 10 2017, 4:55 PM · Ops, Phacility
epriestley added a comment to T12222: Add custom fields to the "Task Action..." menu.
  • Why do you track "percent complete"? What do you use it for?
  • Is it actually accurate? Developers are notoriously bad at estimating project timelines, so I would naively guess that a "Percent" field would have almost no relationship to reality.
Feb 10 2017, 4:55 PM · Maniphest, Feature Request
epriestley added a revision to T12224: Phortune "Autopay" on View controller does not respect disabled payment methods: Unknown Object (Differential Revision).
Feb 10 2017, 4:50 PM · Phortune
epriestley added a comment to T12232: Phortune "add payment method" erroring out on submission.

D17333 is a probable fix without needing to resort to a bunch of weird setInterval() juggling. I've pushed that here, let me know if you're still seeing the issue? If you are, does your JS console have anything in it?

Feb 10 2017, 4:44 PM · Phortune, Bug Report
epriestley added a comment to T12242: arc commandeer.

Other than implementing arc commandeer, can you suggest two different ways we could solve the problem you're running into?

Feb 10 2017, 4:38 PM · Feature Request
epriestley added a revision to T12232: Phortune "add payment method" erroring out on submission: Unknown Object (Differential Revision).
Feb 10 2017, 4:35 PM · Phortune, Bug Report
epriestley added a comment to T12232: Phortune "add payment method" erroring out on submission.

I'm having some trouble reproducing this -- I tried Safari and Chrome here and in my sandbox. You aren't using anything weird, right?

Feb 10 2017, 4:30 PM · Phortune, Bug Report
Willyham created T12242: arc commandeer.
Feb 10 2017, 4:20 PM · Feature Request
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

At some point, it's starting to be a lot of noise in the project, so we dup all these reports against the task tracking the root cause.

Feb 10 2017, 4:12 PM · Customer Impact, Feature Request
epriestley added a comment to T12234: Add a "Duplicates" tab to the "Related Objects" section on task page.

From a technical standpoint, we did not record these relationships in a normalized way prior to D16196 (June 2016, about 7 months ago) -- they only existed in the transaction log, and we just wrote a "close", extra_data="as duplicate of X" transaction that can't be queried efficiently.

Feb 10 2017, 4:09 PM · Customer Impact, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

We could also implement "Mute Thread" in Phabricator, but I assume no one would be willing to click twice to mute a thread.

Feb 10 2017, 3:44 PM · Restricted Project, Mail, Feature Request
epriestley closed T12236: Conduit Method maniphest.edit: Unhandled Exception as Resolved by committing Restricted Diffusion Commit.
Feb 10 2017, 3:39 PM · Bug Report
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

If we use SMTP envelope To, doesn't Alice potentially get multiple messages still (envelope "To: Alice", envelope "To: All-About-Alice@lists.company.com")? The list rewrites the envelope to go to all the list members, right? Or is there more magic there I don't know about?

Feb 10 2017, 3:35 PM · Restricted Project, Mail, Feature Request
epriestley added a comment to T12240: Best of Both Worlds: one email to everyone with privacy controls and good threading.

One issue with one-mail-per-recipient is that gmail does not permit muting an email conversation if you are the only TO recipient.

Feb 10 2017, 3:28 PM · Restricted Project, Mail, Feature Request