Page MenuHomePhabricator
Feed All Stories

Mar 23 2016

epriestley closed T5485: Write a script to discover orphaned PHIDs as Wontfix.

I think it's very unlikely that we'll ever write some kind of script to just fix this stuff. I suspect such a script is impossible to write (i.e., the "correct" value for most fields is ambiguous) and that maintaining it is very difficult.

Mar 23 2016, 5:05 PM · Restricted Project, Infrastructure
amckinley added a comment to T10651: Attempting to create a credential of type API Token always results in an exception.

Works now; thanks!

Mar 23 2016, 4:55 PM · Passphrase, Bug Report
epriestley added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

I don't particularly love ASIDE as the trigger, maybe MEMO is a little better? But it doesn't really capture the intent particularly well, I think.

Mar 23 2016, 4:38 PM · Remarkup, Feature Request
epriestley renamed T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis from small text in remarkup to Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.
Mar 23 2016, 4:30 PM · Remarkup, Feature Request
epriestley closed T10652: Allow arcanist to plan changes to a revision as Wontfix.

I think this option would very rarely see use, and @avivey's suggestion (arc browse D1234 + use web UI) is a pretty good workaround.

Mar 23 2016, 4:17 PM · Arcanist, Feature Request
epriestley added a comment to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.

T7789 has some discussion, but there's now a clear pathway forward here which doesn't require anything too drastic. Specifically:

Mar 23 2016, 4:07 PM · Diffusion (v3), Restricted Project
wschroo added a comment to T10412: Change Milestone sort options.

Assuming that the milestoneNumber field will only be used for internal logic to order milestones.

Mar 23 2016, 3:38 PM · Feature Request
chad closed T10654: test as Invalid.
Mar 23 2016, 2:14 PM · Feature Request
• ferol created T10654: test.
Mar 23 2016, 1:38 PM · Feature Request
cmmata added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

@cmmata Configuring Custom Fields may help. In your installation, you'd navigate to /config/edit/maniphest.custom-field-definitions/ to edit the Maniphest custom field configuration.

Mar 23 2016, 1:36 PM · Projects (v3)
rfreebern added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

@cmmata Configuring Custom Fields may help. In your installation, you'd navigate to /config/edit/maniphest.custom-field-definitions/ to edit the Maniphest custom field configuration.

Mar 23 2016, 1:19 PM · Projects (v3)
roelvanmeer closed Q349: Milestone project ordering on board as resolved.
Mar 23 2016, 12:27 PM
roelvanmeer added a comment to Q349: Milestone project ordering on board.

Great, thanks!

Mar 23 2016, 12:27 PM
roelvanmeer awarded T10412: Change Milestone sort options a Like token.
Mar 23 2016, 12:26 PM · Feature Request
• spiridon-alexandru awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Mar 23 2016, 11:50 AM · Workboards (v3), Restricted Project
• spiridon-alexandru awarded T4863: Allow Workboard Cards to be customized for display a Like token.
Mar 23 2016, 11:44 AM · Projects, Workboards, Wikimedia
• spiridon-alexandru awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Love token.
Mar 23 2016, 11:44 AM · Maniphest
ajvorobiev added a comment to Q349: Milestone project ordering on board.

There is a discussion about this in T10412: Change Milestone sort options

Mar 23 2016, 11:08 AM
roelvanmeer updated Q349: Milestone project ordering on board from to Milestone project ordering on board.
Mar 23 2016, 10:52 AM
cmmata added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

How (or where) can I remove "old" points custom field? I successfully migrated all points to the new Maniphest field, but now I have two story points fields. I'm taking a look at the database, but there's no direct field in maniphest_task. I suppose it's the reference in maniphest_customfieldstorage with fieldIndex yERhvoZPNPtM (at least in my case), but I prefer not to alter a database without knowing all the places I have to make changes.

Mar 23 2016, 9:10 AM · Projects (v3)
swisspol added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

Thanks! I shall use these powers responsibly 😄

Mar 23 2016, 3:00 AM · Feature Request
epriestley added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

I added you to Community so you should have task edit powers now.

Mar 23 2016, 2:25 AM · Feature Request
epriestley added a member for Community: swisspol.
Mar 23 2016, 2:25 AM
epriestley closed T10653: Add Herald condition to act on pushing commits that have more than 1 parent as Resolved.
Mar 23 2016, 2:19 AM · Feature Request
swisspol added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

Oops... sorry, can't believe I missed that! I was looking in "Commit Hook: Branches/Tags/Bookmarks" instead of "Commit Content".

Mar 23 2016, 2:18 AM · Feature Request
epriestley closed T10651: Attempting to create a credential of type API Token always results in an exception as Resolved by committing Restricted Diffusion Commit.
Mar 23 2016, 1:53 AM · Passphrase, Bug Report
epriestley added a comment to T10651: Attempting to create a credential of type API Token always results in an exception.

Whoops, thanks. This got rebased across 200 years of changes and I didn't re-test creating a credential. D15512 should fix it.

Mar 23 2016, 1:52 AM · Passphrase, Bug Report
epriestley added a revision to T10651: Attempting to create a credential of type API Token always results in an exception: Unknown Object (Differential Revision).
Mar 23 2016, 1:52 AM · Passphrase, Bug Report
epriestley added a comment to T10653: Add Herald condition to act on pushing commits that have more than 1 parent.

"Is merge commit" detects this.

Mar 23 2016, 1:49 AM · Feature Request
swisspol created T10653: Add Herald condition to act on pushing commits that have more than 1 parent.
Mar 23 2016, 1:07 AM · Feature Request
avivey added a comment to T10652: Allow arcanist to plan changes to a revision.

arc branch and arc list to see open revisions; arc browse D1234 to open it in browser; T5873 for everything else.

Mar 23 2016, 1:02 AM · Arcanist, Feature Request
Luke081515.2 added a comment to T10652: Allow arcanist to plan changes to a revision.

That's before you're uploading the diff. If you already uploaded the diff, and say: "Oh, I forget to insert a parameter" for example, you can't use that.

Mar 23 2016, 12:53 AM · Arcanist, Feature Request
eadler added a comment to T10652: Allow arcanist to plan changes to a revision.

arc diff --plan-changes ?

Mar 23 2016, 12:50 AM · Arcanist, Feature Request
Luke081515.2 created T10652: Allow arcanist to plan changes to a revision.
Mar 23 2016, 12:27 AM · Arcanist, Feature Request
eadler moved T10329: Implement internal workflows / a build engine in Arcanist from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 23 2016, 12:19 AM · Restricted Project, Arcanist
eadler moved T10329: Implement internal workflows / a build engine in Arcanist from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Mar 23 2016, 12:17 AM · Restricted Project, Arcanist
eadler added a project to T10329: Implement internal workflows / a build engine in Arcanist: Restricted Project.
Mar 23 2016, 12:17 AM · Restricted Project, Arcanist

Mar 22 2016

avivey added a project to T10651: Attempting to create a credential of type API Token always results in an exception: Passphrase.
Mar 22 2016, 11:47 PM · Passphrase, Bug Report
amckinley created T10651: Attempting to create a credential of type API Token always results in an exception.
Mar 22 2016, 11:41 PM · Passphrase, Bug Report
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 22 2016, 11:09 PM · Nuance, GitHub
chad added projects to T10613: Include commit's branch information in activity feed: Feed, Diffusion.
Mar 22 2016, 11:05 PM · Diffusion, Feed, Feature Request
chad added a project to T10612: Editing a panel causes it to duplicate in dashboard: Dashboards.
Mar 22 2016, 11:04 PM · Dashboards (v2), Bug Report
nornagon awarded T10363: Reorient Doorkeeper publishing around transactions instead of feed stories a Piece of Eight token.
Mar 22 2016, 10:59 PM · Nuance, Restricted Project, Feed, Doorkeeper
Luke081515.2 added a project to T10538: Bridge GitHub to Phabricator: GitHub.
Mar 22 2016, 10:57 PM · Nuance, GitHub
nornagon added a comment to T5462: How do I publish Phabricator events into remote systems?.

Awesome! Thanks for the quick reply @epriestley :)

Mar 22 2016, 10:57 PM · Guides, Doorkeeper, Feed, Herald
epriestley added a comment to T5462: How do I publish Phabricator events into remote systems?.

See T5726, T10363.

Mar 22 2016, 10:55 PM · Guides, Doorkeeper, Feed, Herald
nornagon added a comment to T5462: How do I publish Phabricator events into remote systems?.

The data available from feed.http-hooks or feed.query is somewhat limited:

Mar 22 2016, 10:54 PM · Guides, Doorkeeper, Feed, Herald
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 22 2016, 10:21 PM · Nuance, GitHub
Taskle added a comment to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.

@epriestley I understand you have the setup check - my point is that for RDS users we skip this check when we see we can't do anything about it. And then months later it's forgotten about and we still draw that conclusion.

Mar 22 2016, 9:49 PM · Search, Bug Report
epriestley added a comment to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.

just convinced that Phab search didn't work and feeling powerless over it

Mar 22 2016, 9:35 PM · Search, Bug Report
Taskle added a comment to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.

Amazon RDS is incredibly popular so although you haven't seen this request from other installs, my guess is that many are like we have been for the past 1.5 years - just convinced that Phab search didn't work and feeling powerless over it...I understand the squeaky wheel tends to get the oil, but it's worth maybe considering what % of installs use RDS since all of them will have this problem.

Mar 22 2016, 9:12 PM · Search, Bug Report
Taskle added a comment to T10639: Implement a complex Gmail-style "to:<name>" query language.

@epriestley as the former PM on Gmail I can tell you that for power users this was an incredibly valuable feature - and I've read from your docs that your typical user that your optimizing for is a power user that users Phab regularly. There's plenty of ways to make it discoverable. But I am not the PM here so all I can do is ask...

Mar 22 2016, 9:09 PM · Search, Feature Request
epriestley added a comment to T10640: Allow application queries to be promoted as global search modes.

See also T4103.

Mar 22 2016, 9:07 PM · Search, Feature Request
Taskle added a comment to T10640: Allow application queries to be promoted as global search modes.

@epriestley the UX problem here for us is that all of our employees are using global search when they don't realize it because it's top right when they go to the phab homepage, when in reality they only use Phab for Maniphest tasks. So asking every employee to manually configure these things doesn't solve this problem.

Mar 22 2016, 9:06 PM · Search, Feature Request
dpaola2 awarded T9456: Evaluate upstream support for third-party build systems a Mountain of Wealth token.
Mar 22 2016, 8:22 PM · Restricted Project, Harbormaster
avivey closed T7984: Symbols: support for External Symbols in other languages as Resolved.

I think this is reasonably supported now.

Mar 22 2016, 7:58 PM · Symbols
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

CircleCI fixed build_parameters in their API so support is now in HEAD of master. There's probably some remaining work but it seems to work properly locally. Let us know if you run into issues with it.

Mar 22 2016, 7:16 PM · Restricted Project, Harbormaster
allixsenos added a comment to T10649: more flexibility in Herald rules.

yeah, fair enough. if I build a stronger case I'll reopen/refile

Mar 22 2016, 5:06 PM · Feature Request
epriestley closed T10649: more flexibility in Herald rules as Resolved.

Sounds like this is resolved one way or the other. In the general case, "Another Herald rule" effectively allows you to group, negate, and combine conditions in addition to reusing/including them.

Mar 22 2016, 5:05 PM · Feature Request
allixsenos added a comment to T10649: more flexibility in Herald rules.

ah, chaining Herald rules, while clunky as a UI solution, probably fixes the more complex scenarios

Mar 22 2016, 5:03 PM · Feature Request
epriestley added a comment to T10649: more flexibility in Herald rules.

You can use two rules:

Mar 22 2016, 5:02 PM · Feature Request
allixsenos added a comment to T10649: more flexibility in Herald rules.

... nvm. brain fart moment.

Mar 22 2016, 5:02 PM · Feature Request
epriestley created T10650: `arc land` can raise misleading error message if a branch exists in the remote but has never been fetched.
Mar 22 2016, 5:00 PM · Restricted Project, Arcanist
allixsenos created T10649: more flexibility in Herald rules.
Mar 22 2016, 4:50 PM · Feature Request
epriestley added a comment to T10648: Task project list ellipsis displays unecessary.

This should be fixed in HEAD of master. Let us know if you're still seeing issues after updating. Thanks for the report!

Mar 22 2016, 4:29 PM · Bug Report
epriestley closed T10648: Task project list ellipsis displays unecessary as Resolved by committing Restricted Diffusion Commit.
Mar 22 2016, 4:29 PM · Bug Report
Luke081515.2 awarded T10538: Bridge GitHub to Phabricator a Mountain of Wealth token.
Mar 22 2016, 4:26 PM · Nuance, GitHub
epriestley added a revision to T10648: Task project list ellipsis displays unecessary: Unknown Object (Differential Revision).
Mar 22 2016, 4:21 PM · Bug Report
meitros added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

as the author of D14104, the advisory update proposal here would make me happy. Its basically taking the class of comments that are suggesting specific fixes or additions and making it more lightweight. One minor ui problem to solve would be supporting pure inserts or deletes.

Mar 22 2016, 4:15 PM · Differential
epriestley added a comment to T10646: Actions are not populated when creating herald rule (Chrome v49 issue).

I think this should be fixed in HEAD, let us know if you're still seeing it after updating. Thanks for the report!

Mar 22 2016, 4:14 PM · Herald, Bug Report
epriestley closed T10646: Actions are not populated when creating herald rule (Chrome v49 issue) as Resolved by committing Restricted Diffusion Commit.
Mar 22 2016, 4:13 PM · Herald, Bug Report
epriestley added a revision to T10646: Actions are not populated when creating herald rule (Chrome v49 issue): Unknown Object (Differential Revision).
Mar 22 2016, 4:11 PM · Herald, Bug Report
ofbeaton created T10648: Task project list ellipsis displays unecessary.
Mar 22 2016, 3:54 PM · Bug Report
Pawka updated the task description for T10646: Actions are not populated when creating herald rule (Chrome v49 issue).
Mar 22 2016, 3:24 PM · Herald, Bug Report
Pawka added a comment to T10646: Actions are not populated when creating herald rule (Chrome v49 issue).

@chad False alarm, I've checked wrong link. Problem existed on Maniphest global rules but it seems it is fixed already on upstream.

Mar 22 2016, 3:24 PM · Herald, Bug Report
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 22 2016, 2:36 PM · Nuance (v1)
chad added a comment to T10646: Actions are not populated when creating herald rule (Chrome v49 issue).

I'm still able to select stuff fine and use the form, did you try the dropdown? (I do see the error in the console).

Mar 22 2016, 2:14 PM · Herald, Bug Report
Pawka created T10646: Actions are not populated when creating herald rule (Chrome v49 issue).
Mar 22 2016, 1:55 PM · Herald, Bug Report
epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 22 2016, 1:43 PM · Nuance, GitHub
krisbuist added a project to T10645: Accepting a closed diff causes diff to be re-opened: Differential.
Mar 22 2016, 11:10 AM · Differential, Bug Report
krisbuist updated the task description for T10645: Accepting a closed diff causes diff to be re-opened.
Mar 22 2016, 11:09 AM · Differential, Bug Report
krisbuist created T10645: Accepting a closed diff causes diff to be re-opened.
Mar 22 2016, 11:05 AM · Differential, Bug Report
sascha-egerer added a comment to T9293: WebSockets access problems with reverse SSL proxy .

I would vote for X-Forwarded-Proto support in AphrontRequest::isHTTPS

Mar 22 2016, 8:52 AM · Restricted Project, Aphlict
eadler closed T10643: support icon in links as Invalid.

oh, I'm just braindead: I skipped over the nav portion entirely since it wasn't the obvious thing I wanted.

Mar 22 2016, 4:11 AM · Remarkup, Feature Request
epriestley added a comment to T10643: support icon in links.

This is already documented, do you have any suggestions for improving the existing documentation?

Mar 22 2016, 4:09 AM · Remarkup, Feature Request
eadler added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

I wanted to use it for de-emphasis (like you're aside) and for inside of tables for various things. I was also trying to use it for a small "edit this panel" link like the other task but the href on the button is cooler.

Mar 22 2016, 4:08 AM · Remarkup, Feature Request
eadler added a comment to T10643: support icon in links.

oh, cool. That should be documented, but is exactly what I wanted.

Mar 22 2016, 4:07 AM · Remarkup, Feature Request
chad added a comment to Q348: Sort behavior for global search.

I believe it's all straight from MySQL. http://dev.mysql.com/doc/internals/en/full-text-search.html

Mar 22 2016, 3:38 AM · Search
epriestley added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

Yeah, I think changing text size inline often tends to look pretty bad since line heights get all messed up, too.

Mar 22 2016, 3:32 AM · Remarkup, Feature Request
• sshannin updated Q348: Sort behavior for global search from to Sort behavior for global search.
Mar 22 2016, 2:33 AM · Search
chad added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

I'd prefer to not support this. Would like to know real use cases instead, maybe just have lighter text or other means. But generally prefer to keep accessibility issues to a minimum.

Mar 22 2016, 2:17 AM · Remarkup, Feature Request
epriestley added a comment to T10643: support icon in links.

Note that you can do this today:

Mar 22 2016, 2:07 AM · Remarkup, Feature Request
epriestley added a comment to T10643: support icon in links.

We're planning to do this at some point:

Mar 22 2016, 2:05 AM · Remarkup, Feature Request
epriestley added a comment to T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.

Do you have some examples of things you'd like to use this for?

Mar 22 2016, 2:01 AM · Remarkup, Feature Request
eadler added a comment to T10643: support icon in links.

this task might more generally: support inline remarkup in link names. I havn't tried to make image, bold, or other interesting links.

Mar 22 2016, 1:41 AM · Remarkup, Feature Request
eadler created T10644: Implement an "ASIDE" or "MEMO" Remarkup element for de-emphasis.
Mar 22 2016, 1:40 AM · Remarkup, Feature Request
eadler created T10643: support icon in links.
Mar 22 2016, 1:35 AM · Remarkup, Feature Request
chad added a comment to T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.

Elasticsearch may also be a solution. Also, looks like we might be able to detect RDS installs by querying variables in MySQL.

Mar 22 2016, 1:31 AM · Search, Bug Report
epriestley added a comment to T10638: A Task can end up on a Milestone workboard column without being in that Milestone.

Yeah -- it's not very clear on its own, but this comment is specifically referring to that issue:

Mar 22 2016, 1:26 AM · Projects (v3), Bug Report
epriestley closed T10589: Create useable search experience for Maniphest as Resolved.

Closing this in favor of followups.

Mar 22 2016, 1:24 AM · Feature Request