Page MenuHomePhabricator
Feed Advanced Search

Mar 16 2021

epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:23 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:23 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:23 PM · Almanac
epriestley removed a revision from T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Mar 16 2021, 9:23 PM · Mail
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: Unknown Object (Differential Revision).
Mar 16 2021, 9:23 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 9:22 PM · Almanac
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: Unknown Object (Differential Revision).
Mar 16 2021, 8:41 PM · Almanac
epriestley updated the task description for T13641: Support "Disabled" devices in Almanac.
Mar 16 2021, 8:28 PM · Almanac
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Restricted Differential Revision.
Mar 16 2021, 6:18 PM · Mail
epriestley added a revision to T13641: Support "Disabled" devices in Almanac: Unknown Object (Differential Revision).
Mar 16 2021, 6:17 PM · Almanac
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
Mar 16 2021, 6:11 PM · Mail
epriestley renamed T13641: Support "Disabled" devices in Almanac from Support "Archived" devices in Almanac to Support "Disabled" devices in Almanac.
Mar 16 2021, 6:03 PM · Almanac
epriestley triaged T13641: Support "Disabled" devices in Almanac as Normal priority.
Mar 16 2021, 6:02 PM · Almanac
epriestley added a project to T13630: Move Phacility provisioning to Piledriver: Almanac.
Mar 16 2021, 5:45 PM · Almanac, Infrastructure, Phacility
epriestley moved T13287: Build general healthcheck infrastructure for monitoring services from Backlog to Health / Statistics on the Almanac board.
Mar 16 2021, 5:44 PM · Clusters, Almanac
epriestley moved T7338: Build more status tools for monitoring Phacility cluster health from Backlog to Health / Statistics on the Almanac board.
Mar 16 2021, 5:44 PM · Almanac, Phacility
epriestley archived Almanac (v2).
Mar 16 2021, 5:44 PM
epriestley closed T10246: Deploy Drydock in the Phacility cluster as Resolved.

At least some installs have been using Drydock in production for a while. This could be made easier -- and this task still has the best guide for it -- but I think nothing actionable here remains.

Mar 16 2021, 5:44 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Mar 16 2021, 5:26 PM · libphutil
epriestley triaged T13640: Improve sequencing of Futures in "--trace" output as Low priority.
Mar 16 2021, 5:24 PM · Infrastructure
epriestley created P2147 Command-Line Input.
Mar 16 2021, 4:04 PM
epriestley created P2146 Command-Line Input.
Mar 16 2021, 4:04 PM

Mar 15 2021

epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:13 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 11:02 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 10:57 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 10:52 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 10:47 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 10:37 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 8:59 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 8:44 PM · Conduit, Differential
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 15 2021, 5:50 PM · Conduit, Differential
epriestley closed T4401: Linking to lines in a diff as Wontfix.

(Internally, see PHI2020.)

Mar 15 2021, 5:30 PM · Differential
epriestley added a comment to T10219: Show suggested lint autofix in Differential web view.

This is relatively ripe for implementation now that inline comments support suggested edits.

Mar 15 2021, 5:15 PM · Lint, Differential
epriestley removed projects from T10219: Show suggested lint autofix in Differential web view: Restricted Project, Feature Request.
Mar 15 2021, 5:15 PM · Lint, Differential
epriestley closed T11608: Make it easier to review stacks of diffs as Wontfix.

This is very old, fairly vague, and doesn't have any clear modern customer interest. I'm open to implementing it, but would like a more clear/modern customer request before pursuing it.

Mar 15 2021, 5:14 PM · Restricted Project, Differential, Feature Request
epriestley moved T7333: Empty commits get same revision as parent from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Differential
epriestley moved T13105: Plans: Rich presentation and diff rendering pipelines for various file types from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Plans, Files, Differential, Diffusion
epriestley moved T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Plans, Differential
epriestley moved T13161: Plans: Improve Differential diff display behaviors from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Differential, Plans
epriestley moved T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits" from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Diffusion, Differential
epriestley moved T13425: Support diffs between abstract block lists in the UI from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Differential
epriestley moved T13513: Make schema changes to inlines to prepare for new inline features from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Inline Comments, Diffusion, Differential
epriestley moved T13520: Update the diff table of contents for moved files, long paths, etc from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13534: Inline Comment errata after editing persistence from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13515: Differential: Inlines and View Options from Backlog to Next on the Differential board.
Mar 15 2021, 5:09 PM · Differential
epriestley moved T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch from Backlog to Next on the Differential board.
Mar 15 2021, 5:08 PM · Differential
epriestley moved T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Backlog to Next on the Differential board.
Mar 15 2021, 5:08 PM · Accessibility, Differential
epriestley moved T13639: Allow revisions to be queried by affected path via the API from Backlog to Next on the Differential board.
Mar 15 2021, 5:07 PM · Conduit, Differential

Mar 14 2021

epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: Unknown Object (Differential Revision).
Mar 14 2021, 8:02 PM · Conduit, Differential
epriestley added a comment to T13639: Allow revisions to be queried by affected path via the API.

I'm likely to break the paths constraint for frozen API method differential.query. This was added by D2788 as a Facebook-specific patch with no rationale that I can dig up, and the author didn't have any related changes from around that time.

Mar 14 2021, 7:54 PM · Conduit, Differential
epriestley triaged T13639: Allow revisions to be queried by affected path via the API as Wishlist priority.
Mar 14 2021, 7:50 PM · Conduit, Differential

Mar 13 2021

epriestley updated the task description for T13630: Move Phacility provisioning to Piledriver.
Mar 13 2021, 6:48 PM · Almanac, Infrastructure, Phacility
epriestley closed T11013: "Unknown Object" when attempting to create a new Almanac network as Resolved.

This is very old and I can't reproduce it, and haven't seen any other reports.

Mar 13 2021, 6:31 PM · Almanac, Bug Report
epriestley updated the task description for T13630: Move Phacility provisioning to Piledriver.
Mar 13 2021, 6:30 PM · Almanac, Infrastructure, Phacility
epriestley triaged T13638: Investigate "AllowEncodedSlashes" Apache setting as Wishlist priority.
Mar 13 2021, 5:40 PM · Setup
epriestley edited the content of Changelog.
Mar 13 2021, 5:50 AM
epriestley created an object: 2021 Week 11 (Mid March).
Mar 13 2021, 5:49 AM

Mar 12 2021

cspeckmim awarded T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers a Like token.
Mar 12 2021, 10:29 PM · Policy, Differential
epriestley added a comment to T13637: PHP Static Method Variable Scope.

I think lint could reasonably emit two warnings about this:

Mar 12 2021, 7:36 PM · Lint, Guides
epriestley triaged T13637: PHP Static Method Variable Scope as Wishlist priority.
Mar 12 2021, 7:32 PM · Lint, Guides
epriestley closed T13631: Support an "auditors" attachment for "diffusion.commit.search" as Resolved.

For now, I fixed the explicit misinformation in audit.can-author-close-audit, at least.

Mar 12 2021, 5:27 PM · Diffusion
epriestley added a revision to T13631: Support an "auditors" attachment for "diffusion.commit.search": Unknown Object (Differential Revision).
Mar 12 2021, 5:13 PM · Diffusion
epriestley added a revision to T13623: Notifications may fail to paginate with GROUP BY error: Unknown Object (Differential Revision).
Mar 12 2021, 5:08 PM · Restricted Project, Notifications

Mar 11 2021

epriestley closed T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully as Resolved by committing Restricted Diffusion Commit.
Mar 11 2021, 10:55 PM · Installing & Upgrading, Database
epriestley added a revision to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully: Unknown Object (Differential Revision).
Mar 11 2021, 10:32 PM · Installing & Upgrading, Database
epriestley added a comment to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully.

There are also already a bunch of tailored messages in other context:

Mar 11 2021, 10:30 PM · Installing & Upgrading, Database
epriestley added a comment to T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully.

I looked into this briefly, but I can't find a simple way to show all the current user's database permissions.

Mar 11 2021, 10:14 PM · Installing & Upgrading, Database
epriestley added a comment to T12919: Healthcheck endpoint for alternate file domain.

Resource (and Phame and Phurl) domains now respond to /status/.

Mar 11 2021, 10:06 PM · Files
epriestley closed T12919: Healthcheck endpoint for alternate file domain, a subtask of T13636: Some "well-known" resources can't be served from ResourceSite, as Resolved.
Mar 11 2021, 10:05 PM · Infrastructure
epriestley closed T12919: Healthcheck endpoint for alternate file domain as Resolved by committing Restricted Diffusion Commit.
Mar 11 2021, 10:05 PM · Files
epriestley closed T13636: Some "well-known" resources can't be served from ResourceSite as Resolved by committing Restricted Diffusion Commit.
Mar 11 2021, 10:05 PM · Infrastructure
epriestley added a revision to T13636: Some "well-known" resources can't be served from ResourceSite: Unknown Object (Differential Revision).
Mar 11 2021, 10:04 PM · Infrastructure
epriestley added a comment to T13636: Some "well-known" resources can't be served from ResourceSite.

(Or, rather, BlogSite and ShortSite both deal with 404s in a sensible way. They just don't route "/robots.txt", "/favicon.ico", or "/status/".)

Mar 11 2021, 9:44 PM · Infrastructure
epriestley added a comment to T13636: Some "well-known" resources can't be served from ResourceSite.

This leaves some edge cases doing less-than-ideal things:

Mar 11 2021, 9:42 PM · Infrastructure
epriestley added a revision to T13636: Some "well-known" resources can't be served from ResourceSite: Unknown Object (Differential Revision).
Mar 11 2021, 9:42 PM · Infrastructure
epriestley added a revision to T12919: Healthcheck endpoint for alternate file domain: Unknown Object (Differential Revision).
Mar 11 2021, 9:42 PM · Files
epriestley added a comment to T13636: Some "well-known" resources can't be served from ResourceSite.

A related issue is that if you 404 on the ResourceSite, you hit a cookie exception. This isn't ideal.

Mar 11 2021, 9:38 PM · Infrastructure
epriestley added a comment to T13636: Some "well-known" resources can't be served from ResourceSite.

We should probably route /robots.txt, but perhaps prevent it from accessing anything?

Mar 11 2021, 9:07 PM · Infrastructure
epriestley triaged T12919: Healthcheck endpoint for alternate file domain as Wishlist priority.
Mar 11 2021, 8:55 PM · Files
epriestley added a parent task for T12919: Healthcheck endpoint for alternate file domain: T13636: Some "well-known" resources can't be served from ResourceSite.
Mar 11 2021, 8:55 PM · Files
epriestley added a subtask for T13636: Some "well-known" resources can't be served from ResourceSite: T12919: Healthcheck endpoint for alternate file domain.
Mar 11 2021, 8:55 PM · Infrastructure
epriestley triaged T13636: Some "well-known" resources can't be served from ResourceSite as Wishlist priority.
Mar 11 2021, 8:55 PM · Infrastructure
epriestley closed T13635: JSON DocumentEngine may confuse "{}" and "[]" as Resolved.
Mar 11 2021, 8:50 PM · Infrastructure
epriestley added a revision to T13635: JSON DocumentEngine may confuse "{}" and "[]": Unknown Object (Differential Revision).
Mar 11 2021, 8:43 PM · Infrastructure
epriestley added a comment to T13628: Provide "Foist Upon", an inverse operation to "Commandeer".

I don't think those use cases are necessarily bad, there's just a little bit of a slippery slope to, say, "Git sure looks a lot like a database" and then support issues like "it's hard to manage my 3,500 automated review requests".

Mar 11 2021, 7:46 PM · Differential
epriestley added a revision to T13635: JSON DocumentEngine may confuse "{}" and "[]": Unknown Object (Differential Revision).
Mar 11 2021, 7:22 PM · Infrastructure
epriestley triaged T13635: JSON DocumentEngine may confuse "{}" and "[]" as Low priority.
Mar 11 2021, 7:06 PM · Infrastructure
epriestley added a revision to T13623: Notifications may fail to paginate with GROUP BY error: Unknown Object (Differential Revision).
Mar 11 2021, 6:34 PM · Restricted Project, Notifications
epriestley reopened T13623: Notifications may fail to paginate with GROUP BY error as "Open".

An issue arose when a user loads a page of notifications which include stories they don't have permission to view.

Mar 11 2021, 6:26 PM · Restricted Project, Notifications
epriestley triaged T13634: Support marking commits as UNREACHABLE in Mercurial as Low priority.
Mar 11 2021, 6:15 PM · Diffusion
epriestley closed T13587: Ferret may exhaust AUTO_INCREMENT ID space of "ngrams" table after many reindexes as Resolved.

Nothing new has arisen for a while, so presuming this is resolved.

Mar 11 2021, 5:52 PM · Search
epriestley moved T13501: Improve search index normalization of "é" and other characters with variants or multiple representations from Backlog to Future on the Search board.
Mar 11 2021, 5:49 PM · Search
epriestley moved T13196: Allow search cluster path value point to alias for Elasticsearch fulltext engine from Backlog to External Search on the Search board.
Mar 11 2021, 5:49 PM · Search, Elasticsearch
epriestley moved T12965: When no "master" database is configured, the ElasticSearch setup check can fatal from Backlog to External Search on the Search board.
Mar 11 2021, 5:49 PM · Database, Clusters, Search
epriestley moved T12450: New Search Configuration Errata from v2 to External Search on the Search board.
Mar 11 2021, 5:49 PM · Search
epriestley triaged T13633: Ferret searches which match very large result sets may be dominated by result ordering as Low priority.
Mar 11 2021, 5:47 PM · Search

Mar 10 2021

epriestley renamed T13632: Compile `_...` search tokens as substring searches from Compile `__X__` search tokens as substring searches to Compile `_...` search tokens as substring searches.
Mar 10 2021, 8:01 PM · Search
epriestley closed T13632: Compile `_...` search tokens as substring searches as Resolved.

Seems like it works:

Mar 10 2021, 8:01 PM · Search