Page MenuHomePhabricator
Feed Advanced Search

Sep 9 2016

epriestley accepted D16525: Check for empty output from git ls-tree.
Sep 9 2016, 2:18 AM
epriestley added a comment to T11051: "Explain Why" isn't properly explaining why revisions were closed.

Caught another case of this:

Sep 9 2016, 2:07 AM · Restricted Project, Differential, Bug Report
epriestley closed T11610: Call to a member function getCommitDetail() on a non-object as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 12:16 AM · Diffusion, Herald
epriestley closed T11607: Put inline styles on `{key ...}` for email as Resolved by committing Restricted Diffusion Commit.
Sep 9 2016, 12:11 AM · Remarkup

Sep 8 2016

epriestley added a revision to T11607: Put inline styles on `{key ...}` for email: Unknown Object (Differential Revision).
Sep 8 2016, 11:39 PM · Remarkup
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

I guess it's not particularly useful in this case anyway.

Sep 8 2016, 11:29 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

Oh, that hint only shows for accepted revisions right now.

Sep 8 2016, 11:28 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

Do they actually have dependencies declared? Any idea why the screenshot doesn't show the "Open Dependencies" marker visible here?

Sep 8 2016, 11:26 PM · Restricted Project, Differential, Feature Request
epriestley claimed T11610: Call to a member function getCommitDetail() on a non-object.
Sep 8 2016, 11:24 PM · Diffusion, Herald
epriestley added a revision to T11610: Call to a member function getCommitDetail() on a non-object: Unknown Object (Differential Revision).
Sep 8 2016, 11:21 PM · Diffusion, Herald
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 8 2016, 10:49 PM · Restricted Project, Prioritized, Calendar
joshuaspence added a comment to T11610: Call to a member function getCommitDetail() on a non-object.

I was able to reproduce on this install by passing rPf712ae718ccc1c94d882c626ca8626b77346026b to the Herald test console.

Sep 8 2016, 10:46 PM · Diffusion, Herald
joshuaspence created T11610: Call to a member function getCommitDetail() on a non-object.
Sep 8 2016, 10:46 PM · Diffusion, Herald
epriestley created T11607: Put inline styles on `{key ...}` for email.
Sep 8 2016, 8:51 PM · Remarkup
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 8 2016, 8:49 PM · Restricted Project, Prioritized, Calendar
epriestley moved T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs from Backlog to Basic on the Contributor Onboarding board.
Sep 8 2016, 8:27 PM · Contributor Onboarding
epriestley assigned T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs to jcox.
Sep 8 2016, 8:26 PM · Contributor Onboarding
epriestley closed T11396: Calendar stub events do not respect recurring event end dates as Resolved by committing Restricted Diffusion Commit.
Sep 8 2016, 5:20 PM · Restricted Project, Calendar
epriestley added a revision to T11396: Calendar stub events do not respect recurring event end dates: Unknown Object (Differential Revision).
Sep 8 2016, 4:16 PM · Restricted Project, Calendar
epriestley added a comment to T11606: Allow custom fields to accept function tokens like "viewer()".

This would be nice to have but is somewhat involved:

Sep 8 2016, 3:48 PM · Custom Fields, Typeahead, Feature Request
epriestley renamed T11606: Allow custom fields to accept function tokens like "viewer()" from Maniphest Custom-field doesn't support "Current View" function, bug or design ? to Allow custom "users" fields to accept function tokens like "viewer()".
Sep 8 2016, 3:46 PM · Custom Fields, Typeahead, Feature Request
epriestley closed T11534: Repository clustering does not respect disabled bindings? as Invalid.

From reviewing the code, it appears that this should be handled correctly already.

Sep 8 2016, 3:43 PM · Almanac, Clusters
epriestley closed T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages as Resolved.

Presuming resolved until we hear otherwise.

Sep 8 2016, 2:49 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Someone in IRC hit this on stable and I haven't seen more reports on master, so I'm going to bring the changes over.

Sep 8 2016, 2:22 PM · Setup
epriestley added a comment to T11084: LDAP Unable to Connect.

See also T4947 for some discussion of SELinux.

Sep 8 2016, 2:10 PM · Bug Report
jdforrester awarded T10339: Figure out the UI for Maniphest task search by points a Hungry Hippo token.
Sep 8 2016, 12:33 AM · Maniphest

Sep 7 2016

epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

I believe this is now fixed in HEAD of master. Let us know if you're still seeing issues.

Sep 7 2016, 6:35 PM · Restricted Project, Bug Report
epriestley closed T11604: Error adding URL to a JIRA issue the first time to Differential comment as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 6:16 PM · Restricted Project, Bug Report
epriestley added a revision to T11604: Error adding URL to a JIRA issue the first time to Differential comment : Unknown Object (Differential Revision).
Sep 7 2016, 5:51 PM · Restricted Project, Bug Report
epriestley added a comment to T10961: JIRA instructions are a bit out of date with modern JIRA.

We also say "Only supports JIRA 6" but that means "JIRA 6 or newer", since JIRA 7 works fine.

Sep 7 2016, 5:07 PM · Auth, Documentation
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Let me take a shot at it locally first, I don't immediately see a real way that D16494 could have fixed this given your repro steps.

Sep 7 2016, 4:43 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

(I'd be a little surprised if it was and it still merits a real fix even if it doesn't happen in practice anymore.)

Sep 7 2016, 4:34 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

There is a small possibility that this was "fixed" by D16494 on Sep 5.

Sep 7 2016, 4:34 PM · Restricted Project, Bug Report
epriestley closed T11583: When initializing a new database, just apply adjustments without prompting as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 4:09 PM · NUX, Setup
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.

I believe all that stuff is fixed in HEAD of master, let us know if you're still seeing issues (other than text not being searchable: it isn't currently supported). Thanks for the report!

Sep 7 2016, 4:08 PM · Bug Report
epriestley closed T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 4:08 PM · Bug Report
epriestley added a revision to T11583: When initializing a new database, just apply adjustments without prompting: Unknown Object (Differential Revision).
Sep 7 2016, 2:54 PM · NUX, Setup
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.
  • text does not support searching, and does not claim to support searching (e.g., is not listed on "Constraints"). The intent is to eventually expose fulltext/content search here rather than exact-match search.
  • We did not validate constraint keys, so it would appear that we might support searching on invalid constraints. D16507 fixes this: we now throw an explicit exception pointing at the error.
  • link does support searching, but did not handle query constraints correctly. D16508 fixes this, and it now should apply these constraints properly.
Sep 7 2016, 2:40 PM · Bug Report
epriestley added a revision to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints: Unknown Object (Differential Revision).
Sep 7 2016, 2:38 PM · Bug Report
epriestley added a revision to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints: Unknown Object (Differential Revision).
Sep 7 2016, 2:25 PM · Bug Report
epriestley closed T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows as Resolved.

Presuming this is resolved, but let us know if you're still having troulbe.

Sep 7 2016, 2:14 PM · Bug Report (Needs Information)
epriestley closed T11601: Prevent users from editing their username / real name during self-service registration as Resolved.

Presuming this is resolved, let us know if that isn't the case.

Sep 7 2016, 2:14 PM · Feature Request
epriestley renamed T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows from arc diff crashes with exception to libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.
Sep 7 2016, 2:07 PM · Bug Report (Needs Information)
epriestley added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

I believe this is fixed in HEAD of master. Update libphutil (by running git pull in libphutil/) and let us know if you're still seeing issues?

Sep 7 2016, 2:07 PM · Bug Report (Needs Information)
epriestley closed T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 2:06 PM · Diffusion, Daemons
epriestley closed T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses, a subtask of T4551: consider allowing SIGTERM for ExecFuture timeout, as Resolved.
Sep 7 2016, 2:06 PM · libphutil
epriestley added a revision to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows: Unknown Object (Differential Revision).
Sep 7 2016, 2:04 PM · Bug Report (Needs Information)
epriestley merged task T11602: arc patch D1234 crashes with exception when D1234 does not exist into T8937: Unclear exception when patching non-existant revision.
Sep 7 2016, 1:59 PM · Bug Report
epriestley merged T11602: arc patch D1234 crashes with exception when D1234 does not exist into T8937: Unclear exception when patching non-existant revision.
Sep 7 2016, 1:59 PM · Arcanist
epriestley added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

I think I broke this in D16504, I'll fix it shortly.

Sep 7 2016, 1:57 PM · Bug Report (Needs Information)
pouyana awarded T4558: Make Diviner useful for third-parties a Mountain of Wealth token.
Sep 7 2016, 10:25 AM · Diviner
epriestley closed T4551: consider allowing SIGTERM for ExecFuture timeout as Resolved.

Changes associated with T11592 probably fix this in practice. The new behavior is transparent: subprocesses get SIGTERM at the timeout, and SIGKILL a little while later if they fail to exit.

Sep 7 2016, 1:24 AM · libphutil
epriestley added a revision to T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses: Unknown Object (Differential Revision).
Sep 7 2016, 1:18 AM · Diffusion, Daemons
epriestley added a revision to T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses: Unknown Object (Differential Revision).
Sep 7 2016, 1:01 AM · Diffusion, Daemons

Sep 6 2016

epriestley added a comment to T11571: Consider benchmarking hardware during setup.

We can just query that as a setup check, although I don't recall too many issues with it recently.

Sep 6 2016, 11:28 PM · Setup
epriestley renamed T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints from maniphest.search with link/text constraints return all tasks, instead of the ones that match to *.search Conduit API methods with invalid constraints silently ignore the constraints.
Sep 6 2016, 11:26 PM · Bug Report
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.

Oh, this isn't expected to work. These don't currently expose a constraint. You can find an exhaustive list of constraints in the "Custom Query Constraints" table on the API page, and no constraint will be listed for these fields.

Sep 6 2016, 11:25 PM · Bug Report
epriestley added a comment to T11601: Prevent users from editing their username / real name during self-service registration.

(The $profile object is a PhabricatorRegistrationProfile and has a few other methods available.)

Sep 6 2016, 10:07 PM · Feature Request
epriestley added a comment to T11601: Prevent users from editing their username / real name during self-service registration.

This is possible today, although only via the older events API:

Sep 6 2016, 10:05 PM · Feature Request
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

I believe this is fixed in HEAD of master now. Let me know if things look good on your end and I'll cherry-pick the fixes to stable?

Sep 6 2016, 9:21 PM · Setup
epriestley closed T11596: Phacility export process removes data from S3 which may still be referenced as Resolved.

I cherry-picked those fixes to stable, created a test instance (test-on6dfrmgkt7t), uploaded a 100KB file which went to S3, exported the instance, and got a clean export with the file data retained on the instance.

Sep 6 2016, 8:59 PM · Files, Phacility
epriestley closed T11596: Phacility export process removes data from S3 which may still be referenced, a subtask of T7148: Allow users to export their data from Phacility, as Resolved.
Sep 6 2016, 8:59 PM · Phacility
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 8:53 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 8:25 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 7:59 PM · Setup
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

To this use case more broadly, Spaces is the best tool we have today but may not be a perfect solution. From elsewhere, here's general thinking on this today (this was originally a response to a request about T8442):

Sep 6 2016, 7:39 PM · Feature Request
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 7:29 PM · Setup
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

We've iterated through a few versions of instruction lengths without much luck, and an older version of the form had a bit more text upfront but didn't seem to have any impact.

Sep 6 2016, 7:17 PM · Feature Request
epriestley closed T11405: Need to watch the project programmatically as Invalid.

We haven't received more information about this in more than a month.

Sep 6 2016, 6:50 PM · Feature Request (Needs Information), Conduit
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

My goal is to fix this process so that we don't have to go through it over and over and over again.

Sep 6 2016, 6:45 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Even if you don't make it to Describing Root Problems and miss the huge red header in Contributing Feature Requests, that document has a large amount of text with the same message:

Sep 6 2016, 6:24 PM · Feature Request
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 6:11 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Here's my general plan of attack here:

Sep 6 2016, 6:06 PM · Setup
epriestley merged task T11598: "Plan changes" doesn't clear comments into T11114: Move Differential to EditEngine.
Sep 6 2016, 5:36 PM · Bug Report
epriestley merged T11598: "Plan changes" doesn't clear comments into T11114: Move Differential to EditEngine.
Sep 6 2016, 5:36 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T11598: "Plan changes" doesn't clear comments.

This will be fixed when Differential moves to EditEngine, covered by T11114. I'm going to merge this there.

Sep 6 2016, 5:36 PM · Bug Report
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Here's roughly the request we would have liked to see instead of the request you actually filed:

Sep 6 2016, 5:33 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

How common is it that a developer is only allowed to see company A, and not see company B? Is this common, or can most employees see all or almost all of the information about companies and you mostly want to prevent employees of company A from seeing information about company B and vice versa?

Sep 6 2016, 4:54 PM · Feature Request
epriestley added a comment to T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs.

The goal is to provide an easy way for us to print messages like this:

Sep 6 2016, 4:39 PM · Contributor Onboarding
epriestley edited projects for T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs, added: Contributor Onboarding; removed Bug Report.
Sep 6 2016, 4:30 PM · Contributor Onboarding
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

Sorry, we never have any idea. See Planning for discussion.

Sep 6 2016, 4:05 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Why shouldn't a developer be a member of a project they are working on?

Sep 6 2016, 4:02 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

They will be working on multiple projects.

Sep 6 2016, 3:54 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

In this case, we have a new developer and he needs to be added to multiple projects.

Sep 6 2016, 3:51 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

I'm going to ask you a series of questions to figure out what your actual root problem is. When we're done, I'd like you to explain why you didn't just describe it in the first place after reading Describing Root Problems, and how we could improve that document so that you would have gone through this process on your own, umprompted, without requiring me to spend time asking you questions instead of improving Phabricator.

Sep 6 2016, 3:45 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

You've read that documentation and this request represents a sincere effort to follow the instructions it contains?

Sep 6 2016, 3:31 PM · Feature Request
epriestley closed T11597: Adding a user to multiple groups would save a lot of time as Invalid.

Please see Contributing Feature Requests for help submitting a feature request. Thanks!

Sep 6 2016, 3:19 PM · Feature Request
epriestley added a revision to T11596: Phacility export process removes data from S3 which may still be referenced: Unknown Object (Differential Revision).
Sep 6 2016, 2:37 PM · Files, Phacility
epriestley added a subtask for T7148: Allow users to export their data from Phacility: T11596: Phacility export process removes data from S3 which may still be referenced.
Sep 6 2016, 2:25 PM · Phacility
epriestley added a parent task for T11596: Phacility export process removes data from S3 which may still be referenced: T7148: Allow users to export their data from Phacility.
Sep 6 2016, 2:25 PM · Files, Phacility
epriestley created T11596: Phacility export process removes data from S3 which may still be referenced.
Sep 6 2016, 2:17 PM · Files, Phacility
epriestley renamed T11595: PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application") from Customize Menu show all applications to PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application").
Sep 6 2016, 1:41 PM · Contributor Onboarding, Bug Report
epriestley moved T11595: PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application") from Backlog to Basic on the Contributor Onboarding board.
Sep 6 2016, 1:40 PM · Contributor Onboarding, Bug Report
epriestley assigned T11595: PhabricatorApplicationDatasource returns applications which have been uninstalled (e.g., in "Pin Application") to jcox.

In PhabricatorApplicationDatasource, do a PhabricatorApplication::isClassInstalledForViewer(...) test on each application and skip it if it is not installed. You can get the class name with get_class($application_object).

Sep 6 2016, 1:40 PM · Contributor Onboarding, Bug Report

Sep 5 2016

epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

I think there's another one of these in DivinerAtomController->composeTasks(). The other getDocblockMetaValue() calls anywhere in the codebase are also suspicious.

Sep 5 2016, 7:41 PM · Bug Report
epriestley closed T11584: Phame commenting policy checks are weird? as Resolved by committing Restricted Diffusion Commit.
Sep 5 2016, 7:10 PM · Phame
epriestley added a revision to T11584: Phame commenting policy checks are weird?: Unknown Object (Differential Revision).
Sep 5 2016, 6:52 PM · Phame
epriestley added a comment to T11584: Phame commenting policy checks are weird?.

Oh man -- I didn't notice that the random test account I was logged in as in Chrome (named wwwuuu) was an administrator. I have a repro.

Sep 5 2016, 6:47 PM · Phame
epriestley closed T11590: "Repository Servers" panel in Config incorrectly displaying out-of-date leader information? as Resolved by committing Restricted Diffusion Commit.
Sep 5 2016, 6:10 PM · Clusters
epriestley added a revision to T11590: "Repository Servers" panel in Config incorrectly displaying out-of-date leader information?: Unknown Object (Differential Revision).
Sep 5 2016, 5:39 PM · Clusters