Page MenuHomePhabricator
Create Task
Maniphest T11584

Phame commenting policy checks are weird?
Closed, ResolvedPublic
Actions

Description

From @chad:

I logged into my Tide account here and couldn't comment on a Dev log post, when I click submit, it gives me cant edit dialog.

I haven't been able to figure out how to reproduce this locally but can presumably hunt it down from there.

Revisions and Commits

rP Phabricator
D16493rP4b6da9735ba7 Remove overbearing policy checks in Phame

Event Timeline

epriestley created this task.Sep 3 2016, 7:13 PM
Herald added a subscriber: eadler. · View Herald TranscriptSep 3 2016, 7:13 PM
tide added a subscriber: tide.Sep 3 2016, 8:08 PM

pasted_file (646×1 px, 91 KB)

tide added a comment.Sep 3 2016, 8:08 PM

J772

Luke081515.2 added a subscriber: Luke081515.2.Sep 4 2016, 12:03 AM
chad added a comment.Sep 4 2016, 2:16 AM

I poked a bit at this, but I think PhamePost is a special case, since it doesn't have a direct edit policy, it's edit policy is derived from PhameBlog and it's not clear to me how comment transactions get around edit policy in general reading through the code.

aklapper added a subscriber: aklapper.Sep 4 2016, 1:01 PM
epriestley added a comment.Sep 5 2016, 6:47 PM

Oh man -- I didn't notice that the random test account I was logged in as in Chrome (named wwwuuu) was an administrator. I have a repro.

epriestley added a revision: D16493: Remove overbearing policy checks in Phame.Sep 5 2016, 6:52 PM
epriestley closed this task as Resolved by committing rP4b6da9735ba7: Remove overbearing policy checks in Phame.Sep 5 2016, 7:10 PM
epriestley added a commit: rP4b6da9735ba7: Remove overbearing policy checks in Phame.
Phabricator · Built by Phacility