Page MenuHomePhabricator
Feed Advanced Search

Mar 15 2016

epriestley added a comment to T10262: Scramble file secrets when attached objects change their view policies.

I'm strongly resistant to that, see T8227.

Mar 15 2016, 4:00 PM · Restricted Project, Restricted Project, Wikimedia, Files
tvl awarded T7652: Reverse Proxy - cookie issue a Like token.
Mar 15 2016, 3:58 PM · Setup
epriestley added a comment to T10593: test.

(That was a race, not me separately correcting the status, if it wasn't obvious.)

Mar 15 2016, 3:50 PM · Bug Report
epriestley added a comment to T10593: test.

Truly, we have closed this task.

Mar 15 2016, 3:50 PM · Bug Report
epriestley added a comment to T10591: viewing D8084 on this install results in InvalidArgumentException.

That is a cool looking bug.

Mar 15 2016, 3:50 PM · Bug Report
epriestley changed the status of T10593: test from Invalid to Spite.
Mar 15 2016, 3:49 PM · Bug Report
epriestley closed T10591: viewing D8084 on this install results in InvalidArgumentException as Resolved by committing Restricted Diffusion Commit.
Mar 15 2016, 3:19 PM · Bug Report
epriestley closed T10590: Improve usability of autocomplete Textfields without Javascript as Wontfix.

We do not support disabling Javascript and have no plans to improve Phabricator for users who intentionally disable Javascript. These users should enable Javascript if they want to use Phabricator.

Mar 15 2016, 3:18 PM · Feature Request
epriestley added a revision to T10591: viewing D8084 on this install results in InvalidArgumentException: Unknown Object (Differential Revision).
Mar 15 2016, 3:17 PM · Bug Report
epriestley added a comment to T10589: Create useable search experience for Maniphest.

by default, all search terms should be AND'ed instead of OR'ed

Mar 15 2016, 1:21 PM · Feature Request
epriestley added a comment to T10488: support https.blindly-trust-domains in phabricator.

For completeness, note that this opens up a sliver of a DNS rebinding SSRF attack window (see T6755 and T6755#103700 in particular).

Mar 15 2016, 12:53 PM · Restricted Project
epriestley added a comment to T7789: Support Git Large File Storage.

Before I forget:

Mar 15 2016, 12:29 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a parent task for T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: T7789: Support Git Large File Storage.
Mar 15 2016, 12:26 PM · Diffusion (v3), Restricted Project
epriestley added a subtask for T7789: Support Git Large File Storage: T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Mar 15 2016, 12:26 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

Adjacent work:

Mar 15 2016, 12:26 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley updated subscribers of T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Mar 15 2016, 12:26 PM · Diffusion (v3), Restricted Project
epriestley merged task T9739: Git push failure over HTTP for large commit (74MB) into T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Mar 15 2016, 12:26 PM · Diffusion, Git
epriestley added a comment to T7789: Support Git Large File Storage.

Various notes from prototyping:

Mar 15 2016, 12:17 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T2383: Run PHP environment checks from CLI.

T10586 is likely a second case (similar to T7248) of a user without mysql or mysqli.

Mar 15 2016, 11:47 AM · Setup
epriestley updated subscribers of T2383: Run PHP environment checks from CLI.
Mar 15 2016, 11:47 AM · Setup
epriestley merged task T10586: Call to undefined function mysql_real_escape_string() into T2383: Run PHP environment checks from CLI.
Mar 15 2016, 11:47 AM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

T9640 is tracking PHP7 compatibility. We haven't extensively tested Phabricator on PHP7 yet, but I believe several users are running it without any issues. We're happy to fix issues you encounter with PHP7 if you report them.

Mar 15 2016, 11:46 AM · Setup, Bug Report
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

Is that output from the version of PHP with a problem, or from PHP 5.6.17?

Mar 15 2016, 11:13 AM · Setup, Bug Report
epriestley closed T10587: test as Spite.
Mar 15 2016, 9:51 AM · Database
vhbit awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Mar 15 2016, 4:42 AM · Prioritized, Restricted Project, Infrastructure
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

You should be able to do "Visible To: Members of X" already (or use Spaces, even). Tags wouldn't affect visibility.

Mar 15 2016, 2:14 AM · Projects, Passphrase, Feature Request

Mar 14 2016

epriestley added a comment to T10559: Lease Working Copy Hangs on lease failure, but should fail.

(I think that title edit is accurate, let me know if I misunderstood.)

Mar 14 2016, 11:58 PM · Drydock, Bug Report
epriestley renamed T10559: Lease Working Copy Hangs on lease failure, but should fail from Lease Working Copy Hangs to Lease Working Copy Hangs on lease failure, but should fail.
Mar 14 2016, 11:57 PM · Drydock, Bug Report
epriestley added a comment to T5568: Support `.arcunit`, similar to `.arclint`.

@asteinlein, sorry, I missed your earlier question.

Mar 14 2016, 11:51 PM · Unit, Arcanist
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

This probably isn't directly related to PHP7.

Mar 14 2016, 9:40 PM · Setup, Bug Report
epriestley changed the edit policy for Changelog.
Mar 14 2016, 9:25 PM
epriestley edited the content of Changelog.
Mar 14 2016, 9:18 PM
epriestley added a comment to T10586: Call to undefined function mysql_real_escape_string().

Can you show me the output of this command on your system?

Mar 14 2016, 8:33 PM · Setup, Bug Report
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

It took 6 months before I got my first patch accepted in gerrit.

Mar 14 2016, 6:08 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Maybe notable is that these use cases seem to be completely different from the use cases discussed in D14104 (where "lightweight diffs are probably a plurality, if not majority"). There is also some possible overlap with T6008.

Mar 14 2016, 2:24 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Here's a general outline of a workflow which might satisfy everything without creating the "stomp all over new hires" tension that I want to avoid:

Mar 14 2016, 2:13 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

Here's my best effort to summarize downstream use cases for this by reading through https://phabricator.wikimedia.org/T121751 -- let me know if I'm misunderstanding, missing, or misrepresenting anything:

Mar 14 2016, 2:04 PM · Differential
epriestley added a comment to T10584: Allow users to amend revisions they don't own, without commandeering them.

To provide some background and context, we added Commandeer in D2257 to deal with use cases like this:

Mar 14 2016, 12:53 PM · Differential
epriestley added a revision to T10584: Allow users to amend revisions they don't own, without commandeering them: Unknown Object (Differential Revision).
Mar 14 2016, 12:24 PM · Differential
epriestley created T10584: Allow users to amend revisions they don't own, without commandeering them.
Mar 14 2016, 12:24 PM · Differential
• Instinct64 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 14 2016, 11:49 AM · Workboards (v3), Restricted Project
epriestley awarded T10577: Table of contents on unattached diff view lost a margin a Pterodactyl token.
Mar 14 2016, 3:25 AM · Differential
joshuaspence closed T10561: Make code coverage optional by default as Resolved.

Yep, that works. I didn't realize that null was a possible return value.

Mar 14 2016, 3:10 AM · Unit, Bug Report, Arcanist

Mar 13 2016

epriestley closed T10580: People Invites 'Advanced Search' is not very advanced. as Wontfix.

This isn't a bug, there are just no fields available.

Mar 13 2016, 10:32 PM · People, Bug Report
epriestley added a comment to T10576: Wrong highlighting for manually uploaded diff.

I didn't purge the cache here, but here's an updated version of the original diff without the rendering error:

Mar 13 2016, 4:53 PM · XHPAST, Differential, Bug Report
epriestley closed T10576: Wrong highlighting for manually uploaded diff as Resolved.
Mar 13 2016, 4:50 PM · XHPAST, Differential, Bug Report
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

(I did half a diff on tags-on-credentials yesterday but Passphrase uses a couple of unique elements (like a "password" control) that don't currently have field support in EditEngine, so conversion wasn't entirely straightfoward.)

Mar 13 2016, 4:48 PM · Projects, Passphrase, Feature Request
epriestley renamed T10575: Support project tags on Passphrase credentials from Folders or tags for Projects to Support project tags on Passphrase credentials.
Mar 13 2016, 4:47 PM · Projects, Passphrase, Feature Request
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

His reply was sent to everyone on this task (you, me, and himself).

Mar 13 2016, 4:46 PM · Projects, Passphrase, Feature Request
epriestley claimed T10576: Wrong highlighting for manually uploaded diff.
Mar 13 2016, 2:31 PM · XHPAST, Differential, Bug Report
epriestley added a comment to T10578: Provide 'Sort by Points' option in workboards.

This is made difficult by the nature of dragging cards into sorted positions on workboards: if you drag a card between a 5-point task and an 11-point task, we need to give it some number of points between 5 and 11, break the sort order of the column, or fling the card to the correct position in the column, which may be offscreen. Currently, in the simpler case of priority sorts, users don't seem to expect any of these behaviors, and all of these interactions are confusing to some users (today, we change priority).

Mar 13 2016, 2:29 PM · Workboards (v3), Feature Request
epriestley added a comment to T10576: Wrong highlighting for manually uploaded diff.

Thanks, that test case was very helpful.

Mar 13 2016, 2:17 PM · XHPAST, Differential, Bug Report
epriestley added a revision to T10576: Wrong highlighting for manually uploaded diff: Unknown Object (Differential Revision).
Mar 13 2016, 2:07 PM · XHPAST, Differential, Bug Report
epriestley created T10577: Table of contents on unattached diff view lost a margin.
Mar 13 2016, 12:54 PM · Differential
epriestley added a comment to T10575: Support project tags on Passphrase credentials.

Being rude isn't a good way to attract people to a product.

Mar 13 2016, 12:51 PM · Projects, Passphrase, Feature Request

Mar 12 2016

epriestley added a comment to T10575: Support project tags on Passphrase credentials.

or through Pholio

Mar 12 2016, 9:46 PM · Projects, Passphrase, Feature Request
epriestley edited the content of Changelog.
Mar 12 2016, 7:31 PM
epriestley edited the content of Changelog.
Mar 12 2016, 7:31 PM
epriestley edited the content of 2016 Week 11 (Mid March).
Mar 12 2016, 7:31 PM
epriestley created 2016 Week 11 (Mid March).
Mar 12 2016, 7:29 PM
epriestley updated the task description for T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T4887: Extend the blocking reviewers functionality universally: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Differential, Herald
epriestley added a subtask for T10574: A pathway toward "All Reviewers Must Accept": T4887: Extend the blocking reviewers functionality universally.
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T731: Allow revisions to have alternate acceptance conditions: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Restricted Project, Differential
epriestley added subtasks for T10574: A pathway toward "All Reviewers Must Accept": T731: Allow revisions to have alternate acceptance conditions, T9372: Plan the future of "Bucketing" Query UIs.
Mar 12 2016, 4:52 PM · FreeBSD, Restricted Project, Differential
epriestley added a parent task for T9372: Plan the future of "Bucketing" Query UIs: T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:52 PM · Restricted Project, Audit, ApplicationSearch, Differential
epriestley created T10574: A pathway toward "All Reviewers Must Accept".
Mar 12 2016, 4:51 PM · FreeBSD, Restricted Project, Differential
epriestley closed T10570: Default quote action breaks tables as Resolved by committing Restricted Diffusion Commit.
Mar 12 2016, 3:57 PM · Wikimedia, Maniphest, Bug Report
epriestley closed T10539: Email not respecting TO and CC as Resolved by committing Restricted Diffusion Commit.
Mar 12 2016, 3:30 PM · Mail, Restricted Project, Bug Report
epriestley added a comment to T10571: Default quote action breaks text between lists.

This one's slightly trickier than T10570 because leading whitespace is semantic in lists.

Mar 12 2016, 3:09 PM · Remarkup, Wikimedia
epriestley added a revision to T10570: Default quote action breaks tables: Unknown Object (Differential Revision).
Mar 12 2016, 3:07 PM · Wikimedia, Maniphest, Bug Report
epriestley added a comment to T10565: Make Phriction articles accessible via version control or arc.

Thanks for the feature request! This feature request doesn't have the information we need to move forward, so I'd like to start by trying to understand why it doesn't. Specifically, it does not describe the root problem you are facing, and instead asks for a specific feature.

Mar 12 2016, 2:50 PM · Phriction, Feature Request
epriestley claimed T10539: Email not respecting TO and CC .
Mar 12 2016, 1:25 PM · Mail, Restricted Project, Bug Report
epriestley updated the task description for T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:03 PM · Mercurial, Diffusion
epriestley merged T10573: Show Mercurial bookmarks in Diffusion into T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion
epriestley merged task T10573: Show Mercurial bookmarks in Diffusion into T1130: Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion, Feature Request
epriestley renamed T1130: Add Mercurial tag/bookmark support to Diffusion from Add Mercurial tag support to Diffusion to Add Mercurial tag/bookmark support to Diffusion.
Mar 12 2016, 1:02 PM · Mercurial, Diffusion
epriestley added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

Ah, you're right, thanks! I misread that page -- that does make Mercurial tags a lot easier to deal with.

Mar 12 2016, 1:02 PM · Mercurial, Diffusion
wschroo awarded T10333: Add groups to workboard columns a Like token.
Mar 12 2016, 8:28 AM · Restricted Project, Restricted Project, Workboards (v3)
zhiyuchen awarded T10333: Add groups to workboard columns a Like token.
Mar 12 2016, 12:42 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T10569: Subproject tasks in parent project backlog.

Make it possible to add "subproject columns" in the parent's workboard

Mar 12 2016, 12:23 AM · Workboards, Projects, Feature Request
epriestley added a revision to T10539: Email not respecting TO and CC : Unknown Object (Differential Revision).
Mar 12 2016, 12:04 AM · Mail, Restricted Project, Bug Report

Mar 11 2016

epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 11 2016, 11:47 PM · Nuance (v1)
epriestley closed T10572: Call to undefined function msortv() as Resolved.
Mar 11 2016, 11:37 PM · Bug Report
epriestley added a comment to T10572: Call to undefined function msortv().

What version is libphutil at? This function was introduced in 821cad81.

Mar 11 2016, 11:31 PM · Bug Report
sweenzor awarded T7789: Support Git Large File Storage a Love token.
Mar 11 2016, 8:34 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T10566: Selecting custom policy does not show policy editor.

Yeah, persistent details would be helpful. My best guess at repro steps from the screenshot is:

Mar 11 2016, 6:27 PM · Policy, Bug Report
magnetik awarded T10364: Conpherence v4 (UI/UX) a Mountain of Wealth token.
Mar 11 2016, 9:02 AM · Conpherence (v4)
epriestley added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

It needs a pile o' JS since it needs to change as you drag stuff around, but we can start with that.

Mar 11 2016, 2:48 AM · Maniphest
epriestley closed T10546: Time Tracking info no longer shown in Maniphest tasks as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 2:45 AM · Phrequent, Bug Report
epriestley closed T10556: edit policy message as Invalid.

I'm going to close this since there's no pathway forward that I can see. We might just not understand your request.

Mar 11 2016, 2:23 AM · Bug Report
epriestley closed T10549: Getting PhutilTypeCheckException on certaion Differential pages as Resolved by committing Restricted Diffusion Commit.
Mar 11 2016, 2:16 AM · Differential, Bug Report
epriestley added a revision to T10546: Time Tracking info no longer shown in Maniphest tasks: Unknown Object (Differential Revision).
Mar 11 2016, 2:14 AM · Phrequent, Bug Report
epriestley added a comment to Q335: Is it possible to set a default # of points on Maniphest tasks....

I slightly miss the card counts too, since we have points enabled on this install but don't really use them.

Mar 11 2016, 2:06 AM · Maniphest
epriestley claimed T10546: Time Tracking info no longer shown in Maniphest tasks.

I'm going to write a CurtainExtension for it (I just missed it in the original round) but you might have to fix my bad stylin'.

Mar 11 2016, 1:42 AM · Phrequent, Bug Report
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I'll leave this open for now since the behavior still feels a bit spooky to me, let me know how things go once you get the key in place? If they're smooth, we can chalk this up to be being bad at MySQL.

Mar 11 2016, 1:41 AM · Infrastructure
epriestley added a revision to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Unknown Object (Differential Revision).
Mar 11 2016, 1:36 AM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I suppose the originally proposed key may be better than I think. I was imagining that it couldn't use the third part of the key (on changeType) but I suppose it actually can. I'm still confused by the UNION ALL behavior, but if the key's working on your dataset I think it's fine to add it -- it takes <1 second to add to our dataset, so even for large datasets it shouldn't be wildly unreasonable, even if we do find a better key later.

Mar 11 2016, 1:32 AM · Infrastructure
epriestley added a comment to T10564: Mail "Delivery" tab is confusing..

I'm seeing a replay of the (current?) rules about this message?

Mar 11 2016, 1:26 AM · Restricted Project, Mail, Bug Report
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

That's fine -- it looks like it's picking up the keys, I'm just not sure why it's then examining 303 million rows when it has the keys available.

Mar 11 2016, 1:24 AM · Infrastructure