Page MenuHomePhabricator
Feed Advanced Search

Aug 20 2015

epriestley edited the content of Adding Hardware.
Aug 20 2015, 2:24 PM
epriestley edited the content of Adding Hardware.
Aug 20 2015, 2:24 PM
epriestley edited the content of Phacility Cluster Devices.
Aug 20 2015, 2:23 PM
epriestley added Q98: Tasks with `null` data: Normal or a sign of breakage? (Answer 114).
Aug 20 2015, 1:03 PM
epriestley changed the image for Image Macro "ohkay".
Aug 20 2015, 12:53 PM
joshuaspence added a comment to T8258: Allow comments in JSON.

I want to work on this eventually but I haven't had the time.

Aug 20 2015, 12:42 PM · Restricted Project, libphutil, Arcanist
epriestley triaged T9222: Arc upgrade returns success message when it failed as Low priority.
Aug 20 2015, 11:45 AM · Restricted Project, Arcanist
epriestley created T9231: Detail link in badge email is very, very, wrong.
Aug 20 2015, 11:44 AM · Badges
epriestley added a comment to T9222: Arc upgrade returns success message when it failed.

This error handling block is incorrect:

Aug 20 2015, 11:42 AM · Restricted Project, Arcanist
epriestley added a comment to T9223: Allow `arc diff` to run a build step like `gradle` first, then read lint and unit messages from the output.

The general plan here is to switch unit test configuration to an .arcunit file by default (T5568). This technically works today but isn't quite ready for use yet.

Aug 20 2015, 11:37 AM · Unit, Arcanist
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Aug 20 2015, 11:28 AM
epriestley edited this Badge.
Aug 20 2015, 11:28 AM
epriestley edited this Badge.
Aug 20 2015, 11:26 AM
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Aug 20 2015, 11:19 AM
epriestley closed T9225: Wrong pluralization ("branchs") in an arc land message as Resolved by committing Restricted Diffusion Commit.
Aug 20 2015, 11:19 AM · Arcanist
epriestley added a comment to T9224: Probably add "Event Host" and "Event Invitees" Object Policies to Calendar Events.

Yeah, there's no separation of Join/View policies currently.

Aug 20 2015, 11:14 AM · Policy, Calendar
epriestley closed T9229: Task as Invalid.
Aug 20 2015, 9:44 AM · Phacility High Command
epriestley closed T9228: Task as Invalid.
Aug 20 2015, 9:44 AM
epriestley closed T9227: Task as Invalid.
Aug 20 2015, 9:44 AM · Facebook

Aug 19 2015

joshuaspence added a revision to T8742: Write a bunch of PSR-2 lint rules: Unknown Object (Differential Revision).
Aug 19 2015, 9:39 PM · Lint
joshuaspence added a revision to T8742: Write a bunch of PSR-2 lint rules: Unknown Object (Differential Revision).
Aug 19 2015, 9:39 PM · Lint
rftfaria awarded T4947: SELinux / AppArmor ruin everything all the time a Like token.
Aug 19 2015, 4:04 PM · Setup
epriestley closed T9221: My example as Resolved.

It is done.

Aug 19 2015, 2:34 PM
rftfaria awarded T4548: Support "Mylyn" Eclipse plugin a Like token.
Aug 19 2015, 2:25 PM · Feature Request, Maniphest
• valezin awarded T4548: Support "Mylyn" Eclipse plugin a Like token.
Aug 19 2015, 2:23 PM · Feature Request, Maniphest
epriestley closed T9214: ArcanistPyLintLinter.php has superfluous quotations around the "msg-template" options. as Resolved.

Presuming resolved since D13931 is in HEAD. Thanks for the report!

Aug 19 2015, 1:54 PM · Lint, Arcanist
epriestley added a comment to T9187: Phacility Cluster: Daemons outpaced log compaction.

D13939 will fix T8672, the most immediate cause of high log volumes, but I'm going to hold it until after we cut the release since it also raises the urgency of potential existing errors.

Aug 19 2015, 1:44 PM · Ops, Phacility
epriestley moved T9187: Phacility Cluster: Daemons outpaced log compaction from Backlog to Do After Launch on the Phacility board.
Aug 19 2015, 1:40 PM · Ops, Phacility
epriestley added a comment to T4947: SELinux / AppArmor ruin everything all the time.

See T9213 for another case of htis.

Aug 19 2015, 1:39 PM · Setup
epriestley added a revision to T9218: Should Owners allow multiple packages to own the same file?: Unknown Object (Differential Revision).
Aug 19 2015, 1:37 PM · Owners
epriestley added a comment to D13927: Handle application transactions with null data..

I folded this into D13939, which also fixes the root problem (hopefully). It ended up with a LiskDAO change so I want to wait until after we cut the stable branch on Saturday morning.

Aug 19 2015, 1:15 PM
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Aug 19 2015, 1:11 PM
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Aug 19 2015, 1:11 PM
epriestley added a revision to T8672: PhabricatorTaskmasterDaemon fatals in PublishWorker: Unknown Object (Differential Revision).
Aug 19 2015, 1:10 PM · Diffusion, Daemons
epriestley added a revision to T9187: Phacility Cluster: Daemons outpaced log compaction: Unknown Object (Differential Revision).
Aug 19 2015, 1:10 PM · Ops, Phacility
epriestley added a comment to T9218: Should Owners allow multiple packages to own the same file?.

Ah, thanks! That use case makes sense to me too.

Aug 19 2015, 12:53 PM · Owners
epriestley added a comment to T9212: Community Feedback: How should we handle free support?.

Yeah, I think we should end real-time support for the general public.

Aug 19 2015, 3:54 AM · Public & Media Relations, Support
epriestley added a comment to T8143: Allow creation of Conduit API Tokens for bots.

Use arc call-conduit, not arc install-certificate.

Aug 19 2015, 12:33 AM · Conduit
epriestley closed T8143: Allow creation of Conduit API Tokens for bots as Resolved.

Use --conduit-token.

Aug 19 2015, 12:21 AM · Conduit

Aug 18 2015

epriestley added a comment to T9218: Should Owners allow multiple packages to own the same file?.

I think the answer for "A" and "B" is almost certainly that both packages still own the file, and the more specific claim made by "B" does not invalidate the claim made by "A". In particular, "A" can add paths in "B" with 'exclude' rules if the intent is truly for "B" to exclusively own the files.

Aug 18 2015, 9:41 PM · Owners
epriestley created T9218: Should Owners allow multiple packages to own the same file?.
Aug 18 2015, 9:32 PM · Owners
epriestley added a comment to T7073: The meaning of the login icon is not clear.

Finding the "Create Task" button on the Maniphest page is indeed easy on this installation of Phabricator, but it's (at least for me) harder on the WMF one

Aug 18 2015, 9:18 PM
epriestley added a comment to T9216: arc diff says "no changes" if I've pushed my branch to remote.

Specifically, I think I want arc to have this default behavior instead:

Aug 18 2015, 9:02 PM · Arcanist
epriestley added a comment to T8117: Choose the most straightforward possible name for a package management application.

It's definitely little uncool, but not needing a binary makes it a bit less relevant.

Aug 18 2015, 8:48 PM
epriestley added a comment to T9216: arc diff says "no changes" if I've pushed my branch to remote.

Broadly, if no explicit base rule is configured telling arc what it should actually do, we try to guess a bunch of "reasonable" things, including the tracked upstream branch if one exists. The word "reasonable" here means "someone filed a feature request asking for it early in the lifecycle of the project before we got strict about not accepting this kind of stuff".

Aug 18 2015, 8:39 PM · Arcanist
epriestley added a comment to T9216: arc diff says "no changes" if I've pushed my branch to remote.

To make arc diff do that, run this command:

Aug 18 2015, 8:37 PM · Arcanist
epriestley added a comment to T9216: arc diff says "no changes" if I've pushed my branch to remote.

Oh, I suppose you pretty much answered that:

Aug 18 2015, 8:33 PM · Arcanist
epriestley added a comment to T8117: Choose the most straightforward possible name for a package management application.

huh? wut?

Aug 18 2015, 8:31 PM
epriestley renamed T8117: Choose the most straightforward possible name for a package management application from Choose a cool name for a package management application to Choose the most straightforward possible name for a package management application.
Aug 18 2015, 8:31 PM
epriestley added a comment to T9216: arc diff says "no changes" if I've pushed my branch to remote.

Does that output make sense in explaining what arc diff is doing, or not so much?

Aug 18 2015, 8:24 PM · Arcanist
epriestley added a comment to T9215: Show badges in Ponder Answers.

I don't want to put badges on handles since I anticipate some badges being awarded by context later (e.g., maybe a "Task Author" badge, or "Ponder Moderator" -- these badges would only show in some contexts). If we do want to do that eventually, handles won't have enough information to know how to build them, since handles don't know which page/object they're loading for.

Aug 18 2015, 8:06 PM · Restricted Project, Ponder
epriestley added a comment to T9216: arc diff says "no changes" if I've pushed my branch to remote.

Can you show me what arc which says?

Aug 18 2015, 8:03 PM · Arcanist
epriestley added a comment to T9215: Show badges in Ponder Answers.

We should fix the bug where badges don't show for stuff like this, too:

Aug 18 2015, 8:02 PM · Restricted Project, Ponder
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

From T8117, I think we can just call this "Packages", and rename the Owners objects (perhaps to "Claims") if there's confusion.

Aug 18 2015, 7:50 PM · Arcanist
epriestley closed T8117: Choose the most straightforward possible name for a package management application as Resolved.

I think we aren't actually going to have a standalone binary for this (i.e., the CLI will just be arc install, etc., with a possible bin/whatever standalone in Phabricator that doesn't need namespacing) so I suppose we can just call it "Packages".

Aug 18 2015, 7:43 PM
epriestley closed T8117: Choose the most straightforward possible name for a package management application, a subtask of T8116: Prototype a package management application, as Resolved.
Aug 18 2015, 7:43 PM
epriestley added a comment to D13927: Handle application transactions with null data..

This is T8672. The exact chain of events for the most common case of this is:

Aug 18 2015, 7:23 PM
epriestley added a comment to T9159: You may not set new credentials after authenticating conduit.

Policy settings, or policy settings on the repositories they belong to? Or ghosts.

Aug 18 2015, 7:15 PM · Arcanist
epriestley closed T9167: Simplify destroying wiki pages as Wontfix.

It sounds like T6004 would obsolete this.

Aug 18 2015, 7:14 PM · Phriction
epriestley added a comment to T9031: When I ignore subscription changes, I'm not notified of being cc'ed.

If it was an actual mention, you'd presumably get the mail under the "comment" rule, although it's possible the user in question has also disabled comment mail.

Aug 18 2015, 7:03 PM · Mail, Notifications
epriestley updated subscribers of T9214: ArcanistPyLintLinter.php has superfluous quotations around the "msg-template" options..

I think this change is correct and the analysis backing it up looks accurate.

Aug 18 2015, 6:56 PM · Lint, Arcanist
epriestley added a comment to T9206: Herald unable to place task up for grabs.

In the past, the bulk editor worked like this under a similar theory (and or laziness, I don't remember which contributed more), but we had at least one (and maybe a few? I don't recall offhand) user who failed to guess it and didn't even try the interaction in the bulk editor.

Aug 18 2015, 6:41 PM · Typeahead, Herald
epriestley added a comment to T9206: Herald unable to place task up for grabs.
Aug 18 2015, 6:41 PM · Typeahead, Herald
epriestley added a comment to T9171: old maniphest_custom docs hang around, posisble confusing googlers.

In this case, we should maybe have a way to put a redirect in Diviner, since this atom has legitimately moved here:

Aug 18 2015, 6:10 PM · Diviner
epriestley added a comment to T9175: XHPAST doesn't build automatically.

I think using FileLock is pretty reasonable. It's a little gross, but I'm not aware of any way to do this synchronization in make itself (although it's possible there is one), and if the process doesn't have write access to the lock it isn't going to be able to run make anyway, so it shouldn't be adding new failure modes.

Aug 18 2015, 6:06 PM · XHPAST, Arcanist
epriestley added a project to T9206: Herald unable to place task up for grabs: Typeahead.
Aug 18 2015, 5:57 PM · Typeahead, Herald
epriestley triaged T9206: Herald unable to place task up for grabs as Low priority.

This behavior is currently expected: this construction means "no effect", not "place up for grabs".

Aug 18 2015, 5:56 PM · Typeahead, Herald
epriestley closed T9205: Bad loadArtifactLease parameters in Harbormaster as Resolved.

Presuming resolved but yell if you hit anything else. Thanks for the report!

Aug 18 2015, 5:47 PM · Harbormaster
epriestley added a comment to T9205: Bad loadArtifactLease parameters in Harbormaster.

I think that fixes it, let me know? I don't have the local infrastructure to actually test this build step properly yet.

Aug 18 2015, 5:43 PM · Harbormaster
epriestley added a revision to T9205: Bad loadArtifactLease parameters in Harbormaster: Unknown Object (Differential Revision).
Aug 18 2015, 5:42 PM · Harbormaster
epriestley added a project to T9212: Community Feedback: How should we handle free support?: Support.
Aug 18 2015, 5:40 PM · Public & Media Relations, Support
epriestley added a comment to T7073: The meaning of the login icon is not clear.

I think that's reasonable, the edit UI is just going to be a bit messy. In some hypothetical world, it would be nice if it were WYSIWYG-ier, maybe.

Aug 18 2015, 5:15 PM
chad awarded T9212: Community Feedback: How should we handle free support? a Evil Spooky Haunted Tree token.
Aug 18 2015, 5:05 PM · Public & Media Relations, Support
epriestley added a comment to T8434: Accommodate the "Security" workflow.

Awesome, glad to hear it!

Aug 18 2015, 4:43 PM · Wikimedia, Policy, Prioritized
epriestley created T9212: Community Feedback: How should we handle free support?.
Aug 18 2015, 4:37 PM · Public & Media Relations, Support
epriestley added a comment to T7073: The meaning of the login icon is not clear.

Here are some of the reasons we're not just adding a tooltip and calling this done:

Aug 18 2015, 2:06 PM
epriestley claimed T9205: Bad loadArtifactLease parameters in Harbormaster.
Aug 18 2015, 5:23 AM · Harbormaster
epriestley triaged T9205: Bad loadArtifactLease parameters in Harbormaster as Normal priority.
Aug 18 2015, 5:23 AM · Harbormaster
epriestley triaged T9210: break apart Publish/Notify repo setting as Low priority.
Aug 18 2015, 5:22 AM · Restricted Project, Restricted Project, Diffusion
epriestley added a comment to T9210: break apart Publish/Notify repo setting.

I think this use case is reasonable-enough. There's no technical or product reason that the options need to be combined, use cases for separate options were just flimsy/nonexistent the last time this came up IIRC (I think I have an "I'll separate them if anyone has a reasonable use case" comment buried somewhere).

Aug 18 2015, 5:22 AM · Restricted Project, Restricted Project, Diffusion
epriestley added a comment to T7073: The meaning of the login icon is not clear.
In T7073#132726, @chad wrote:

I think it's a common pattern coming from other software that you need to make an account / login before finding a way to do anything.

Aug 18 2015, 4:58 AM
epriestley added a comment to T7073: The meaning of the login icon is not clear.

@MZMcBride, have you read the article from the documentation that @chad linked earlier?

Aug 18 2015, 4:50 AM
epriestley added a comment to T7073: The meaning of the login icon is not clear.

When I first wanted to report a bug to a project that uses Phabricator, it took me several minutes (!) to figure out how to login

Aug 18 2015, 4:21 AM

Aug 17 2015

joshuaspence updated subscribers of T8602: "Merge Duplicate Tasks" shows results in wrong order with ElasticSearch.
Aug 17 2015, 9:44 PM · Elasticsearch, Search
epriestley closed T8004: Highlight files owned by self/project when viewing revision, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
Aug 17 2015, 5:14 PM · Prioritized, Owners
epriestley closed T8004: Highlight files owned by self/project when viewing revision as Resolved by committing Restricted Diffusion Commit.
Aug 17 2015, 5:14 PM · Owners, Differential
epriestley added Q39: Show a tree view of dependent tasks? (Answer 110).
Aug 17 2015, 5:06 PM
epriestley added Q46: arc diff can't provide all code context for review in Windows. (Answer 109).
Aug 17 2015, 5:05 PM
epriestley added Q67: Conduit API: get paths modified by a commit (Answer 108).
Aug 17 2015, 5:03 PM
epriestley added Q80: Sorting Countdowns By Countdown Date (Answer 107).
Aug 17 2015, 5:01 PM
epriestley added Q82: Blocking Others queue (Answer 106).
Aug 17 2015, 5:00 PM
epriestley added Q83: Possible to modify layout of Phriction without editing the code? (Answer 105).
Aug 17 2015, 4:59 PM
epriestley added Q86: Default Dashboard for Anonymous users? (Answer 104).
Aug 17 2015, 4:59 PM
epriestley added Q88: Creating panels for the active user in general dashboard? (Answer 103).
Aug 17 2015, 4:58 PM
epriestley added Q91: How do I import Maniphest Tasks from an external system? (Answer 102).
Aug 17 2015, 4:57 PM
epriestley added a revision to T8004: Highlight files owned by self/project when viewing revision: Unknown Object (Differential Revision).
Aug 17 2015, 4:44 PM · Owners, Differential
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
Aug 17 2015, 4:14 PM · Prioritized, Owners
epriestley created T9205: Bad loadArtifactLease parameters in Harbormaster.
Aug 17 2015, 3:59 PM · Harbormaster
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
Aug 17 2015, 3:35 PM · Prioritized, Owners
nateguchi2 awarded T8783: Unprototype Nuance (v1) a Mountain of Wealth token.
Aug 17 2015, 10:15 AM · Nuance, Restricted Project