Page MenuHomePhabricator

Bad loadArtifactLease parameters in Harbormaster
Closed, ResolvedPublic

Description

1	exception 'InvalidArgumentException' with message 'Argument 1 passed to HarbormasterHostArtifact::loadArtifactLease() must be an instance of PhabricatorUser, none given, called in /opt/phabricator/src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php on line 48 and defined' in /opt/libphutil/src/error/PhutilErrorHandler.php:200
2	Stack trace:
3	#0 /opt/phabricator/src/applications/harbormaster/artifact/HarbormasterHostArtifact.php(45): PhutilErrorHandler::handleError(4096, 'Argument 1 pass...', '/opt/phabricato...', 45, Array)
4	#1 /opt/phabricator/src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php(48): HarbormasterHostArtifact->loadArtifactLease()
5	#2 /opt/phabricator/src/applications/harbormaster/worker/HarbormasterTargetWorker.php(62): HarbormasterCommandBuildStepImplementation->execute(Object(HarbormasterBuild), Object(HarbormasterBuildTarget))
6	#3 /opt/phabricator/src/infrastructure/daemon/workers/PhabricatorWorker.php(91): HarbormasterTargetWorker->doWork()
7	#4 /opt/phabricator/src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php(162): PhabricatorWorker->executeTask()
8	#5 /opt/phabricator/src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php(22): PhabricatorWorkerActiveTask->executeTask()
9	#6 /opt/libphutil/src/daemon/PhutilDaemon.php(183): PhabricatorTaskmasterDaemon->run()
10	#7 /opt/libphutil/scripts/daemon/exec/exec_daemon.php(125): PhutilDaemon->execute()
11	#8 {main}

Event Timeline

epriestley raised the priority of this task from to Needs Triage.
epriestley updated the task description. (Show Details)
epriestley added a project: Harbormaster.
epriestley added a subscriber: epriestley.
epriestley triaged this task as Normal priority.

I think that fixes it, let me know? I don't have the local infrastructure to actually test this build step properly yet.

Presuming resolved but yell if you hit anything else. Thanks for the report!