Page MenuHomePhabricator
Feed Advanced Search

Aug 17 2015

joshuaspence added a comment to T8602: "Merge Duplicate Tasks" shows results in wrong order with ElasticSearch.

Comparing the mappings before and after (with curl 'http://localhost:9200/phabricator/_mappings?pretty=true'):

Aug 17 2015, 7:21 AM · Elasticsearch, Search
joshuaspence added a comment to T8602: "Merge Duplicate Tasks" shows results in wrong order with ElasticSearch.

I've made some small progress here.

Aug 17 2015, 6:26 AM · Elasticsearch, Search
epriestley renamed T9186: CloudFront configuration is more involved than the documentation implies from Alternate file domain isn't allowed to serve files to CloudFront configuration is more involved than the documentation implies.
Aug 17 2015, 1:07 AM · Setup
epriestley closed T9201: Unhandled Exception ("InvalidArgumentException") on random Differential as Resolved.

You may want to try running the stable branch instead of master:

Aug 17 2015, 1:02 AM · Differential
epriestley added a revision to T9201: Unhandled Exception ("InvalidArgumentException") on random Differential: Unknown Object (Differential Revision).
Aug 17 2015, 12:57 AM · Differential
epriestley added a revision to T9201: Unhandled Exception ("InvalidArgumentException") on random Differential: Unknown Object (Differential Revision).
Aug 17 2015, 12:49 AM · Differential
epriestley added a comment to T9186: CloudFront configuration is more involved than the documentation implies.

Ah, sorry, I was mistaken. Our CloudFront setup is actually more involved than the documentation implies. This host has a simpler setup but uses CloudFlare, not CloudFront; CloudFlare applies weaker SSL certificate validation rules. Here's how we fix the headers before the request runs:

Aug 17 2015, 12:37 AM · Setup

Aug 15 2015

epriestley closed T2183: unify "table of contents" views between Differential and Diffusion as Resolved by committing Restricted Diffusion Commit.
Aug 15 2015, 7:57 PM · Owners, Differential, Diffusion
epriestley closed T2183: unify "table of contents" views between Differential and Diffusion, a subtask of T8004: Highlight files owned by self/project when viewing revision, as Resolved.
Aug 15 2015, 7:57 PM · Owners, Differential
epriestley closed T2183: unify "table of contents" views between Differential and Diffusion, a subtask of T5179: Unearth Differential rendering technical debt, as Resolved.
Aug 15 2015, 7:57 PM · Differential
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
Aug 15 2015, 7:54 PM · Prioritized, Owners
epriestley added a revision to T8004: Highlight files owned by self/project when viewing revision: Unknown Object (Differential Revision).
Aug 15 2015, 7:54 PM · Owners, Differential
epriestley added a revision to T2183: unify "table of contents" views between Differential and Diffusion: Unknown Object (Differential Revision).
Aug 15 2015, 6:41 PM · Owners, Differential, Diffusion
epriestley added a revision to T2183: unify "table of contents" views between Differential and Diffusion: Unknown Object (Differential Revision).
Aug 15 2015, 6:02 PM · Owners, Differential, Diffusion
epriestley added a revision to T2183: unify "table of contents" views between Differential and Diffusion: Unknown Object (Differential Revision).
Aug 15 2015, 5:54 PM · Owners, Differential, Diffusion
epriestley added a revision to T2183: unify "table of contents" views between Differential and Diffusion: Unknown Object (Differential Revision).
Aug 15 2015, 4:53 PM · Owners, Differential, Diffusion
epriestley claimed T2183: unify "table of contents" views between Differential and Diffusion.
Aug 15 2015, 4:50 PM · Owners, Differential, Diffusion
epriestley added a comment to T9186: CloudFront configuration is more involved than the documentation implies.

Generally, the expectation is:

Aug 15 2015, 3:23 PM · Setup
epriestley added a comment to T9186: CloudFront configuration is more involved than the documentation implies.

Actually, I think the setting I pointed out is unlikely to affect behavior here. I'm not sure how the request is reaching your server with a "Host" header which allows Phabricator to serve the request. Are you forcing this on the server (e.g., overwriting the inbound Host header with the "correct" header)?

Aug 15 2015, 3:16 PM · Setup
epriestley added a comment to T9186: CloudFront configuration is more involved than the documentation implies.

Is Behaviors → Edit Behaviors → Forward Headers set to "None (Improves Caching)"?

Aug 15 2015, 3:12 PM · Setup
epriestley added a comment to T9194: Arcanist allows to commit unreviewed changeset (SVN).

Specifically, the problematic workflow is this:

Aug 15 2015, 2:44 PM · Arcanist
epriestley closed T9194: Arcanist allows to commit unreviewed changeset (SVN) as Wontfix.

This workflow is inherently unsafe, and can not be made safe.

Aug 15 2015, 2:41 PM · Arcanist
epriestley closed T8659: Allow linking to an external build system from Harbormaster as Resolved by committing Restricted Diffusion Commit.
Aug 15 2015, 2:29 PM · Prioritized, Harbormaster
epriestley closed T9193: DivinerGenerateWorkflow::getDivinerAtomWorldVersion has wrong behavior after ClassMapQuery change as Resolved by committing Restricted Diffusion Commit.
Aug 15 2015, 1:59 PM · Diviner, Phacility
epriestley created T9193: DivinerGenerateWorkflow::getDivinerAtomWorldVersion has wrong behavior after ClassMapQuery change.
Aug 15 2015, 1:54 PM · Diviner, Phacility
epriestley edited the content of Changelog.
Aug 15 2015, 1:49 PM
epriestley created 2015 Week 33 (Late August).
Aug 15 2015, 1:48 PM
epriestley added a comment to T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.

From T9190, this may not actually be specific to the cluster.

Aug 15 2015, 1:19 PM · Diffusion, Phacility
epriestley merged task T9190: Unhandled Exception ("FilesystemException") - File system entity `/var/repo/PHABES/' does not exist. into T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.
Aug 15 2015, 1:19 PM · Daemons, Diffusion
epriestley updated subscribers of T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.
Aug 15 2015, 1:19 PM · Diffusion, Phacility
joshuaspence added a comment to T9161: How can we fix "too much mail"?.
In T9161#131941, @chad wrote:

My 'useful' bar for email is "would I want to reply to this".

Aug 15 2015, 12:23 AM · Restricted Project, User Preferences, Mail

Aug 14 2015

epriestley added a comment to T8659: Allow linking to an external build system from Harbormaster.

I'm going to wait until the Harbormaster doc gets split up a bit before writing details on how to use this, but here's the rough version.

Aug 14 2015, 10:04 PM · Prioritized, Harbormaster
epriestley added a revision to T8659: Allow linking to an external build system from Harbormaster: Unknown Object (Differential Revision).
Aug 14 2015, 9:56 PM · Prioritized, Harbormaster
epriestley added a comment to T7338: Build more status tools for monitoring Phacility cluster health.

Yeah, there's no way to connect a third-party tool to application-level metrics like queue length right now.

Aug 14 2015, 9:16 PM · Almanac, Phacility
epriestley added a comment to T3963: Templates in Phriction.

I don't think macros are necessarily a bad idea or anything, and they'd be an OK fix here, they just seem potentially really complicated and involved and like they're only-an-ok-fix for a handful of not-too-important issues.

Aug 14 2015, 8:26 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

The primary use case I see for {!bigproject/presentations/pitch.ppt} or {!design/mocks/notifications.pdf} is non-version-controlled resources which are potentially shared between users and updated a lot of times. But basically the same value as Drive or Dropbox: sharing files with familiar filesystem semantics so you can go look in a folder and see stuff with sensible names and non-technical users have a reasonable shot at figuring it out, too.

Aug 14 2015, 8:14 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

I suppose an example from the original ticket was:

Aug 14 2015, 8:09 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

I don't want to solve it anytime soon (and don't actually understand it, see bottom).

Aug 14 2015, 8:06 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

Even setting aside the intentional "Yes" -> "No" template edit, subtle changes to macro text over time could render it meaningless/confusing on old tasks.

Aug 14 2015, 7:55 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

So the idea is that you can either invoke a snippet as a macro, like:

Aug 14 2015, 7:54 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

Like, there's no useful {{changelog}} macro I can define, since tons of the internal text is different from page to page.

Aug 14 2015, 7:43 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

Well, what would the changelog one look like? If it looks like this:

Aug 14 2015, 7:40 PM · Phriction
epriestley added a comment to T3963: Templates in Phriction.

I can create a "weekly_changelog" template which I use in Phriction to quickly apply the common markup I use when building a new Changelog page.

Aug 14 2015, 7:32 PM · Phriction
chad awarded T9187: Phacility Cluster: Daemons outpaced log compaction a Orange Medal token.
Aug 14 2015, 7:31 PM · Ops, Phacility
epriestley added a comment to T9187: Phacility Cluster: Daemons outpaced log compaction.

I'm planning to take these corrective actions:

Aug 14 2015, 7:25 PM · Ops, Phacility
epriestley added a comment to T9187: Phacility Cluster: Daemons outpaced log compaction.

Some contributing issues:

Aug 14 2015, 7:12 PM · Ops, Phacility
epriestley added a comment to T9187: Phacility Cluster: Daemons outpaced log compaction.

I cycled the host to trigger compaction and bring everything back up, which seems to have resolved the initial issue.

Aug 14 2015, 7:00 PM · Ops, Phacility
epriestley created T9187: Phacility Cluster: Daemons outpaced log compaction.
Aug 14 2015, 6:57 PM · Ops, Phacility
epriestley added a revision to T8659: Allow linking to an external build system from Harbormaster: Unknown Object (Differential Revision).
Aug 14 2015, 4:34 PM · Prioritized, Harbormaster
epriestley merged task T9183: Policy control JS dropdown should be case-insensitive sorted into T4136: Project options shown in Policy control should be smarter and more powerful.
Aug 14 2015, 3:39 PM · Policy
epriestley updated subscribers of T4136: Project options shown in Policy control should be smarter and more powerful.
Aug 14 2015, 3:39 PM · Projects, Policy
epriestley added a comment to T9181: Add a "Ready for Review" state to diffs.

Getting arc test to use whatever method arc diff does for deciding which test suites to run

Aug 14 2015, 3:17 PM · Differential, Restricted Project
epriestley added a comment to T9181: Add a "Ready for Review" state to diffs.

Just to clarify, you really mean arc test and that isn't a typo of arc unit?

Aug 14 2015, 3:16 PM · Differential, Restricted Project
epriestley added a comment to T9180: Can't read vote answers on mobile.

In fairness, you can't dead them either.

Aug 14 2015, 3:08 PM · Badge Awarded, PHUI, Mobile, Slowvote
epriestley added a comment to T9181: Add a "Ready for Review" state to diffs.

Why are users updating revisions if they don't want reviewers to look at the changes yet?

Aug 14 2015, 2:52 PM · Differential, Restricted Project
joshuaspence created T9180: Can't read vote answers on mobile.
Aug 14 2015, 1:17 PM · Badge Awarded, PHUI, Mobile, Slowvote
epriestley closed T9179: flag queries cause exceptions as Resolved by committing Restricted Diffusion Commit.
Aug 14 2015, 1:02 PM · Flags
joshuaspence awarded T5055: Distribution mechanism for arc extensions a Mountain of Wealth token.
Aug 14 2015, 1:00 PM · Arcanist
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Aug 14 2015, 12:58 PM
epriestley added a comment to T9179: flag queries cause exceptions.

Thanks!

Aug 14 2015, 12:58 PM · Flags
epriestley claimed T9179: flag queries cause exceptions.
Aug 14 2015, 12:58 PM · Flags
epriestley added a revision to T9179: flag queries cause exceptions: Unknown Object (Differential Revision).
Aug 14 2015, 12:58 PM · Flags
epriestley added a revision to T5791: Write Herald rules for outbound mail: Unknown Object (Differential Revision).
Aug 14 2015, 12:55 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

A couple other things we could use soon in the upstream, although not requirements for v0:

Aug 14 2015, 11:37 AM · Arcanist
joshuaspence added a comment to T9175: XHPAST doesn't build automatically.

I can sorta fix with using PhutilFileLock, but it feels a bit gross. Here is something I threw together real quick: https://secure.phabricator.com/differential/diff/33545/

Aug 14 2015, 8:38 AM · XHPAST, Arcanist
joshuaspence updated subscribers of T5568: Support `.arcunit`, similar to `.arclint`.
Aug 14 2015, 8:04 AM · Unit, Arcanist
joshuaspence merged task T9174: Fix broken PhpunitTestEngine into T5568: Support `.arcunit`, similar to `.arclint`.
Aug 14 2015, 8:04 AM · Arcanist
joshuaspence added a comment to T9174: Fix broken PhpunitTestEngine.

The configuration-driven unit test engine isn't yet ready for general consumption.

Aug 14 2015, 8:03 AM · Arcanist
epriestley closed T9176: VCS access broken after update as Resolved by committing Restricted Diffusion Commit.
Aug 14 2015, 1:04 AM · Diffusion
epriestley added a comment to T9176: VCS access broken after update.

Thanks for the report! I think your analysis is correct. D13893 should fix this.

Aug 14 2015, 12:57 AM · Diffusion
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Aug 14 2015, 12:56 AM
epriestley added a revision to T9176: VCS access broken after update: Unknown Object (Differential Revision).
Aug 14 2015, 12:56 AM · Diffusion
epriestley claimed T9176: VCS access broken after update.
Aug 14 2015, 12:54 AM · Diffusion
epriestley updated subscribers of T9176: VCS access broken after update.
Aug 14 2015, 12:53 AM · Diffusion
joshuaspence created T9175: XHPAST doesn't build automatically.
Aug 14 2015, 12:46 AM · XHPAST, Arcanist

Aug 13 2015

epriestley added a subtask for T9172: Allow arc list to operate on a username: T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Aug 13 2015, 10:57 PM · Arcanist
epriestley added a parent task for T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: T9172: Allow arc list to operate on a username.
Aug 13 2015, 10:57 PM · Restricted Project, FreeBSD, Arcanist
joshuaspence added a comment to T9170: parsing giganto-normous commits causes admin headaches.

T8612 is related.

Aug 13 2015, 9:27 PM · Restricted Project, Daemons, Diffusion
joshuaspence added a comment to T9171: old maniphest_custom docs hang around, posisble confusing googlers.

I guess that we should return a 404 (or even 410)

Aug 13 2015, 9:14 PM · Diviner
joshuaspence added a comment to T9159: You may not set new credentials after authenticating conduit.

Why would it reproduce consistently for certain diffs but not for others though?

Aug 13 2015, 9:12 PM · Arcanist
epriestley added a revision to T5791: Write Herald rules for outbound mail: Unknown Object (Differential Revision).
Aug 13 2015, 6:13 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a comment to T9161: How can we fix "too much mail"?.

We do record the originator of the mail internally, and could expose it in /mail/ or bin/mail volume, etc., without much work. For example, it would be easy to add:

Aug 13 2015, 4:46 PM · Restricted Project, User Preferences, Mail
epriestley added a comment to T9161: How can we fix "too much mail"?.

bin/mail volume doesn't report what fraction of mail is generated by the user, if that's what you mean.

Aug 13 2015, 4:36 PM · Restricted Project, User Preferences, Mail
epriestley added a comment to T9161: How can we fix "too much mail"?.

Yeah. I'd also really like the objective numbers from bin/mail volume, but they won't be very good for 30 days. Maybe we just wait that long to attack the "too much email" aspect of this -- role profiles and herald outbound rules are justified on their own anyway. I'd want to get this data:

Aug 13 2015, 4:31 PM · Restricted Project, User Preferences, Mail
epriestley added a comment to T9161: How can we fix "too much mail"?.

Put another way, "send no mail by default" solves a different problem, which is "administrators complain to us that their users complain to them that they get too much email, but some of this is rooted in personal/emotional issues and has no technical/product solution".

Aug 13 2015, 4:22 PM · Restricted Project, User Preferences, Mail
epriestley added a comment to T9161: How can we fix "too much mail"?.

I think there are a lot of reasonable things we can do to make it easier to get your settings set the way you want them, but they'll only help users who have a "oh, these settings aren't very good, let me go fix them" mindset. My concern is that the root of this problem may not be users having difficulty setting things up, it's users just feeling helpless and overwhelmed by the problem for essentially personal/emotional reasons which we can't easily fix.

Aug 13 2015, 4:20 PM · Restricted Project, User Preferences, Mail
epriestley added a comment to T9161: How can we fix "too much mail"?.

One thing that I'll probably do for Herald, at least, is group some of the tags up so you can write this rule:

Aug 13 2015, 3:47 PM · Restricted Project, User Preferences, Mail
epriestley added Q36: Is someone interested by YubiKey authentication? (Answer 101).
Aug 13 2015, 3:41 PM
epriestley updated the answer details for Q32: If I have metamta.maniphest.public-create-email enabled, how can I assign all submitted-by-email tasks to a particular user? (Answer 42).
Aug 13 2015, 3:40 PM
epriestley added Q31: Is there an easy way to extend Phabricator with external code? (Answer 100).
Aug 13 2015, 3:39 PM
epriestley added a comment to T9159: You may not set new credentials after authenticating conduit.

I think arc patch has some old, sketchy code around authentication. The problem is that arc patch is currently unique in that it wants to use authentication if it's available, but does not require it. This never really got built properly and is kind of a hack job.

Aug 13 2015, 3:36 PM · Arcanist
epriestley added a comment to T9161: How can we fix "too much mail"?.

I'm close to interacting with this stuff on Herald outbound rules -- do you have a general attitude toward the future of mail tags?

Aug 13 2015, 3:17 PM · Restricted Project, User Preferences, Mail
epriestley added a comment to T9143: arc land hangs if git pre-push hook creates child daemon processes.

Cool, thanks for the followup!

Aug 13 2015, 3:10 PM · Arcanist
epriestley closed T9162: Mark users with external accounts in the UI as Wontfix.

I think projects/badges are a better approach for this.

Aug 13 2015, 3:03 PM · Badges, Auth
epriestley added a comment to T9163: Ability to award Badges based on Project.

Do you want this capability in general, or all your intended use cases also account attributes (e.g., administrators)?

Aug 13 2015, 3:00 PM · Badges, Projects
epriestley merged T9166: Option to set/override email notification preferences on a self-hosted Phabricator instance into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Aug 13 2015, 2:59 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley merged task T9166: Option to set/override email notification preferences on a self-hosted Phabricator instance into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Aug 13 2015, 2:59 PM · User Preferences
epriestley added a comment to T9166: Option to set/override email notification preferences on a self-hosted Phabricator instance.

Yes, T4103 is the task for this. I'm going to merge this there.

Aug 13 2015, 2:52 PM · User Preferences
epriestley added a comment to T9165: Clarify effects of different kinds of Visible-To.

We could also split projects into two completely separate but essentially identical applications, "Groups" and "Tags". In the simplest form, both applications would run exactly the same code, except one would say "Groups" everywhere and one would say "Tags" everywhere, and each object would have an internal type flag specifying whether it is a "Group" or a "Tag".

Aug 13 2015, 2:36 PM · Projects, Phriction, Spaces, Policy
epriestley added a comment to T9167: Simplify destroying wiki pages.

Why are you destroying wiki pages?

Aug 13 2015, 2:36 PM · Phriction