I am using Phabricator + SVN.
When I use arc diff to commit code review request in Linux, I can see the all code context in Phabricator.
But when I run the same command in Windows, the Phabricator says the 'Context not available'.
I compared the raw diff files committed in Linux and in Windows and fount the only difference is that the line number in Linux diff file is real number, but in windows is not.
I tried two svn client command in windows, svn command in Tortoise SVN 1.8.5 and the svn client download from http://sourceforge.net/projects/win32svn/?source=dlp , but things are the same.
I wan't to know:
- How does phabricator get the code context?
- Is there any way to make arc diff can generate full code context in windows?
Thanks for your replay.
I download a GnuWin32 diffuitls and add it to my PATH.
Now in windows command shell, I can run diff command, which version is 2.8.7.
I run 'arc diff' again, but there is still no context.
But if I run command 'svn diff --diff-cmd=diff -x -U99999 > svn.diff', and using the svn.diff to create a Diff in Phabricator, the context is available.
So it seems that 'arc diff' in windows didn't use the GNU diff in my path? I wan't to use 'arc diff/commit' to do the code review instead of creating it in Web. Do you have more suggestions?
Sorry, I thought this had already made it into Phabricator. You'll want to follow T2465: Context not available for revisions created on Windows .