Page MenuHomePhabricator
Feed Advanced Search

Jul 3 2019

epriestley added a revision to T13302: When a user clicks a link in a dialog: we close the dialog; but might prefer to transition it away with the navigation event under Quicksand so "Back" can reopen it: Unknown Object (Differential Revision).
Jul 3 2019, 3:19 PM · Quicksand

Jul 2 2019

epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 8:58 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 5:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

Here's roughly where I'm headed next. I'm planning to:

Jul 2 2019, 5:18 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

The "default" controller currently needs to "force" the URI parameters...
The "filter" controller currently needs to "force" the URI parameters...
The "apply" flow, where a new custom filter is applied...

Jul 2 2019, 4:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 4:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 3:32 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): Unknown Object (Differential Revision).
Jul 2 2019, 3:32 PM · Workboards
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 2:43 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board): Unknown Object (Differential Revision).
Jul 2 2019, 2:43 PM · Workboards
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 1:16 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 12:50 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jul 2 2019, 12:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley closed T13330: OAuth Application object view pages have some out-of-date UI elements as Resolved by committing Restricted Diffusion Commit.
Jul 2 2019, 12:15 PM · OAuthServer

Jun 29 2019

epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 10:35 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

A couple of weird cases on state management:

Jun 29 2019, 10:14 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 10:12 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 9:20 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T13233: Consider supporting GPG/PGP.

This is sort of generically concerning to me:

Jun 29 2019, 8:47 PM · Diffusion, Mail
epriestley added a revision to T4900: Workboards updating in real time: Unknown Object (Differential Revision).
Jun 29 2019, 8:07 PM · Workboards (v3), User Delight, Wikimedia
epriestley moved T13301: Browser "Find..." feature isn't very useful in Safari on Workboards from Backlog to Far Future on the Workboards board.
Jun 29 2019, 7:54 PM · Workboards
epriestley closed T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts as Resolved.

This is deployed everywhere now, and kicking secure004 over seemed to work correctly, at least.

Jun 29 2019, 6:57 PM · Phacility
epriestley closed T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date as Resolved.

This stuff is all deployed, now.

Jun 29 2019, 6:56 PM · Daemons, Phacility
epriestley closed T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date, a subtask of T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts, as Resolved.
Jun 29 2019, 6:56 PM · Phacility
epriestley added a revision to T13330: OAuth Application object view pages have some out-of-date UI elements: Unknown Object (Differential Revision).
Jun 29 2019, 3:36 PM · OAuthServer
epriestley added a revision to T13330: OAuth Application object view pages have some out-of-date UI elements: Unknown Object (Differential Revision).
Jun 29 2019, 3:28 PM · OAuthServer
epriestley triaged T13330: OAuth Application object view pages have some out-of-date UI elements as Low priority.
Jun 29 2019, 3:24 PM · OAuthServer
epriestley edited the content of Changelog.
Jun 29 2019, 12:45 AM
epriestley created an object: 2019 Week 26 (Very Late June).
Jun 29 2019, 12:39 AM

Jun 27 2019

epriestley created T13329: In Phacility, inviting an email address that belongs to a bot/mailing list account hits new "import" language in a confusing way.
Jun 27 2019, 6:05 PM · Phacility

Jun 26 2019

epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

cd provides "at least once" delivery guarantees.

Jun 26 2019, 1:44 AM · Daemons, Phacility

Jun 25 2019

epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 25 2019, 10:21 PM · Daemons, Phacility
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Unknown Object (Differential Revision).
Jun 25 2019, 7:55 PM · Remarkup, Diffusion
epriestley added a revision to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts: Unknown Object (Differential Revision).
Jun 25 2019, 5:50 PM · Phacility
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.

This incantation seems to work as an upstart job:

Jun 25 2019, 5:46 PM · Phacility
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.

I'm going to install an upstart task on secure004 and kick it a few times, some stuff might be sketchy until I figure that out.

Jun 25 2019, 5:17 PM · Phacility
epriestley added a comment to T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.

Support multiple request encodings (likely BSON, protobuf, or messagepack). Leave JSON as the default, but in cases where messages can not be represented in JSON this gives us a plausible way forward.

Jun 25 2019, 4:55 PM · Restricted Project, Auth, Conduit
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.

The stalled production backup process completed successfully after deploying the change.

Jun 25 2019, 3:54 PM · Restricted Project, Infrastructure, Phacility
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

See also PHI1318. The new behavior here has tightened our rules about which users we act as.

Jun 25 2019, 2:38 PM · Diffusion, Differential
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.

I'm going to try to sneak this out to the db tier to resolve things before the west coast wakes up, at least.

Jun 25 2019, 2:17 PM · Restricted Project, Infrastructure, Phacility
epriestley added a revision to T13328: Database dumps can buffer (?) too much data to hold in memory: Unknown Object (Differential Revision).
Jun 25 2019, 12:25 PM · Restricted Project, Infrastructure, Phacility
epriestley added a comment to T13328: Database dumps can buffer (?) too much data to hold in memory.

PHP Fatal error: Out of memory (allocated 311164928) (tried to allocate 105988097 bytes) in /core/lib/libphutil/src/future/exec/ExecFuture.php on line 246

Jun 25 2019, 12:18 PM · Restricted Project, Infrastructure, Phacility
epriestley created T13328: Database dumps can buffer (?) too much data to hold in memory.
Jun 25 2019, 12:06 PM · Restricted Project, Infrastructure, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 25 2019, 12:51 AM · Daemons, Phacility

Jun 24 2019

epriestley closed T13326: "bin/files integrity" misparses file selection arguments as Resolved by committing Restricted Diffusion Commit.
Jun 24 2019, 11:02 PM · Files
epriestley closed T13327: When all payment account members are disabled, subscription workers fail infinitely as Resolved by committing Restricted Diffusion Commit.
Jun 24 2019, 10:29 PM · Phortune, Phacility
epriestley added a revision to T13326: "bin/files integrity" misparses file selection arguments: Unknown Object (Differential Revision).
Jun 24 2019, 10:13 PM · Files
epriestley added a revision to T13327: When all payment account members are disabled, subscription workers fail infinitely: Unknown Object (Differential Revision).
Jun 24 2019, 9:50 PM · Phortune, Phacility
epriestley created T13327: When all payment account members are disabled, subscription workers fail infinitely.
Jun 24 2019, 9:33 PM · Phortune, Phacility
epriestley closed T11037: `bin/phd status` is misleading about local / remote daemons as Resolved by committing Restricted Diffusion Commit.
Jun 24 2019, 6:26 PM · Daemons, Restricted Project
kerberizer awarded T13323: Remove the "CAN_EDIT on a parent project implies CAN_EDIT on a child project" policy rule a Like token.
Jun 24 2019, 7:01 AM · Policy, Projects

Jun 22 2019

epriestley added a comment to T13306: Provide a mechanism for importing local disk file backups into the Phacility cluster.

See one followup in T13326. The "import from disk" part seems to have worked properly in production.

Jun 22 2019, 4:51 PM · Phacility, Files
epriestley closed T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological" as Resolved.
Jun 22 2019, 4:50 PM · Infrastructure
epriestley created T13326: "bin/files integrity" misparses file selection arguments.
Jun 22 2019, 4:50 PM · Files
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: Unknown Object (Differential Revision).
Jun 22 2019, 4:03 PM · Transactions
epriestley edited the content of Changelog.
Jun 22 2019, 2:55 PM
epriestley created an object: 2019 Week 25 (Late June).
Jun 22 2019, 2:39 PM

Jun 21 2019

20after4 awarded T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion a Mountain of Wealth token.
Jun 21 2019, 9:06 PM · Remarkup, Diffusion

Jun 20 2019

epriestley closed T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly as Resolved by committing Restricted Diffusion Commit.
Jun 20 2019, 11:08 PM · Owners
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

I just ran into this for the first time:

Jun 20 2019, 11:04 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 10:44 PM · Daemons, Phacility
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

I've also never seen anyone use kill -TERM `cat /path/to/pidfile` in real life over some flavor of pkill, which is basically the same thing as "pattern match the process titles".

Jun 20 2019, 10:36 PM · Daemons, Phacility
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

provided I'm not missing some secret reason to retain PID files.

Jun 20 2019, 10:34 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 10:33 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 10:11 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 10:05 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Restricted Differential Revision.
Jun 20 2019, 9:57 PM · Daemons, Phacility
epriestley added a revision to T13303: There is an extra or missing "array_reverse()" somewhere after recent transaction strength sorting changes: Unknown Object (Differential Revision).
Jun 20 2019, 9:41 PM · Transactions
epriestley added a comment to T11037: `bin/phd status` is misleading about local / remote daemons.

I've marked D20604 as resolving this; it does so by making bin/phd status report local process status only. I strongly suspect that this is probably a better / less confusing behavior.

Jun 20 2019, 9:37 PM · Daemons, Restricted Project
epriestley added a revision to T11037: `bin/phd status` is misleading about local / remote daemons: Unknown Object (Differential Revision).
Jun 20 2019, 9:36 PM · Daemons, Restricted Project
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 9:36 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 9:25 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 9:23 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 9:14 PM · Daemons, Phacility
epriestley added a revision to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date: Unknown Object (Differential Revision).
Jun 20 2019, 9:03 PM · Daemons, Phacility
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

I have a patch for this which basically says "don't try to kill any process which doesn't look like a daemon process".

Jun 20 2019, 8:04 PM · Daemons, Phacility
epriestley added a comment to T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.

This is probably somewhat entangled with T13253 and/or T11037 and this whole thing is kind of a mess.

Jun 20 2019, 7:32 PM · Daemons, Phacility
epriestley added a comment to T12543: `phd` can't handle PID properly when there are multiple phabricator daemons..

We've run instances in the Phacility cluster for a long time now, but this is generally not something we really support or plan to support since there's no real customer interest in instancing Phabricator.

Jun 20 2019, 7:25 PM · Daemons, Bug Report
epriestley added a revision to T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological": Unknown Object (Differential Revision).
Jun 20 2019, 7:15 PM · Infrastructure
epriestley added a revision to T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological": Unknown Object (Differential Revision).
Jun 20 2019, 7:11 PM · Infrastructure
epriestley added a revision to T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological": Unknown Object (Differential Revision).
Jun 20 2019, 7:05 PM · Infrastructure
epriestley added a comment to T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological".

The power is in my hands, now.

Jun 20 2019, 6:50 PM · Infrastructure
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.

But wait! It says there are two ways! The other way is:

Jun 20 2019, 6:40 PM · Phacility
epriestley added a comment to T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.

If you are just writing an upstart job that needs to start the service after the basic facilities are up, either of these will work:

start on (local-filesystems and net-device-up IFACE!=lo)
Jun 20 2019, 6:38 PM · Phacility
epriestley added a revision to T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly: Unknown Object (Differential Revision).
Jun 20 2019, 6:16 PM · Owners
epriestley claimed T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly.
Jun 20 2019, 6:11 PM · Owners
epriestley added a comment to T5758: Package auditing should only require auditing on closing branches.

This was effectively resolved in 2019 Week 17 (Very Late April). Now, only ancestors of "Permanent Refs" trigger any publishing behavior (audits, notifications, feed, etc).

Jun 20 2019, 5:45 PM · Restricted Project, Owners
epriestley added a comment to T11012: Audit not Triggered Sometimes in Owners/Packages Application.

This is very old and it doesn't look like we ever found a working set of reproduction steps.

Jun 20 2019, 5:43 PM · Restricted Project, Owners, Bug Report
epriestley created T13325: Various internal APIs calls use the made up word "topographical" when they mean "topological".
Jun 20 2019, 5:37 PM · Infrastructure
epriestley created T13324: Owners transactions which edit paths for packages with one or more paths with no trailing slash render incorrectly.
Jun 20 2019, 5:27 PM · Owners
epriestley created T13323: Remove the "CAN_EDIT on a parent project implies CAN_EDIT on a child project" policy rule.
Jun 20 2019, 5:20 PM · Policy, Projects
epriestley created T13322: Allow parent projects to have direct members.
Jun 20 2019, 5:11 PM · Projects
epriestley edited projects for T10427: Errors when adding person to subproject, added: Projects; removed Bug Report.
Jun 20 2019, 4:49 PM · Projects
epriestley created T13321: "bin/phd" may try to kill processes it does not own if the daemon PID logfiles on disk are out of date.
Jun 20 2019, 3:20 PM · Daemons, Phacility
epriestley updated the task description for T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.
Jun 20 2019, 3:17 PM · Phacility
epriestley created T13320: Unannounced/unlogged AWS reboots are apparently routine procedure, not cosmic rays / ghosts.
Jun 20 2019, 2:58 PM · Phacility
spawnlt awarded T13039: Support numeric fields in Herald a Party Time token.
Jun 20 2019, 5:26 AM · Herald

Jun 19 2019

epriestley changed the visibility for D3219: Add View, Edit and Join policies to PhabricatorProject.
Jun 19 2019, 9:45 PM
epriestley added a comment to T13318: Phacility developer setup documentation omits "local.*" hosts.

🐫 Does this button work ------>>^^^

Jun 19 2019, 8:36 PM · Phacility
epriestley added a revision to T13319: Transactions which modify EditEngine form default values don't include details about the old and new values: Unknown Object (Differential Revision).
Jun 19 2019, 8:27 PM · EditEngine