Page MenuHomePhabricator
Feed Advanced Search

Aug 25 2018

epriestley created 2018 Week 34 (Very Late August).
Aug 25 2018, 12:43 AM
epriestley closed T13187: Plans: 2018 Week 34 Bonus Content as Resolved.

I punted the rest of this to T13189.

Aug 25 2018, 12:38 AM · Plans
epriestley triaged T13189: Plans: 2018 Week 35 Bonus Content as Normal priority.
Aug 25 2018, 12:25 AM · Plans
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 25 2018, 12:25 AM · Plans

Aug 24 2018

epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 24 2018, 8:47 PM · Plans
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Aug 24 2018, 8:47 PM · Plans, Diffusion
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 24 2018, 7:56 PM · Plans
epriestley added a comment to T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator.

The actual evidence about webhooks is a little spotty and it's possible that they "work" and are just undocumented and not officially supported. It's possible that CircleCI just needs a nudge to actually document/support them.

Aug 24 2018, 7:35 PM · Guides, Harbormaster
epriestley updated the task description for T9456: Evaluate upstream support for third-party build systems.
Aug 24 2018, 7:31 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

See T13188 for CircleCI 2.0. Upshot: they removed webhooks so we can no longer interact with them.

Aug 24 2018, 7:30 PM · Restricted Project, Harbormaster
epriestley triaged T13188: CircleCI 1.0 sunsets on August 31, 2018; CircleCI 2.0 can not work with Phabricator as Low priority.
Aug 24 2018, 7:30 PM · Guides, Harbormaster
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 5:58 PM · Plans
epriestley added a revision to T12190: In PHP7, include-time warnings from source files are ignored: Unknown Object (Differential Revision).
Aug 24 2018, 5:47 PM · Infrastructure
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 5:47 PM · Plans
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 24 2018, 5:30 PM · Plans
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 5:27 PM · Plans
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 5:09 PM · Plans
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 24 2018, 5:06 PM · Plans
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 5:03 PM · Plans
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 4:52 PM · Plans
epriestley added a revision to T13176: Differential now has a "/D123/new/" link: Unknown Object (Differential Revision).
Aug 24 2018, 4:52 PM · Differential
epriestley added a comment to T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.

Pushing the requireCapabilities() change out one more week since I had some stuff crop up early this week and it didn't get a chance to soak.

Aug 24 2018, 4:26 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.
Aug 24 2018, 4:25 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 24 2018, 4:24 PM · Plans
epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 24 2018, 3:06 PM · Plans

Aug 23 2018

epriestley added a revision to T13187: Plans: 2018 Week 34 Bonus Content: Unknown Object (Differential Revision).
Aug 23 2018, 10:03 PM · Plans

Aug 22 2018

epriestley added a comment to T13187: Plans: 2018 Week 34 Bonus Content.

unless you believe this is just a different manifestation of the same underlying bug.

Aug 22 2018, 2:33 PM · Plans

Aug 21 2018

epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 21 2018, 8:11 PM · Plans
epriestley closed T12101: Phabricator PHP 7 Compatibility as Resolved.

We haven't seen any PHP7 issues in ~6 months and the last few have been very minor things with edge cases like error handling behavior, so I think we can safely call this resolved.

Aug 21 2018, 8:03 PM · Infrastructure, Guides

Aug 20 2018

epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 20 2018, 10:14 AM · Plans
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 20 2018, 10:08 AM · Plans
epriestley closed T13164: Plans: 2018 Week 31 - 33 Bonus Content as Resolved.
Aug 20 2018, 10:02 AM · Plans
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 20 2018, 10:01 AM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 20 2018, 10:01 AM · Plans
joshuaspence added a comment to T7303: Provide OAuth access to Conduit.

Even with OAuth, you still can't make AJAX requests to Conduit from client-side JavaScript, right? Is the idea that the backend code uses OAuth to talk to Conduit on a user's behalf?

Aug 20 2018, 8:06 AM · Restricted Project, Conduit, Restricted Project

Aug 18 2018

epriestley added a comment to T13183: AWS is rebooting instances in late August 2018.

Think I got through the easy ones without any issues. I suspect admin and secure may be a little more involved so I'm going to leave the cat in the bag for the moment.

Aug 18 2018, 9:21 PM · Ops, Phacility
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 18 2018, 9:10 PM · Ops, Phacility
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 18 2018, 9:04 PM · Ops, Phacility
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 18 2018, 9:00 PM · Ops, Phacility
epriestley added a comment to T13183: AWS is rebooting instances in late August 2018.

I'm going to stop/start at least some of these now.

Aug 18 2018, 8:57 PM · Ops, Phacility
epriestley edited the content of Changelog.
Aug 18 2018, 8:51 PM
epriestley created 2018 Week 33 (Late August).
Aug 18 2018, 8:15 PM
epriestley updated the task description for T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.
Aug 18 2018, 8:10 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading

Aug 17 2018

epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 17 2018, 6:11 PM · Plans
epriestley added a comment to T13187: Plans: 2018 Week 34 Bonus Content.

See PHI757. Leaving inline comments on the right hand side of files not touched by diff B in an interdiff between A and B raises an error.

Aug 17 2018, 6:11 PM · Plans
epriestley updated the task description for T13187: Plans: 2018 Week 34 Bonus Content.
Aug 17 2018, 6:09 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 17 2018, 6:06 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 17 2018, 5:56 PM · Plans
epriestley added a comment to T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.

I'm going to push this out to next week since D19586 probably has a few minor issues with it and it's close to the release cut. It adds a lot of new policy checks which weren't explicit before, so I'd guess it may cause a few improper policy errors on things which are actually allowed. I caught a bunch of them (like "Mute Thread") but probably didn't get every single one.

Aug 17 2018, 3:32 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.
Aug 17 2018, 3:30 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading

Aug 16 2018

20after4 awarded T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor a Love token.
Aug 16 2018, 9:36 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 16 2018, 9:12 PM · Plans
epriestley triaged T13187: Plans: 2018 Week 34 Bonus Content as Normal priority.
Aug 16 2018, 9:12 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 16 2018, 8:54 PM · Plans
epriestley added a comment to T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed.

These are actually removed in 2018 Week 33. See T13186 for a small amount of followup and discussion, although there isn't too much new information beyond what's here.

Aug 16 2018, 6:18 PM · Policy, Maniphest, Installing & Upgrading
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 16 2018, 6:09 PM · Plans
epriestley closed T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed as Resolved by committing Restricted Diffusion Commit.
Aug 16 2018, 5:51 PM · Policy, Maniphest, Installing & Upgrading
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 16 2018, 5:12 PM · Plans
epriestley triaged T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor as Low priority.
Aug 16 2018, 4:01 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 16 2018, 2:59 PM · Plans
epriestley changed the visibility for T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Aug 16 2018, 2:39 AM · Arcanist, Windows

Aug 15 2018

epriestley closed T9459: arc upgrade on Windows doesn't understand it's a git repo as Resolved by committing Restricted Diffusion Commit.
Aug 15 2018, 11:57 PM · Arcanist, Windows
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 15 2018, 6:43 PM · Ops, Phacility
epriestley added a revision to T9459: arc upgrade on Windows doesn't understand it's a git repo: Unknown Object (Differential Revision).
Aug 15 2018, 5:44 PM · Arcanist, Windows
epriestley edited P2108 Masterwork From Distant Lands.
Aug 15 2018, 5:33 PM
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

Oh, right, "meetings". I've heard of those!

Aug 15 2018, 4:56 PM · Phacility, Ops
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 15 2018, 4:56 PM · Ops, Phacility

Aug 14 2018

epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 11:08 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 9:49 PM · Plans
epriestley added a comment to T13176: Differential now has a "/D123/new/" link.

This is also showing up in initial email, which is silly and pointless.

Aug 14 2018, 9:40 PM · Differential
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 9:37 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 8:30 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 8:22 PM · Plans
epriestley added a revision to T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed: Restricted Differential Revision.
Aug 14 2018, 5:52 PM · Policy, Maniphest, Installing & Upgrading
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Restricted Differential Revision.
Aug 14 2018, 5:52 PM · Plans
epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

I'm touching some adjacent code for a "Disable User" permission in T13164.

Aug 14 2018, 3:49 PM · People, Security

Aug 13 2018

epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 10:40 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 10:10 PM · Plans
epriestley added a comment to T13185: AWS Reboots Part 2, Electric Boogaloo.

I think T13183 is the exact same hosts. :)

Aug 13 2018, 9:24 PM · Phacility, Ops
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 9:13 PM · Plans
epriestley added a comment to T13185: AWS Reboots Part 2, Electric Boogaloo.

Same as T13183?

Aug 13 2018, 8:45 PM · Phacility, Ops
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 6:46 PM · Plans
epriestley closed T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device as Resolved by committing Restricted Diffusion Commit.
Aug 13 2018, 6:39 PM · Almanac
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 6:37 PM · Plans
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 13 2018, 6:14 PM · Ops, Phacility
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 5:01 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 4:55 PM · Plans
epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

The root use case here was a desire for a better sense of how often certain rules were firing, and we improved the push logs instead to address this more directly (D19555, D19556, D19557).

Aug 13 2018, 4:53 PM · Diffusion, Herald
epriestley added a revision to T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device: Unknown Object (Differential Revision).
Aug 13 2018, 4:32 PM · Almanac
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 4:29 PM · Plans
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 13 2018, 4:19 PM · Ops, Phacility
epriestley triaged T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device as Low priority.
Aug 13 2018, 4:18 PM · Almanac
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 4:00 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 3:48 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 3:11 PM · Plans
epriestley renamed T13164: Plans: 2018 Week 31 - 33 Bonus Content from Plans: 2018 Week 31 - 32 Bonus Content to Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 3:11 PM · Plans
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 13 2018, 3:09 PM · Ops, Phacility
epriestley triaged T13183: AWS is rebooting instances in late August 2018 as Low priority.
Aug 13 2018, 2:30 PM · Ops, Phacility

Aug 11 2018

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

I did rebuild-identities on every instance

Aug 11 2018, 1:56 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

The "activity" migration went to production just now. I expect all production instances just bailed out, since I ran rebuild-identities some time ago, but I'll verify that:

Aug 11 2018, 1:53 PM · Customer Impact, Diffusion (v3)