Page MenuHomePhabricator
Feed Advanced Search

Mar 30 2018

epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Mar 30 2018, 9:51 PM · Plans, Differential
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:31 PM · Plans, Diffusion
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:30 PM · Plans, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 30 2018, 6:15 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T3626: Detection of language for some file types isn't good.

When this eventually moves forward, it's probably also appropriate to remove the syntax-highlighter.engine config option. I think this has essentially zero use in the wild and we have better modern patterns to approach the problem (without extreme-niche config options) if there are real-world use cases.

Mar 30 2018, 4:49 PM · Customer Impact, Restricted Project, Differential
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 30 2018, 4:48 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 30 2018, 3:45 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 30 2018, 3:26 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 2:54 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 2:53 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 30 2018, 12:01 AM · Plans

Mar 29 2018

epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 9:06 PM · Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

Oh, and I found the beast to get a portal to Saqawal's Roost and killed Saqawal and got the boots, but the boots and set in general seem kinda bad so they're sitting in one of my six tabs full of unique items that I will never ever sell or do anything with.

Mar 29 2018, 8:19 PM · Phacility
epriestley added a comment to T13072: Merge Harbormaster BuildCommand into BuildMessage.

D19269 makes Harbormaster objects destructible. I've made Build destroy BuildMessage (which it doesn't receive, so this never destroys anything) but not BuildCommand (which it does receive), so that when this change is made (and it starts receiving BuildMessage instead of BuildCommand) things will just work. Until then, BuildCommand objects are technically left hanging, but destroying builds is exceptionally rare so I'm just assuming that this will probably be fixed before anyone notices.

Mar 29 2018, 7:59 PM · Harbormaster
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 7:58 PM · Plans
epriestley added a revision to T13072: Merge Harbormaster BuildCommand into BuildMessage: Unknown Object (Differential Revision).
Mar 29 2018, 7:58 PM · Harbormaster
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 6:42 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 6:29 PM · Plans
epriestley closed T12759: Creating an Owners package before creating any repositories shows a blank select when adding paths to the package as Resolved.

I think this is sort of less bad/weird now, at least. You get a tokenizer instead, which is still empty, but you're prompted to "Type a repository name..." and the UI isn't this odd empty select thing anymore.

Mar 29 2018, 6:27 PM · Bug Report
jcox awarded T13114: Plans: 2018 Week 13 Bonus Content a Party Time token.
Mar 29 2018, 5:34 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 5:04 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 4:54 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 4:52 PM · Plans
epriestley added a comment to T13114: Plans: 2018 Week 13 Bonus Content.

D19266 adds some additional Support Pact adventure mode content. Some other ideas for improving this mode:

Mar 29 2018, 2:48 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 2:39 PM · Plans
epriestley added a revision to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them: Unknown Object (Differential Revision).
Mar 29 2018, 2:22 PM · Restricted Project, Diffusion, Herald
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 29 2018, 2:22 PM · Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I've barely had a chance to play recently but I know everyone is longing for an update so: I made it to level 88 (which I think is the highest level I've reached on any character), and completed all the white maps, and haven't died yet.

Mar 29 2018, 12:51 PM · Phacility
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 29 2018, 12:20 AM · Plans

Mar 28 2018

epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 28 2018, 11:21 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 28 2018, 11:20 PM · Plans
epriestley updated the task description for T13114: Plans: 2018 Week 13 Bonus Content.
Mar 28 2018, 10:50 PM · Plans
epriestley added a revision to T13114: Plans: 2018 Week 13 Bonus Content: Unknown Object (Differential Revision).
Mar 28 2018, 10:24 PM · Plans
epriestley triaged T13114: Plans: 2018 Week 13 Bonus Content as Normal priority.
Mar 28 2018, 10:18 PM · Plans
epriestley closed T13108: Plans: 2018 Week 12 Bonus Content as Resolved.

Much of this survives in T13110 but the rest is resolved.

Mar 28 2018, 10:13 PM · Plans
epriestley added a comment to T10767: fold empty directories in Browse view.

See Planning.

Mar 28 2018, 6:43 PM · Restricted Project, Diffusion, Feature Request
epriestley closed T12917: Move domain name registration and SSL to AWS as Resolved.

After clicking 17,000 emails I successfully transferred everything to AWS, with some minor caveats:

Mar 28 2018, 5:04 PM · Ops, Phacility
epriestley added a comment to T12917: Move domain name registration and SSL to AWS.

I moved SSL and registration for phurl.io to AWS in T13113 so this is just a transfer issue now.

Mar 28 2018, 3:28 PM · Ops, Phacility
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

oh wow it actually worked 😱

Mar 28 2018, 3:27 PM · Phacility, Ops
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

AWS also supports DNS-based authorization now, which reduces the need for all the MX juggling.

Mar 28 2018, 3:22 PM · Phacility, Ops
epriestley closed T13113: phurl.io SSL certificate has expired as Resolved.

I was able to MX phurl.io and get an SSL authorization link working. I moved phurl.io SSL to AWS ACM so this (certificate expiration) shouldn't happen again.

Mar 28 2018, 3:19 PM · Phacility, Ops
epriestley added projects to T13113: phurl.io SSL certificate has expired: Ops, Phacility.
Mar 28 2018, 3:01 PM · Phacility, Ops
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

(See also T7125, but this particular problem has conceptually been solved for every domain except phurl.io by using AWS certificates.)

Mar 28 2018, 2:53 PM · Phacility, Ops
epriestley added a comment to T13113: phurl.io SSL certificate has expired.

See also T12917 and a brief mention in T13062.

Mar 28 2018, 2:53 PM · Phacility, Ops

Mar 26 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 26 2018, 2:23 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 26 2018, 2:20 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 26 2018, 2:16 PM · Plans, Files, Differential, Diffusion

Mar 23 2018

epriestley edited the content of Changelog.
Mar 23 2018, 9:50 PM
epriestley created 2018 Week 12 (Late March).
Mar 23 2018, 9:49 PM
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 8:49 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 2:41 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 2:06 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 12:10 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13112: Safari, PDFs, and Content-Security-Policy interact oddly.
Mar 23 2018, 11:50 AM · Safari, Security, Files
epriestley closed T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Resolved.

Actually, it seems like rel="noreferrer" fixes this. This is bizarre so maybe this is a problem with a spooky ghost haunting my computer?

Mar 23 2018, 11:48 AM · Safari, Security, Files
epriestley triaged T13112: Safari, PDFs, and Content-Security-Policy interact oddly as Normal priority.
Mar 23 2018, 11:47 AM · Safari, Security, Files
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 23 2018, 11:04 AM · Plans, Files, Differential, Diffusion

Mar 22 2018

epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

That's a reasonable point. The details of PHI386 weren't very indicative one way or another since I didn't end up GC'ing the repository multiple times. I suppose I can go GC it again during the deployment window this week and see how long it takes.

Mar 22 2018, 8:27 PM · Phacility, Diffusion
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Unknown Object (Differential Revision).
Mar 22 2018, 8:09 PM · Diffusion
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Unknown Object (Differential Revision).
Mar 22 2018, 7:56 PM · Diffusion
epriestley added a comment to T13109: Improve cluster write feedback and write routing.

Modify the PushEvent table to contain more information about locks and waits (e.g., active queue status; how long the push waited for the write lock; how long the push spent synchronizing).

Mar 22 2018, 7:27 PM · Diffusion
epriestley triaged T13111: Periodically run `git prune` on Git working copies as Normal priority.
Mar 22 2018, 4:56 PM · Phacility, Diffusion
mydeveloperday awarded T13105: Plans: Rich presentation and diff rendering pipelines for various file types a Like token.
Mar 22 2018, 9:59 AM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Unknown Object (Differential Revision).
Mar 22 2018, 2:11 AM · Diffusion
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I kind of wish I could see PHI415. Do people send in support tickets about path of exile?

Mar 22 2018, 1:50 AM · Phacility

Mar 21 2018

epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

wow every piece of gear you have is better than all the gear I own put together

Mar 21 2018, 11:48 PM · Phacility
jcox awarded T13107: Git, Slowly and Painfully a 100 token.
Mar 21 2018, 10:52 PM · Guides
thoughtpolice awarded T13107: Git, Slowly and Painfully a 100 token.
Mar 21 2018, 9:53 PM · Guides
epriestley closed T11145: Dialog submit buttons don't disable on click as Resolved by committing Restricted Diffusion Commit.
Mar 21 2018, 6:58 PM · Restricted Project, PHUI, Bug Report
epriestley added a revision to T11145: Dialog submit buttons don't disable on click: Unknown Object (Differential Revision).
Mar 21 2018, 6:55 PM · Restricted Project, PHUI, Bug Report
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: Restricted Differential Revision.
Mar 21 2018, 6:55 PM · Plans
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: Unknown Object (Differential Revision).
Mar 21 2018, 6:46 PM · Plans
epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 21 2018, 6:20 PM · Plans
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: Unknown Object (Differential Revision).
Mar 21 2018, 6:15 PM · Plans
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

See PHI431. See PHI426. ... I suspect these lead to T731 and T10574, practically.

Mar 21 2018, 4:05 PM · Plans, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

See PHI483. There's currently a bad interaction between builds completing and drafts unpublishing, described in greater detail in T13108.

Mar 21 2018, 3:54 PM · Plans, Differential
epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 21 2018, 3:28 PM · Plans
epriestley triaged T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions as Normal priority.
Mar 21 2018, 3:27 PM · Plans, Differential

Mar 20 2018

epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

On complex build statuses, which has come up more than a handful of times but which I haven't aggregated well:

Mar 20 2018, 5:03 PM · Plans
epriestley added a comment to T11798: Allow harbormaster build logs to be downloaded via the API.

(Note that it will only work for more-recent logs, T13088 will have some guidance for older logs eventually.)

Mar 20 2018, 4:17 PM · Harbormaster
epriestley closed T11798: Allow harbormaster build logs to be downloaded via the API as Resolved.

I missed this task when collecting T13088, but this is supported after D19151.

Mar 20 2018, 4:17 PM · Harbormaster
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

This is sort of a race. Here's what happens:

Mar 20 2018, 4:09 PM · Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

I only play True Ethical SSF Hardcore so I have of never seen a Kaom's or worn a piece of gear with more than 4 links on it, and I'm definitely not very good at the game, but one thing that's been going better for me this league is that I've been doing builds with critical strike.

Mar 20 2018, 3:33 PM · Phacility
NDKilla awarded T13097: Plans: Path of Exile 3.2.0 (Bestiary League) a The World Burns token.
Mar 20 2018, 3:16 PM · Phacility
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

D19240 exhibited the same behavior on a local lint failure so this is almost certainly a mundane bug rather than some sort of exotic race.

Mar 20 2018, 2:53 PM · Plans
epriestley added a revision to T13108: Plans: 2018 Week 12 Bonus Content: Unknown Object (Differential Revision).
Mar 20 2018, 2:50 PM · Plans
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

I had a local test failure there

Mar 20 2018, 2:47 PM · Plans
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

From reading the code, the behavior should already be (A): that is, we should already get this right in cases (3) and (4).

Mar 20 2018, 2:46 PM · Plans
epriestley added a comment to T13108: Plans: 2018 Week 12 Bonus Content.

See PHI483. Some of the mail rules around builds and drafts are kind of whack right now.

Mar 20 2018, 1:57 PM · Plans

Mar 19 2018

epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 19 2018, 10:27 PM · Plans
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 19 2018, 7:40 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 19 2018, 5:59 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Unknown Object (Differential Revision).
Mar 19 2018, 4:42 PM · Plans, Files, Differential, Diffusion
epriestley closed T12988: Remove flag "--master" from bin/remote as Resolved.

I removed this in rCORE36d2ef5dffe441ba1175e362bb73f0e43a9f70a2.

Mar 19 2018, 2:55 PM · Ops, Phacility
epriestley added a comment to T12993: Datasource queries with many "JOIN ... LIKE" can have explosive complexity.

See also T13102/PHI442. The MySQL setting optimizer_search_depth=0 may fix the weird explosive complexity here.

Mar 19 2018, 2:55 PM · Infrastructure, Typeahead, Search
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
Mar 19 2018, 2:43 PM · Arcanist, Plans
epriestley added a comment to T13097: Plans: Path of Exile 3.2.0 (Bestiary League).

The Arc Hierophant is still alive, but he managed to get a Scaeva to drop shortly after the last update. I brought a Reave Juggernaut to 82 with it, although I've only made 1-2 tiers of progress in maps.

Mar 19 2018, 2:35 PM · Phacility
epriestley updated the task description for T13108: Plans: 2018 Week 12 Bonus Content.
Mar 19 2018, 2:08 PM · Plans
epriestley triaged T13109: Improve cluster write feedback and write routing as Normal priority.
Mar 19 2018, 2:07 PM · Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Ideally, I think Diffusion, Files and Paste should all have the highlighting/encoding options and share more of the same code, with Diffusion being distinguished by having blame (and, I suppose, symbol linking) available.

Mar 19 2018, 1:48 PM · Plans, Files, Differential, Diffusion