Page MenuHomePhabricator
Feed Advanced Search

Sep 20 2016

epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

A contributing issue is that one instance appears to be making clone requests for approximately 30 repositories per minute to this shard. This is easy to rate limit, but probably not easy to rate limit in a generalized, not-a-cluster-hack way.

Sep 20 2016, 2:13 AM · Ops, Phacility
epriestley merged task T11666: Checkout is failing from Phacility into T11665: repo002.phacility.net is heavily loaded.
Sep 20 2016, 1:51 AM · Bug Report
epriestley merged T11666: Checkout is failing from Phacility into T11665: repo002.phacility.net is heavily loaded.
Sep 20 2016, 1:51 AM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

One remaining issue with backoff/cooldown is that mirrors aren't included: a regularly-updated repository with broken mirrors still tries mirroring. This is somewhat more involved to fix, though (see T6131).

Sep 20 2016, 1:07 AM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

Those changes seem stable. Unclear how much they're really helping, but load is looking at least somewhat better. I'm going to dig into things a bit more and see if I can get a better sense of whether we're on the path to recovery or not.

Sep 20 2016, 1:06 AM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

D16574 retains update cooldowns (so we don't immediately update everything after a restart) and sets up for the following change.

Sep 20 2016, 12:32 AM · Ops, Phacility
epriestley added a revision to T11665: repo002.phacility.net is heavily loaded: Unknown Object (Differential Revision).
Sep 20 2016, 12:28 AM · Ops, Phacility

Sep 19 2016

epriestley closed T7865: After restarting, repository daemons all do a lot of work as Resolved by committing Restricted Diffusion Commit.
Sep 19 2016, 11:49 PM · Phacility
epriestley added a revision to T7865: After restarting, repository daemons all do a lot of work: Unknown Object (Differential Revision).
Sep 19 2016, 11:48 PM · Phacility
epriestley added a revision to T11665: repo002.phacility.net is heavily loaded: Unknown Object (Differential Revision).
Sep 19 2016, 11:48 PM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

Repository retries (failed mirrors, failed fetches) have no real backoff

Sep 19 2016, 11:03 PM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.

I could alternatively throttle down the highly active instances (or all instances on this shard) but that's not too great.

Sep 19 2016, 10:51 PM · Ops, Phacility
epriestley added a comment to T11665: repo002.phacility.net is heavily loaded.
  • Maybe a good time to launch new shards? Last tier size increase was 10 months ago (late November, 2015) when I fixed the allocation algorithm to be not a huge wasteful pile of garbage that required us to constantly throw hardware at it.
    • Maybe the allocation algorithm should consider active users, not just active instances? I think the 002 shard has the most active users by a hefty margin, just by luck of the draw. But this will tend to be moot at scale.
    • Maybe start moving instances between shards? This seems hard to do without downtime today, and doing all the legwork to reduce downtime through clustering is foreboding.
Sep 19 2016, 10:38 PM · Ops, Phacility
epriestley created T11665: repo002.phacility.net is heavily loaded.
Sep 19 2016, 10:29 PM · Ops, Phacility
epriestley renamed T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained from Remarkup navigation component is not able to have text starting with equals sign to Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.
Sep 19 2016, 9:44 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

And you can technically:

Sep 19 2016, 9:32 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

Oh, right. That works, but I think isn't documented:

Sep 19 2016, 9:31 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.

We could conceivably special-case this since setting an empty attribute to a value isn't meaningful, I suppose.

Sep 19 2016, 9:25 PM · Documentation, Remarkup
epriestley added a comment to T11663: Escaping for properties in remarkup rules like "{nav ...}" is not clearly explained.
{nav name=C124}
Sep 19 2016, 9:24 PM · Documentation, Remarkup
epriestley created T11662: Draft comments which reply to ghost inlines from lines which no longer exist can not be edited or deleted until the page is reloaded.
Sep 19 2016, 8:43 PM · Inline Comments, Customer Impact, Differential
epriestley added a comment to T10747: Import and export ICS from Calendar.

Some somewhat-good news is that Google Calendar just gives you an .ics blob of garbage to describe recurrence rules:

Sep 19 2016, 7:11 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

Things don't look promising.

Sep 19 2016, 7:02 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

I think we should be able to accommodate that fairly easily.

Sep 19 2016, 5:30 PM · Restricted Project, Prioritized, Calendar

Sep 18 2016

epriestley added a comment to T10747: Import and export ICS from Calendar.

More generally, here's how I'm planning to model imports, which seems largely consistent with other systems:

Sep 18 2016, 2:02 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

Yeah, I fiddled with that but didn't immediately have any luck. It's possible that there's some complex condition like non-self organizer + non-self sender or something. If it only requires non-organizer, it should already work today (e.g., on this install).

Sep 18 2016, 1:18 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7944: Add Conduit support to Calendar.

Sort of. I'd like to have use cases (what are you trying to do?) first, and I'm not certain what the best representation of dates and times is for external consumption.

Sep 18 2016, 1:15 PM · Conduit, Calendar

Sep 17 2016

epriestley edited the content of Changelog.
Sep 17 2016, 9:25 PM
epriestley edited the content of 2016 Week 38 (Mid September).
Sep 17 2016, 9:25 PM
epriestley created 2016 Week 38 (Mid September).
Sep 17 2016, 9:25 PM
epriestley added a comment to T11644: Allow editing of Conpherence messages.

This probably already works, on the backend, but needs:

Sep 17 2016, 1:14 AM · Conpherence

Sep 16 2016

epriestley added a comment to T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived.

I think the first part of this should be fixed in HEAD now, thanks for the report!

Sep 16 2016, 9:07 PM · Restricted Project, Bug Report
epriestley added a comment to T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived.

The "multiple packages" issue may have been a symptom of the dominion/archive problem, here's a case I hit while testing that made it look like there was a second issue:

Sep 16 2016, 9:00 PM · Restricted Project, Bug Report
epriestley created T11652: `arc which` lists repositories by monogram instead of display name.
Sep 16 2016, 8:40 PM · Arcanist
epriestley created T11651: Owners empty states are lookin' weird.
Sep 16 2016, 8:37 PM · Owners, Design
epriestley added a comment to T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived.

D16564 might fix this but I need to actually test it.

Sep 16 2016, 7:10 PM · Restricted Project, Bug Report
epriestley added a revision to T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived: Unknown Object (Differential Revision).
Sep 16 2016, 7:09 PM · Restricted Project, Bug Report
epriestley added a comment to T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived.

Also, what is the expected behavior if two Owners packages point to the same path?

Sep 16 2016, 7:02 PM · Restricted Project, Bug Report
epriestley added a comment to T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived.

Is it possible that this is slightly narrower: "package dominion rules incorrectly consider archived packages"? That seems to fit with the observations, but maybe I'm overlooking something.

Sep 16 2016, 6:52 PM · Restricted Project, Bug Report
epriestley merged T11649: User changing the task access to a project which another user is not member of, leads to a not visible active notification. into T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Sep 16 2016, 1:24 PM · Wikimedia, Notifications
epriestley merged task T11649: User changing the task access to a project which another user is not member of, leads to a not visible active notification. into T8953: Phantom unread notifications when the user is subscribed to something he's not allowed to view.
Sep 16 2016, 1:24 PM · Bug Report

Sep 15 2016

epriestley closed T11646: Deactivating E-mail Notifications about Automatic E-mails as Invalid.

See Contributing Feature Requests for help filing a feature request we can accept upstream.

Sep 15 2016, 8:11 PM · Feature Request
epriestley added a comment to T11642: Add "name" field to `harbormaster.build.search` results.

Feel free to submit a diff for this, should just involve adding some stuff to HarbormasterBuild in getFieldSpecificationsForConduit() and getFieldValuesForConduit().

Sep 15 2016, 5:34 PM · Restricted Project, Conduit, Harbormaster
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 15 2016, 2:01 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

I'm having trouble making GMail provide a reasonable pathway forward for getting .ics events onto Google Calendar. Ostensibly this just works:

Sep 15 2016, 1:58 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 15 2016, 1:14 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 15 2016, 12:59 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

ICS primarily identifies users (organizers and attendees) by email address. Phabricator does not normally disclose email addresses, and I don't want to let someone scrape every email address out of Phabricator by inviting every user to an event and downloading the .ics.

Sep 15 2016, 12:30 PM · Restricted Project, Prioritized, Calendar
epriestley moved T11635: tagging a differential revision with a milestone breaks `arc diff` from vMajor to Backlog on the Arcanist board.
Sep 15 2016, 11:46 AM · Restricted Project, Arcanist, Bug Report
epriestley removed a reviewer for D16549: waergh: Blessed Reviewers.
Sep 15 2016, 12:43 AM
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 15 2016, 12:19 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 15 2016, 12:10 AM · Restricted Project, Prioritized, Calendar

Sep 14 2016

epriestley created T11638: "Create Event" from day view does not default to visible day.
Sep 14 2016, 11:59 PM · Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 14 2016, 8:50 PM · Restricted Project, Prioritized, Calendar
epriestley removed a project from T10855: Allow external systems to edit the content of dashboard panels so they can publish information: Prioritized.
Sep 14 2016, 6:47 PM · Dashboards, Restricted Project, Conduit, Feature Request
Luke081515.2 awarded T8442: Build Space switching UI a Love token.
Sep 14 2016, 6:12 PM · Restricted Project, Spaces, Wikimedia, Policy

Sep 13 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 13 2016, 7:50 PM · Restricted Project, Prioritized, Calendar
epriestley merged task T11634: Client SSL Certificate Support in libphutil/arcanist into T7616: Arcanist to be able to access site requiring client side SSL certificate.
Sep 13 2016, 7:45 PM · libphutil, Arcanist, Feature Request
epriestley merged T11634: Client SSL Certificate Support in libphutil/arcanist into T7616: Arcanist to be able to access site requiring client side SSL certificate.
Sep 13 2016, 7:45 PM · Arcanist, libphutil
epriestley added a comment to T11628: It's not simple to join a Conpherence.

Even if everything else defaults to public, I don't think that's an especially strong argument on its own for copying that default. There are a lot of other cases where we diverge from common practice because we think there's a stronger case for a different default or behavior.

Sep 13 2016, 4:34 PM · Conpherence
epriestley added a comment to T11608: Make it easier to review stacks of diffs.

Sorry, we aren't interested in maintaining any version of this change in the upstream at this time.

Sep 13 2016, 4:21 PM · Restricted Project, Differential, Feature Request
epriestley added a comment to T11547: Paste query results do not display actual length of listed Pastes (but always "5 lines" if Paste is longer).

D16465 has details on how to move forward here if anyone wants to steal it before @michaeljs1990 gets back to it.

Sep 13 2016, 4:14 PM · Contributor Onboarding, Paste, Bug Report
epriestley added a comment to T11628: It's not simple to join a Conpherence.

Hmm, I guess I don't have the same experience -- the defaults are what I expect and the UI doesn't seem difficult to me (rough in places, but the basic flows are what I expect/want).

Sep 13 2016, 4:14 PM · Conpherence
epriestley moved T11547: Paste query results do not display actual length of listed Pastes (but always "5 lines" if Paste is longer) from Backlog to Ready on the Contributor Onboarding board.
Sep 13 2016, 4:12 PM · Contributor Onboarding, Paste, Bug Report
epriestley triaged T11629: Support "editor link" for repos without a callsign as Low priority.
Sep 13 2016, 4:12 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
epriestley moved T11629: Support "editor link" for repos without a callsign from Backlog to Ready on the Contributor Onboarding board.
Sep 13 2016, 4:12 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
epriestley moved T11632: Display invisible characters on erroneous user input from Backlog to Ready on the Contributor Onboarding board.
Sep 13 2016, 4:12 PM · Restricted Project, Contributor Onboarding
epriestley added a project to T11629: Support "editor link" for repos without a callsign: Contributor Onboarding.

This stuff is defined in PhabricatorUser->loadEditorLink(), which ain't great but probably not worth generalizing.

Sep 13 2016, 4:11 PM · Contributor Onboarding, FreeBSD, Restricted Project, Feature Request
epriestley added a comment to T11628: It's not simple to join a Conpherence.

Of the visible rooms I'm a member of, 14 out of 15 are private (the other one is General Chat).

Sep 13 2016, 4:04 PM · Conpherence
epriestley closed T11613: New install exception is wrong if preflight setup checks fail as Resolved.
Sep 13 2016, 3:47 PM · Bug Report (Needs Information), Setup
dfumagalli awarded T11613: New install exception is wrong if preflight setup checks fail a Mountain of Wealth token.
Sep 13 2016, 2:29 PM · Bug Report (Needs Information), Setup

Sep 12 2016

kylec awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
Sep 12 2016, 11:43 PM · Arcanist
epriestley closed T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action as Resolved by committing Restricted Diffusion Commit.
Sep 12 2016, 9:49 PM · Setup, Bug Report
epriestley edited the content of Changelog.
Sep 12 2016, 9:48 PM
epriestley created 2016 Week 37 (Early September).
Sep 12 2016, 9:48 PM
epriestley added a revision to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action: Unknown Object (Differential Revision).
Sep 12 2016, 9:45 PM · Setup, Bug Report
epriestley added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

Neither T11277 or T6706 are exactly about that, but I think the ultimate fix to those is likely a general refinement of SSH key metadata (source IP range restrictions, logging, specific permissions).

Sep 12 2016, 9:22 PM
epriestley added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

for sshd and ignore the username

Sep 12 2016, 8:53 PM
epriestley added a comment to Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).

I'd expect to just hide that in CLI porcelain:

Sep 12 2016, 8:51 PM
epriestley added Q489: What awful and unforetold security problems am I unleashing by allowing users to proxy arbitrary commands to drydock machines? (Answer 457).
Sep 12 2016, 8:33 PM
epriestley renamed T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action from Pressing "Ignore Setup Issue" during setup won't actually cause setup to ignore the issue. to PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.
Sep 12 2016, 8:07 PM · Setup, Bug Report
epriestley added a comment to T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.

This is unique to this particular setup check (open_basedir configured, but not in a way that creates a concrete problem we're able to detect).

Sep 12 2016, 8:06 PM · Setup, Bug Report
epriestley awarded T11308: Re-enable direct messaging in Conpherence a Pirate Logo token.
Sep 12 2016, 5:24 PM · Conpherence (v4)
epriestley added a comment to T11308: Re-enable direct messaging in Conpherence.

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/project/lipsum/PhabricatorProjectNameContextFreeGrammar.php

Sep 12 2016, 5:24 PM · Conpherence (v4)
chad awarded T11623: Make Conpherence send text with bare return key, like a chatroom a Party Time token.
Sep 12 2016, 5:03 PM · Conpherence (v4)
jonathanrseawright awarded T11623: Make Conpherence send text with bare return key, like a chatroom a Like token.
Sep 12 2016, 4:59 PM · Conpherence (v4)
epriestley added a comment to T11613: New install exception is wrong if preflight setup checks fail.

D16542 should fix this and reveal whatever the underlying error is.

Sep 12 2016, 2:45 PM · Bug Report (Needs Information), Setup
epriestley added a revision to T11613: New install exception is wrong if preflight setup checks fail: Unknown Object (Differential Revision).
Sep 12 2016, 2:36 PM · Bug Report (Needs Information), Setup
epriestley created T11623: Make Conpherence send text with bare return key, like a chatroom.
Sep 12 2016, 1:58 PM · Conpherence (v4)
epriestley added a comment to T11621: View full commit message in diffusion query results.

Yes, if you want the change to apply retroactively. Something like bin/repository reparse --message --all rXYZ, but see bin/repository help reparse first to test that on a few commits and make sure it does what you want.

Sep 12 2016, 1:56 PM · Diffusion, Search, Feature Request
epriestley created T11622: In mobile Conpherence, provide a way to upload files.
Sep 12 2016, 1:36 PM · Conpherence (v4), Files, Mobile
epriestley claimed T11613: New install exception is wrong if preflight setup checks fail.
Sep 12 2016, 1:30 PM · Bug Report (Needs Information), Setup
epriestley triaged T11618: "Edit Form Configuration" transaction history not easily accessible as Normal priority.
Sep 12 2016, 1:29 PM · Contributor Onboarding, Bug Report
epriestley added a project to T11618: "Edit Form Configuration" transaction history not easily accessible: Contributor Onboarding.

I don't think this is preview related -- I think PhabricatorEditEngineConfigurationTransaction just doesn't implement hasChangeDetails() and some related methods to generate this link.

Sep 12 2016, 1:29 PM · Contributor Onboarding, Bug Report
epriestley closed T11621: View full commit message in diffusion query results as Wontfix.

There is no such setting, and I believe this use case is very unusual -- it's like putting the subject line of email in the first line of the body -- so I currently have no plans to add support for it (see also T8227).

Sep 12 2016, 1:26 PM · Diffusion, Search, Feature Request
epriestley closed T11620: mysql setup issue as Invalid.

Sorry, we don't offer setup and configuration help. See Support Resources for discussion of what we do offer.

Sep 12 2016, 1:19 PM · Bug Report
apfols awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Sep 12 2016, 8:16 AM · Workboards (v3), Restricted Project

Sep 11 2016

epriestley closed T11615: teste as Spite.
Sep 11 2016, 1:29 PM

Sep 10 2016

joshuaspence renamed T11606: Allow custom fields to accept function tokens like "viewer()" from Allow custom "users" fields to accept function tokens like "viewer()" to Allow custom fields to accept function tokens like "viewer()".
Sep 10 2016, 12:44 AM · Custom Fields, Typeahead, Feature Request
joshuaspence added a project to T11606: Allow custom fields to accept function tokens like "viewer()": Custom Fields.
Sep 10 2016, 12:40 AM · Custom Fields, Typeahead, Feature Request
joshuaspence renamed T11609: Don't resize small pictures in Remarkup from don't resize small pictures in remarkup to Don't resize small pictures in Remarkup.
Sep 10 2016, 12:38 AM · Remarkup